Repository navigation
ci(cmux-next): preserve bot overflow after placement - #18145
teamleaderleo wants to merge 3 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…-bot-overflow # Conflicts: # .github/workflows/cmux-next.yml
|
Superseded on feat-cmux-next by #18615 (1beff16, "keep cmux-next minis first through bot retries"). Every macOS job's runs-on and CMUX_NEXT_RUNNER now gate the placement output on |
|
Parked: bot-overflow CI change has substantial workflow conflicts on current base; rebase exceeded this bounded pass. |
|
Reopen if needed. |
Changelog
Fixed: bot rescue reruns now use the Blacksmith fallback after the owned-pool placement attempt.
What changed
A full rerun retains the successful
macos-placementjob output. The Mac jobs now consume that output only through attempt 2 or a non-rescue trigger, so a bot attempt 3 cannot inherit the stale side label.Validation
python3 -m unittest tests.test_cmux_next_checks_workflow -q(39 passed)git diff --checkNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes bot rescue reruns of
cmux-nextmacOS jobs so attempts past the second fall back to Blacksmith instead of reusing the stale side-label placement output.Bot overflow
runs-onandCMUX_NEXT_RUNNERon the attempt/actor rule for swift-test, daemon-test, generated-files, release-compile, and cmux-scheme-compile.Written for commit ae06d2d. Summary will update on new commits.
Note
Low Risk
CI workflow expression change only; affects macOS runner selection on bot reruns, not application code or secrets.
Overview
Fixes owned-pool rescue overflow for
cmux-nextmacOS jobs whengithub-actions[bot]reruns a workflow after attempt 2.Previously,
runs-onandCMUX_NEXT_RUNNERalways preferredneeds.macos-placement.outputs.runnerwhen present. A full rerun reuses the successful placement job’s outputs, so bot attempt 3+ could keep scheduling on the stale mini/side label instead of the intended Blacksmith fallback.The expression now only honors placement output when
github.run_attempt <= 2or the trigger is not the bot—the same rule already used deeper in the fallback chain. swift-test, daemon-test, generated-files, release-compile, and cmux-scheme-compile are updated in bothruns-onandCMUX_NEXT_RUNNER.Adds
test_bot_overflow_ignores_stale_placement_outputintests/test_cmux_next_checks_workflow.pyto lock in the gated expression.Reviewed by Cursor Bugbot for commit ae06d2d. Bugbot is set up for automated code reviews on this repo. Configure here.