Skip to content

ci(cmux-next): preserve bot overflow after placement - #18145

Closed
teamleaderleo wants to merge 3 commits into
feat-cmux-nextfrom
fix/cx-next-bot-overflow
Closed

teamleaderleo wants to merge 3 commits into
feat-cmux-nextfrom
fix/cx-next-bot-overflow

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Changelog

Fixed: bot rescue reruns now use the Blacksmith fallback after the owned-pool placement attempt.

What changed

A full rerun retains the successful macos-placement job output. The Mac jobs now consume that output only through attempt 2 or a non-rescue trigger, so a bot attempt 3 cannot inherit the stale side label.

Validation

  • python3 -m unittest tests.test_cmux_next_checks_workflow -q (39 passed)
  • git diff --check

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes bot rescue reruns of cmux-next macOS jobs so attempts past the second fall back to Blacksmith instead of reusing the stale side-label placement output.

Bot overflow

  • Gated runs-on and CMUX_NEXT_RUNNER on the attempt/actor rule for swift-test, daemon-test, generated-files, release-compile, and cmux-scheme-compile.
  • Added workflow tests asserting the gate.

Written for commit ae06d2d. Summary will update on new commits.

View guided diff Turn on auto-fix


Note

Low Risk
CI workflow expression change only; affects macOS runner selection on bot reruns, not application code or secrets.

Overview
Fixes owned-pool rescue overflow for cmux-next macOS jobs when github-actions[bot] reruns a workflow after attempt 2.

Previously, runs-on and CMUX_NEXT_RUNNER always preferred needs.macos-placement.outputs.runner when present. A full rerun reuses the successful placement job’s outputs, so bot attempt 3+ could keep scheduling on the stale mini/side label instead of the intended Blacksmith fallback.

The expression now only honors placement output when github.run_attempt <= 2 or the trigger is not the bot—the same rule already used deeper in the fallback chain. swift-test, daemon-test, generated-files, release-compile, and cmux-scheme-compile are updated in both runs-on and CMUX_NEXT_RUNNER.

Adds test_bot_overflow_ignores_stale_placement_output in tests/test_cmux_next_checks_workflow.py to lock in the gated expression.

Reviewed by Cursor Bugbot for commit ae06d2d. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 68c05a05-3ee1-4781-9571-4affd4b24ae5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Superseded on feat-cmux-next by #18615 (1beff16, "keep cmux-next minis first through bot retries"). Every macOS job's runs-on and CMUX_NEXT_RUNNER now gate the placement output on (github.run_attempt <= 3 || github.triggering_actor != 'github-actions[bot]'), so a bot re-run leaves the placed label for Blacksmith at attempt 4. This PR's <= 2 gate would bring back the earlier overflow point that base moved on purpose. Nothing is left to merge, so I'm leaving it open for a human to close.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Parked: bot-overflow CI change has substantial workflow conflicts on current base; rebase exceeded this bounded pass.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant