Skip to content

fix(cmux-next): keep hidden WebViews out of scene captures - #17983

Closed
azooz2003-bit wants to merge 4 commits into
feat-cmux-nextfrom
fix/scene-compositing-v17
Closed

azooz2003-bit wants to merge 4 commits into
feat-cmux-nextfrom
fix/scene-compositing-v17

Conversation

@azooz2003-bit

Copy link
Copy Markdown
Collaborator

The v16 scene captures composited a parked Home WebView over the active Agent pane because the native base hid only selected pages. Composer and hint captures also froze a picker during its fade, and the sidebar scene restored width without selecting the tray look.

This follow-up to #17361 now hides every WKWebView while drawing the native base, snapshots only visible views with effective alpha, uses precomputed window coordinates in view order, waits for menu animations to finish, and selects the real tray look for sidebar-tiles. The render script fails closed if a manifest entry reports a hidden WebView composited.

Validation:

  • git diff --check
  • bash -n scripts/cmux-next/render-scenes.sh
  • exact-head fleet build and real seven-scene capture will be attached before merge

Follow-up to #17361.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Keeps hidden WebViews, parked tabs, and mid-animation menus out of scene captures so screenshots match what users see.

  • Hides every WKWebView while drawing the native base instead of only selected pages, so a parked Home WebView no longer overlays the active Agent pane.
  • Composits back only views visible at both selection and draw time, using precomputed window coordinates in view order and effective alpha across ancestors.
  • Fails the capture if a hidden WebView would have been composited or a visible WebView fails to snapshot, and render-scenes.sh exits on those errors.
  • Awaits menu animations with the Web Animations API and closes leftover menus before snapshotting.
  • Resets the sidebar look per scene so only sidebar-tiles uses the tray look.

Written for commit d45d303. Summary will update on new commits.

Review in cubic


Migrated from #17370 after correcting the PR author identity. The original head commit d45d303 is preserved.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c18c5918-5c1f-4c79-9b5b-8f432403b075

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants