Repository navigation
fix(cmux-next): keep hidden WebViews out of scene captures - #17983
Closed
azooz2003-bit wants to merge 4 commits into
Closed
azooz2003-bit wants to merge 4 commits into
azooz2003-bit wants to merge 4 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v16 scene captures composited a parked Home WebView over the active Agent pane because the native base hid only selected pages. Composer and hint captures also froze a picker during its fade, and the sidebar scene restored width without selecting the tray look.
This follow-up to #17361 now hides every WKWebView while drawing the native base, snapshots only visible views with effective alpha, uses precomputed window coordinates in view order, waits for menu animations to finish, and selects the real tray look for
sidebar-tiles. The render script fails closed if a manifest entry reports a hidden WebView composited.Validation:
git diff --checkbash -n scripts/cmux-next/render-scenes.shFollow-up to #17361.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Keeps hidden WebViews, parked tabs, and mid-animation menus out of scene captures so screenshots match what users see.
render-scenes.shexits on those errors.sidebar-tilesuses the tray look.Written for commit d45d303. Summary will update on new commits.
Migrated from #17370 after correcting the PR author identity. The original head commit d45d303 is preserved.