Skip to content

fix: close TTY attribution review gaps - #17944

Closed
azooz2003-bit wants to merge 2 commits into
mainfrom
fix/11004-cubic-followup
Closed

azooz2003-bit wants to merge 2 commits into
mainfrom
fix/11004-cubic-followup

Conversation

@azooz2003-bit

Copy link
Copy Markdown
Collaborator

Follow-up to merged PR #16559, addressing both cubic review findings.

  • Keep cmux launch evidence rooted at the app PID, independent of each window's app_process_pids, so non-key and workspace-filtered windows retain shell attribution without charging the app itself to their resources.
  • Expand process-group members only when the proven PID is still the live group leader, preventing PID-reuse attribution after a leader exits.
  • Add runtime regression coverage for both paths.

Regression-first commits:

  • b4e408f8ae2 adds the global launch-evidence and stale-group tests.
  • d837e94cca2 applies the fixes.

Validation: ./scripts/sync-test-wiring --check, git diff --check.

— Cattail g1 🔸


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes TTY attribution gaps left by the prior cubic-review follow-up: launch evidence is now rooted at the cmux app PID so shells in non-key or workspace-filtered windows retain attribution, and process-group members are only attributed while their proven leader is still the live group leader, preventing PID-reuse misattribution. Adds regression tests covering both paths.

Written for commit d837e94. Summary will update on new commits.

Review in cubic


Migrated from #16619 after correcting the PR author identity. The original head commit d837e94 is preserved.

@cursor

cursor Bot commented Oct 6, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: a34df22f-155d-4908-ad11-1e9a8b52ac97
📥 Commits

Reviewing files that changed from the base of the PR and between ccefb63 and d837e94.

📒 Files selected for processing (3)
  • Sources/CmuxTopTTYOwnership.swift
  • Sources/TerminalControllerTopSupport.swift
  • cmuxTests/CmuxTopTTYCollisionAttributionTests.swift
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Note

Pull Request opener @azooz2003-bit is not an author or co-author of any commit in this PR (commit identities: teamleaderleo). The CLA check will still proceed and requires every listed identity plus @azooz2003-bit to have signed.

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants