Repository navigation
fix: close TTY attribution review gaps - #17944
azooz2003-bit wants to merge 2 commits into
Conversation
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note Pull Request opener @azooz2003-bit is not an author or co-author of any commit in this PR (commit identities: All contributors have signed the CLA ✍️ ✅ |
Follow-up to merged PR #16559, addressing both cubic review findings.
app_process_pids, so non-key and workspace-filtered windows retain shell attribution without charging the app itself to their resources.Regression-first commits:
b4e408f8ae2adds the global launch-evidence and stale-group tests.d837e94cca2applies the fixes.Validation:
./scripts/sync-test-wiring --check,git diff --check.— Cattail g1 🔸
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes TTY attribution gaps left by the prior cubic-review follow-up: launch evidence is now rooted at the cmux app PID so shells in non-key or workspace-filtered windows retain attribution, and process-group members are only attributed while their proven leader is still the live group leader, preventing PID-reuse misattribution. Adds regression tests covering both paths.
Written for commit d837e94. Summary will update on new commits.
Migrated from #16619 after correcting the PR author identity. The original head commit d837e94 is preserved.