Skip to content

cmux-next CI: run OmnibarFieldEditorTests in the isolated field-editor step #17941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
azooz2003-bit wants to merge 3 commits into from
Closed

cmux-next CI: run OmnibarFieldEditorTests in the isolated field-editor step #17941

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0fece1e
ci(cmux-next): run OmnibarFieldEditorTests in the isolated field-edit…
teamleaderleo Oct 6, 2026
f1c6a5a
Merge remote-tracking branch 'origin/feat-cmux-next' into next-omniba…
teamleaderleo Oct 6, 2026
787ab79
Merge remote-tracking branch 'origin/feat-cmux-next' into next-omniba…
teamleaderleo Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/cmux-next.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,7 +697,7 @@ jobs:
echo "Test targets: $SWIFT_TARGETS"
filter=()
[[ -z "$SWIFT_FILTER" ]] || filter=(--filter "$SWIFT_FILTER")
../../../scripts/cmux-next/swift-test-with-hang-sampler.sh --skip-build ${filter[@]+"${filter[@]}"} --skip CmuxNextControlTests --skip CmuxNextBrowserAutomationTests --skip TerminalAttachDriverStressTests --skip ActionRunWaitTests --skip DaemonClosedHistoryTests --skip EphemeralWorkspaceTests --skip StateMutationRoutingTests --skip OmnibarTypingTests --skip BranchStateResourcesTests
../../../scripts/cmux-next/swift-test-with-hang-sampler.sh --skip-build ${filter[@]+"${filter[@]}"} --skip CmuxNextControlTests --skip CmuxNextBrowserAutomationTests --skip TerminalAttachDriverStressTests --skip ActionRunWaitTests --skip DaemonClosedHistoryTests --skip EphemeralWorkspaceTests --skip StateMutationRoutingTests --skip OmnibarTypingTests --skip OmnibarFieldEditorTests --skip BranchStateResourcesTests

# Each isolated step below runs when its suites' target is selected and
# the build succeeded, even after a failed test step, so one red step
Expand Down Expand Up @@ -725,13 +725,16 @@ jobs:
# The real field editor and state-resource event round trips need their
# own process: unrelated UI suites can change focus or delay callbacks
# beyond these tests' existing deadlines. Every test still runs.
# OmnibarFieldEditorTests: in the shared process the field editor lost its
# IME marked text mid-test (1 of 4 package runs; 0 of 11 alone or with
# only the browser target).
- name: Run field-editor and state-resource regressions
if: ${{ !cancelled() && steps.build-tests.outcome == 'success' && (env.SWIFT_TARGETS == 'all' || contains(env.SWIFT_TARGETS, 'CmuxNextBrowserTests') || contains(env.SWIFT_TARGETS, 'CmuxNextDaemonTests')) }}
timeout-minutes: 10
working-directory: Packages/macOS/CmuxNext
env:
CMUX_NEXT_TEST_HANG_SECONDS: "480"
run: ../../../scripts/cmux-next/swift-test-with-hang-sampler.sh --skip-build --no-parallel --filter 'OmnibarTypingTests|BranchStateResourcesTests'
run: ../../../scripts/cmux-next/swift-test-with-hang-sampler.sh --skip-build --no-parallel --filter 'OmnibarTypingTests|OmnibarFieldEditorTests|BranchStateResourcesTests'

# The WebKit driver tests drive real WKWebViews against wall-clock load
# deadlines through main-actor navigation callbacks. They run in a
Expand Down
Loading