Repository navigation
fix: render local UI test artifacts - #17854
azooz2003-bit wants to merge 3 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Unclear: CI stopped on
Not re-run automatically: Written by |
What changed
scripts/ui-testnow recognizes a localui-framesdirectory as review input instead of treating its path as a new test selector.e2e-frames.pyloads the existingsteps.mdmanifests directly and can copy them to--out, so downloaded or handoff artifacts can be opened in the static UI mirror without another CI dispatch or native toolchain.This is stacked on #15853.
Changelog
scripts/ui-testrender already-downloaded UI test artifacts locally.Validation
python3 tests/test_ui_test_local_artifact.py(regression: red on the first commit, green after the fix)python3 tests/test_ui_mirror.pypython3 tests/test_ci_e2e_compilation_cache.pypython3 tests/test_run_e2e.pypython3 scripts/verify-local.py --affected feat/ui-iteration-mirror --timeout 180(14/14 checks passed)bash -n scripts/ui-testpython3 -m py_compile scripts/ci/e2e-frames.py tests/test_ui_test_local_artifact.pygit diff --checkNo Xcode, Swift compiler, native app build, app launch, or restart was run.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Makes
scripts/ui-testrender already-downloaded UI test artifacts locally, so copiedui-framesdirectories can be reviewed without dispatching another CI run or needing the native toolchain.scripts/ui-testnow treats an existing path argument as a local artifact instead of a test selector, ande2e-frames.pyreads the artifact'ssteps.mdmanifests and can copy them to--out.scripts/ci/ui-mirror.py, which builds a static interactiveindex.htmlplus a machine-readablemirror.jsonnext to the frames; CI now uploads and links these.Written for commit 6799c22. Summary will update on new commits.
Migrated from #15870 after correcting the PR author identity. The head branch and commit history are preserved.