Repository navigation
Settings: Font card with live preview, font gallery, and line height - #17716
azooz2003-bit wants to merge 11 commits into
Conversation
Settings > Terminal now opens with a Font card: a preview of shell and code in the chosen font, size and line height, a searchable font list that draws each installed monospaced font in its own face (hover to preview, click to apply), and rows for font size, line height (adjust-cell-height) and thicker strokes (font-thicken). The Font card and the Ghostty options card share one options model so an edit in either survives the other's refresh. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…s, fix search anchors Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…xel line height steps Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…e height, restore) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…I test Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…he font button Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 53 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (20)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note Pull Request opener @azooz2003-bit is not an author or co-author of any commit in this PR (commit identities: All contributors have signed the CLA ✍️ ✅ |
Changing the terminal font meant picking a name from a plain-text menu in the middle of the Ghostty options card, with no way to see a font before applying it. This PR puts fonts first.
Settings > Terminal now opens with a Font card:
0O 1lI |! => != -> {}[]().adjust-cell-height), a percentage stepper. A pixel value set in a config file is shown as+N px.font-thicken).Every row still writes one key to cmux's Ghostty config and names a later-loading file that overrides it. The Font card and the Ghostty options card now share one
TerminalGhosttyOptionsModel, so an edit in one isn't undone when the other refreshes. Settings search finds the new rows ("line height", "thicken", "change font").Screenshots
Recorded in the app by
SettingsTerminalBehaviorUITests.testFontCardShowsPreviewAndFontGalleryon a CI Mac at b005102 (run https://github.com/manaflow-ai/cmux/actions/runs/36442773211): open the gallery, hover Courier New and Menlo (the preview follows), search "men", pick Menlo, step Line Height to +10%, then restore the defaults.ui-lab renders of the preview and gallery (
scripts/ui-lab/ui-lab.py scripts/ui-lab/harnesses/terminal-font-card.swift):Preview, default font (JetBrains Mono, 13 pt):

Preview, Menlo 14 pt with +10% line height:

Preview, Courier New 16 pt:

Changelog
Added: Settings > Terminal has a Font card with a live preview, a searchable font gallery that shows each font in its own face, and Line Height and Thicker Strokes settings.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Settings > Terminal now opens with a Font card that shows a live preview of shell and code in the chosen font, size, and line height, plus a searchable gallery of installed monospaced fonts drawn in their own faces.
adjust-cell-height) and Thicker Strokes (font-thicken) rows.8%) or device pixels (2), with a pixel value from a config file shown as+N px; invalid spellings like15 %are rejected.TerminalGhosttyOptionsModel, so an edit in one isn't undone by the other's refresh.Written for commit d1a7642. Summary will update on new commits.
Summary by CodeRabbit
Migrated from #15210 after correcting the PR author identity. The head branch and commit history are preserved.