Skip to content

cmux-next CI: run OmnibarFieldEditorTests in the isolated field-editor step - #17686

Closed
azooz2003-bit wants to merge 3 commits into
feat-cmux-nextfrom
next-omnibar-field-editor-isolated
Closed

azooz2003-bit wants to merge 3 commits into
feat-cmux-nextfrom
next-omnibar-field-editor-isolated

Conversation

@azooz2003-bit

Copy link
Copy Markdown
Collaborator

Summary

OmnibarFieldEditorTests.markedTextNeverCompletesAndItsCommitDoes fails intermittently on CI (for example #17520, job 112399297991: isComposing false, 35.8 s) and blocks unrelated PRs.

The failure isn't a check that runs too early. On a fleet mini, running the whole package the way CI does, the failure reproduced in 1 of 4 runs. In that run, the field editor itself dropped its IME marked text partway through the test (editor.hasMarkedText() false while it was still first responder), and the omnibar state followed. No wait inside the test can fix that. With the suite alone (8 runs) or with only CmuxNextBrowserTests at CI's width (3 runs), it passed every time.

So the suite now runs in the existing isolated field-editor step, next to OmnibarTypingTests, which runs alone for the same reason ("unrelated UI suites can change focus"). It's skipped in the shared step, and every test still runs.

run suite passed
whole package, width 6 3 of 4
suite alone 8 of 8
CmuxNextBrowserTests only, width 6 3 of 3

Verification

  • The repro probe ran on the fleet at the base commit, with print-only diagnostics. The probe branch has been deleted.
  • This PR edits only the workflow. The cmux-next swift test job on this PR runs the suite in the isolated step.
  • This lane runs without sub-agents, so no review subagent was used.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Moves OmnibarFieldEditorTests into the existing isolated field-editor CI step so its intermittent IME-related failures no longer block unrelated PRs.

  • Fails 1 of 4 full-package runs because the field editor drops its IME marked text mid-test; no wait inside the test can fix that.
  • Passed 8 of 8 runs alone and 3 of 3 with only CmuxNextBrowserTests.
  • Skips the suite in the shared package-test step; all tests still run.
  • Touches only .github/workflows/cmux-next.yml.

Written for commit 787ab79. Summary will update on new commits.

Review in cubic Turn on auto-fix

teamleaderleo and others added 3 commits October 6, 2026 10:49
…or step

In the shared package-test process the omnibar's field editor lost its
IME marked text mid-test (markedTextNeverCompletesAndItsCommitDoes): 1
of 4 whole-package runs on the fleet, 0 of 11 with the suite alone or
with only CmuxNextBrowserTests. The editor itself dropped it while still
first responder, so no wait in the test can fix it. The suite joins
OmnibarTypingTests in its own process; every test still runs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 87a7cf33-2137-4f87-a7aa-5a1032c29f06

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants