Repository navigation
cmux-next CI: run OmnibarFieldEditorTests in the isolated field-editor step - #17686
Closed
azooz2003-bit wants to merge 3 commits into
Closed
azooz2003-bit wants to merge 3 commits into
azooz2003-bit wants to merge 3 commits into
Conversation
…or step In the shared package-test process the omnibar's field editor lost its IME marked text mid-test (markedTextNeverCompletesAndItsCommitDoes): 1 of 4 whole-package runs on the fleet, 0 of 11 with the suite alone or with only CmuxNextBrowserTests. The editor itself dropped it while still first responder, so no wait in the test can fix it. The suite joins OmnibarTypingTests in its own process; every test still runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r-field-editor-isolated
…r-field-editor-isolated
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OmnibarFieldEditorTests.markedTextNeverCompletesAndItsCommitDoesfails intermittently on CI (for example #17520, job 112399297991:isComposingfalse, 35.8 s) and blocks unrelated PRs.The failure isn't a check that runs too early. On a fleet mini, running the whole package the way CI does, the failure reproduced in 1 of 4 runs. In that run, the field editor itself dropped its IME marked text partway through the test (
editor.hasMarkedText()false while it was still first responder), and the omnibar state followed. No wait inside the test can fix that. With the suite alone (8 runs) or with onlyCmuxNextBrowserTestsat CI's width (3 runs), it passed every time.So the suite now runs in the existing isolated field-editor step, next to
OmnibarTypingTests, which runs alone for the same reason ("unrelated UI suites can change focus"). It's skipped in the shared step, and every test still runs.CmuxNextBrowserTestsonly, width 6Verification
cmux-next swift testjob on this PR runs the suite in the isolated step.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Moves
OmnibarFieldEditorTestsinto the existing isolated field-editor CI step so its intermittent IME-related failures no longer block unrelated PRs.CmuxNextBrowserTests..github/workflows/cmux-next.yml.Written for commit 787ab79. Summary will update on new commits.