Skip to content

test(cmux-next): the busy work-queue test bounds against its deadline, not 100 ms - #17655

Merged
teamleaderleo merged 5 commits into
feat-cmux-nextfrom
fix/next-work-queue-busy-timing
Oct 8, 2026
Merged

teamleaderleo merged 5 commits into
feat-cmux-nextfrom
fix/next-work-queue-busy-timing

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

MainActorWorkQueueTests.failsFastWithBusyBeyondTheLimit measured 0.289 s against a 100 ms bound on #17611 under the full parallel suite.

The test needs to show that a full queue answers busy right away instead of waiting for room. No frame fires before the third call, so a queue that waited could only answer when the deadline expired, and it would answer with a timeout, not busy. The deadline is now 30 s and the bound is 10 s, so the test still catches a waiting queue and a loaded runner can't trip it.

Test-only.

Testing

  • Not run locally (fleet builds only). This PR's cmux-next swift test job is the green check.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes a flaky MainActorWorkQueueTests failure that measured 289 ms against a 100 ms bound under the full parallel suite.

  • Bounds the busy fast path against its 30 s deadline with a 10 s bound, still catching a queue that waits while tolerating loaded runners.
  • Test-only change; no production behavior or changelog impact.

Written for commit 87e992d. Summary will update on new commits.

View guided diff Turn on auto-fix


Note

Low Risk
Test-only timing and documentation changes with no production code impact.

Overview
Relaxes timing in failsFastWithBusyBeyondTheLimit so it stays reliable on loaded CI: the request deadline goes from 5 s to 30 s, and the assertion that the third call returns busy quickly is loosened from 100 ms to 10 s (still well under the deadline so a queue that waits for a timeout would still fail).

Adds an inline comment documenting that the old 100 ms ceiling flaked at ~289 ms on a parallel runner (#17611). Test-only; production MainActorWorkQueue behavior is unchanged.

Reviewed by Cursor Bugbot for commit 87e992d. Bugbot is set up for automated code reviews on this repo. Configure here.

…, not 100 ms

The property is that a full queue answers busy instead of waiting, and a
waiting queue would only answer at the deadline. A 100 ms bound measured
289 ms on a loaded runner (#17611); the bound is now 10 s against a 30 s
deadline.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 933cd98f-b2da-44e3-9c0d-bb2a2f23fa66

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Not verified: macOS jobs did not run: compile and app tests were skipped on 87e992dbe0; ci-status is green without them.

CI passes on 87e992dbe0 (run 37829860048 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Batch queue: dropped from this batch, turns heavy tier red.

  • same-tree cmux-tui

Next: fix, push.

@blacksmith-sh

blacksmith-sh Bot commented Oct 8, 2026

Copy link
Copy Markdown

Found 23 test failures on Blacksmith runners:

Failures

Test View Logs
test_every_routed_input_triggers_the_workflow (main.PullRequestTiers.test_every_rou
ted_input_triggers_the_workflow) (path='backend/packages/home-core/conformance/
conversation-cases.json')
View Logs
test_every_routed_input_triggers_the_workflow (main.PullRequestTiers.test_every_rou
ted_input_triggers_the_workflow) (path='backend/packages/home-core/conformance/
conversation-import-cases.json')
View Logs
test_every_routed_input_triggers_the_workflow (main.PullRequestTiers.test_every_rou
ted_input_triggers_the_workflow) (path='backend/packages/home-core/conformance/
conversation-search-cases.json')
View Logs
test_every_routed_input_triggers_the_workflow (main.PullRequestTiers.test_every_rou
ted_input_triggers_the_workflow) (path='mux/packages/brain/conformance/
chief-cases.json')
View Logs
test_every_routed_input_triggers_the_workflow (main.PullRequestTiers.test_every_rou
ted_input_triggers_the_workflow) (path='scripts/ci/cmux-tui-darwin-builder')
View Logs
test_every_routed_input_triggers_the_workflow (main.PullRequestTiers.test_every_rou
ted_input_triggers_the_workflow) (path='scripts/ci/macho_weaken.py')
View Logs
test_every_routed_input_triggers_the_workflow (main.PullRequestTiers.test_every_rou
ted_input_triggers_the_workflow) (path='scripts/ci/macos-cross.sh')
View Logs
test_every_routed_input_triggers_the_workflow (main.PullRequestTiers.test_every_rou
ted_input_triggers_the_workflow) (path='scripts/ci/macos_stubs.py')
View Logs
test_every_routed_input_triggers_the_workflow (main.PullRequestTiers.test_every_rou
ted_input_triggers_the_workflow) (path='scripts/ci/macos-stubs/x')
View Logs
test_every_routed_input_triggers_the_workflow (main.PullRequestTiers.test_every_rou
ted_input_triggers_the_workflow) (path='skills/cmux-browser/SKILL.md')
View Logs

...and 13 more test failures. View all on Blacksmith

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo
teamleaderleo merged commit aed86cd into feat-cmux-next Oct 8, 2026
55 of 58 checks passed
@teamleaderleo
teamleaderleo deleted the fix/next-work-queue-busy-timing branch October 8, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants