Skip to content

fix: skip Cloud welcome on dev launches #17647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
austinywang merged 1 commit into from
Oct 6, 2026
Merged

fix: skip Cloud welcome on dev launches #17647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Sources/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5567,14 +5567,21 @@ final class AppDelegate: NSObject, NSApplicationDelegate, UNUserNotificationCent
presentCloudWelcomeIfNeeded(over: window)
}

/// Once per Mac, after the first main window is up. Tests never see it.
/// In release builds, once per Mac after the first main window is up. Tests
/// never see it; debug builds can open it from Help when needed.
private func presentCloudWelcomeIfNeeded(over window: NSWindow) {
#if DEBUG
// Keep the first-run welcome available from Help while iterating on the
// app, but do not interrupt every development launch with it.
return
#else
let env = ProcessInfo.processInfo.environment
guard !isRunningUnderXCTestCached, !isRunningUnderXCTest(env), env["CMUX_UI_TEST_MODE"] != "1" else { return }
// Next turn of the main loop, so the window is on screen to place it over.
DispatchQueue.main.async { [weak self, weak window] in
self?.cloudWelcomeWindowController.presentIfNeeded(over: window)
}
#endif
}

#if DEBUG
Expand Down
Loading