cmux-next CI: run OmnibarFieldEditorTests in the isolated field-editor step by teamleaderleo · Pull Request #17626 · manaflow-ai/cmux

teamleaderleo · 2026-10-06T19:06:10Z

Summary

OmnibarFieldEditorTests.markedTextNeverCompletesAndItsCommitDoes fails intermittently on CI (for example #17520, job 112399297991: isComposing false, 35.8 s) and blocks unrelated PRs.

The failure isn't a check that runs too early. On a fleet mini, running the whole package the way CI does, the failure reproduced in 1 of 4 runs. In that run, the field editor itself dropped its IME marked text partway through the test (editor.hasMarkedText() false while it was still first responder), and the omnibar state followed. No wait inside the test can fix that. With the suite alone (8 runs) or with only CmuxNextBrowserTests at CI's width (3 runs), it passed every time.

So the suite now runs in the existing isolated field-editor step, next to OmnibarTypingTests, which runs alone for the same reason ("unrelated UI suites can change focus"). It's skipped in the shared step, and every test still runs.

run	suite passed
whole package, width 6	3 of 4
suite alone	8 of 8
`CmuxNextBrowserTests` only, width 6	3 of 3

Verification

The repro probe ran on the fleet at the base commit, with print-only diagnostics. The probe branch has been deleted.
This PR edits only the workflow. The cmux-next swift test job on this PR runs the suite in the isolated step.
This lane runs without sub-agents, so no review subagent was used.

Changelog

none

🤖 Generated with Claude Code

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

Summary by cubic

Moves OmnibarFieldEditorTests into the existing isolated field-editor CI step so its intermittent IME-related failures no longer block unrelated PRs.

Fails 1 of 4 full-package runs because the field editor drops its IME marked text mid-test; no wait inside the test can fix that.
Passed 8 of 8 runs alone and 3 of 3 with only CmuxNextBrowserTests.
Skips the suite in the shared package-test step; all tests still run.
Touches only .github/workflows/cmux-next.yml.

^{Written for commit e610376. Summary will update on new commits.}

…or step In the shared package-test process the omnibar's field editor lost its IME marked text mid-test (markedTextNeverCompletesAndItsCommitDoes): 1 of 4 whole-package runs on the fleet, 0 of 11 with the suite alone or with only CmuxNextBrowserTests. The editor itself dropped it while still first responder, so no wait in the test can fix it. The suite joins OmnibarTypingTests in its own process; every test still runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…r-field-editor-isolated

coderabbitai · 2026-10-06T19:06:20Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 80e7f291-d1c4-497c-a9c4-5a31073816a5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…r-field-editor-isolated

teamleaderleo · 2026-10-06T19:33:18Z

Thanks for root-causing this. OmnibarSelectionViewTests fails the same way in the shared process (caret at the end of the full URL, #17601), so #17650 stacks one more suite onto this isolated step.

github-actions · 2026-10-06T22:42:03Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37531168822 at cbae0d8 failed: cmux-next swift test, wait for the same-tree cmux-tui.
Those jobs last passed at 1642d65. This pull request is one of 2 merged since: #17557, #17626.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

github-actions · 2026-10-06T22:50:41Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37531238294 at 32e07d1 failed: cmux-next swift test, wait for the same-tree cmux-tui.
Those jobs last passed at 1642d65. This pull request is one of 2 merged since: #17557, #17626.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

…17652) * test(cmux-next): a density change keeps the omnibar's selection and marked text Red on the current code: the density binding writes the field text again, which replaces the active field editor's storage, drops the marked text and puts the caret at the end. OmnibarViewTests changes the density while the other omnibar suites run, which is the flake in OmnibarFieldEditorTests and OmnibarSelectionViewTests (#17601, #17626). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cmux-next): a density change restyles the omnibar field in place The density binding wrote the field text again, which replaced the active field editor's storage: an input method's composition was dropped and the caret moved to the end of the URL. It now sets the font on the editor's text in place, as a theme change recolors it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(cmux-next): the density test runs the bar's appliers, not a global change Changing DesignSettings.shared mid-test would disturb the suites running beside it, the failure this PR fixes. The test runs the bar's density appliers directly instead; restyle documents that it sets only the font while editing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

teamleaderleo and others added 2 commits October 6, 2026 10:49

Merge remote-tracking branch 'origin/feat-cmux-next' into next-omniba…

f1c6a5a

…r-field-editor-isolated

teamleaderleo requested a review from lawrencecchen as a code owner October 6, 2026 19:06

Merge remote-tracking branch 'origin/feat-cmux-next' into next-omniba…

787ab79

…r-field-editor-isolated

teamleaderleo mentioned this pull request Oct 6, 2026

ci(cmux-next): run OmnibarSelectionViewTests in the isolated field-editor step #17650

Closed

teamleaderleo mentioned this pull request Oct 6, 2026

fix(cmux-next): a density change restyles the omnibar field in place #17652

Merged

This was referenced Oct 6, 2026

fix(cmux-next): a density change restyles the omnibar field in place #17667

Closed

ci(cmux-next): run OmnibarSelectionViewTests in the isolated field-editor step #17668

Closed

azooz2003-bit closed this Oct 6, 2026

azooz2003-bit mentioned this pull request Oct 6, 2026

fix(cmux-next): a density change restyles the omnibar field in place #17909

Closed

azooz2003-bit reopened this Oct 6, 2026

This was referenced Oct 6, 2026

fix(cmux-next): a density change restyles the omnibar field in place #17922

Closed

ci(cmux-next): run OmnibarSelectionViewTests in the isolated field-editor step #17923

Closed

azooz2003-bit closed this Oct 6, 2026

azooz2003-bit mentioned this pull request Oct 6, 2026

cmux-next CI: run OmnibarFieldEditorTests in the isolated field-editor step #17941

Closed

azooz2003-bit reopened this Oct 6, 2026

azooz2003-bit closed this Oct 6, 2026

azooz2003-bit reopened this Oct 6, 2026

Merge remote-tracking branch 'origin/feat-cmux-next' into HEAD

e610376

teamleaderleo merged commit cbae0d8 into feat-cmux-next Oct 6, 2026
34 of 37 checks passed

teamleaderleo deleted the next-omnibar-field-editor-isolated branch October 6, 2026 21:04

github-actions Bot mentioned this pull request Oct 6, 2026

cmux-next: launch marks, a launch bench with profiles and stalls, and a launch-time budget in CI #17557

Merged

Navigation Menu

Repository navigation

cmux-next CI: run OmnibarFieldEditorTests in the isolated field-editor step - #17626

cmux-next CI: run OmnibarFieldEditorTests in the isolated field-editor step#17626
teamleaderleo merged 4 commits into
feat-cmux-nextfrom
next-omnibar-field-editor-isolated

teamleaderleo commented Oct 6, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 6, 2026 •

edited

Loading

Review skipped

Uh oh!

teamleaderleo commented Oct 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions Bot commented Oct 6, 2026

Uh oh!

github-actions Bot commented Oct 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

teamleaderleo commented Oct 6, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Changelog

Summary by cubic

Uh oh!

coderabbitai Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

teamleaderleo commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 6, 2026

Uh oh!

github-actions Bot commented Oct 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

teamleaderleo commented Oct 6, 2026 •

edited by cubic-dev-ai Bot

Loading

coderabbitai Bot commented Oct 6, 2026 •

edited

Loading

teamleaderleo commented Oct 6, 2026 •

edited

Loading