Skip to content

cmux-next: format two Settings page files that fail vp check - #17621

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
feat-cmux-next-settings-fmt
Oct 6, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
feat-cmux-next-settings-fmt

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Formatting only. vp fmt (the repo formatter) runs on the two Settings page files that fail react-apps-check's format step on feat-cmux-next and so on every PR against it:

  • webviews/src/pages/settings/components/SectionList.tsx
  • webviews/src/pages/settings/hostCards.test.tsx

Both came in with 8e8149d. No other file and no behavior change.

Testing

  • Before: vp check --no-lint reported formatting issues in exactly these two files.
  • After: vp check --no-lint reports all 860 files formatted and no type errors.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Runs the repo formatter (vp fmt) on two Settings page files so the react-apps-check format step passes on every PR against feat-cmux-next.

Formatting only — no behavior change. vp check --no-lint previously flagged webviews/src/pages/settings/components/SectionList.tsx and webviews/src/pages/settings/hostCards.test.tsx; it now reports all 860 files formatted with no type errors.

Written for commit 9e26462. Summary will update on new commits.

Review in cubic Turn on auto-fix

SectionList.tsx and hostCards.test.tsx, from 8e8149d, fail the
react-apps-check format check on every PR; vp fmt on those two files,
nothing else.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: fe1ab989-a78a-4473-b209-0a8a0f383c6c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo
teamleaderleo merged commit 3ed8023 into feat-cmux-next Oct 6, 2026
43 checks passed
@teamleaderleo
teamleaderleo deleted the feat-cmux-next-settings-fmt branch October 6, 2026 18:32
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37515600457 at ff267c4 failed: cmux-next swift test.
Those jobs last passed at 3088ebf. This pull request is one of 5 merged since: #17597, #17537, #17621, #17600, #17605.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant