Skip to content

cmux-next: Back returns to the New Tab page after a jump - #17604

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
op-next-newtab-back
Oct 6, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
op-next-newtab-back

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

After jumping from the New Tab page to a tab, Back now returns to the New Tab page.

The location trail steps only between workspaces by default, so a jump to a tab in the same workspace replaced the New Tab page's entry instead of adding one. A jump made soon after the page opened was also merged into it as a quick sweep. A jump picked in the New Tab location bar now records its own step (LocationTrail.recordJump, armed by LocationTrailService.noteJump from NewTabPage.jump).

Opening a recent chat from the page's cards still turns the page into that chat in place, in the same tab. Back does not undo that, since no other tab is involved.

Testing

  • Failing tests first (d4747ac): LocationTrailJumpTests, LocationTrailWiringTests.aNewTabJumpInsideTheWorkspaceIsABackStep.

Changelog

  • Fixed: Back returns to the New Tab page after jumping from it to another tab.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes Back navigation from the New Tab page: a tab picked from its location bar is now its own step on the location trail, even inside the same workspace and right after the page opened, so Back returns to the New Tab page.

Opening a recent chat from the page's cards is unchanged: it turns the page into that chat in place, and Back does not undo it.

Written for commit 0daf692. Summary will update on new commits.

Review in cubic Turn on auto-fix

teamleaderleo and others added 2 commits October 6, 2026 10:33
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A tab picked from the New Tab page's location bar is now its own step on
the location trail, even in the same workspace and right after the page
opened, so Back returns to the New Tab page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: bbd5dd78-9fd4-42a8-a022-12c198fce466

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Not verified: macOS jobs did not run: compile and app tests were skipped on 0daf692fe2; ci-status is green without them.

CI passes on 0daf692fe2 (run 37504638523 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way.

@teamleaderleo
teamleaderleo merged commit 3dca23d into feat-cmux-next Oct 6, 2026
53 checks passed
@teamleaderleo
teamleaderleo deleted the op-next-newtab-back branch October 6, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant