Repository navigation
cmux-next: Back returns to the New Tab page after a jump - #17604
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A tab picked from the New Tab page's location bar is now its own step on the location trail, even in the same workspace and right after the page opened, so Back returns to the New Tab page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
Summary
After jumping from the New Tab page to a tab, Back now returns to the New Tab page.
The location trail steps only between workspaces by default, so a jump to a tab in the same workspace replaced the New Tab page's entry instead of adding one. A jump made soon after the page opened was also merged into it as a quick sweep. A jump picked in the New Tab location bar now records its own step (
LocationTrail.recordJump, armed byLocationTrailService.noteJumpfromNewTabPage.jump).Opening a recent chat from the page's cards still turns the page into that chat in place, in the same tab. Back does not undo that, since no other tab is involved.
Testing
LocationTrailJumpTests,LocationTrailWiringTests.aNewTabJumpInsideTheWorkspaceIsABackStep.Changelog
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes Back navigation from the New Tab page: a tab picked from its location bar is now its own step on the location trail, even inside the same workspace and right after the page opened, so Back returns to the New Tab page.
Opening a recent chat from the page's cards is unchanged: it turns the page into that chat in place, and Back does not undo it.
Written for commit 0daf692. Summary will update on new commits.