Skip to content

test(cmux-next): reserve the cloexec probe descriptor - #17599

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
fix/cmux-next-cloexec-probe
Oct 6, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
fix/cmux-next-cloexec-probe

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The daemon socket CLOEXEC test probed a low descriptor number directly. A shell or unrelated inherited descriptor could occupy that number and make the redirection succeed even when the transport socket was correctly closed on exec.

Duplicate the descriptor into a reserved high range while preserving its descriptor flags before spawning the probe shell. The test still asserts the transport's FD_CLOEXEC bit and retains the no-CLOEXEC control case.

Validation

  • python3 scripts/verify-local.py --only swift-syntax --swift-changed origin/feat-cmux-next
  • Fleet daemon test job required for native validation

Changelog

Fixed flaky daemon socket close-on-exec coverage.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes the daemon socket CLOEXEC test so it no longer falsely passes when an unrelated inherited descriptor occupies the probed number. The test now duplicates the descriptor into a reserved range (≥ 128) while preserving its flags before spawning the probe shell, and still asserts the transport's FD_CLOEXEC bit with the no-CLOEXEC control case intact.

Written for commit 7252072. Summary will update on new commits.

Review in cubic Turn on auto-fix

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 3e6f3713-6792-4d09-a958-7ae7969e3479

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Not verified: macOS jobs did not run: compile and app tests were skipped on 7252072794; ci-status is green without them.

CI passes on 7252072794 (run 37506396810 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Exact-head fleet compile completed successfully for 7252072794face1ad38d59c777e46e53ab62c8ea (receipt f2d1e6c12af262718ec5dd90). The descriptor probe remains covered by the PR's focused change; GitHub macOS test lanes are queued behind the same-tree cmux-tui artifact.

@teamleaderleo
teamleaderleo merged commit 3088ebf into feat-cmux-next Oct 6, 2026
63 of 72 checks passed
@teamleaderleo
teamleaderleo deleted the fix/cmux-next-cloexec-probe branch October 6, 2026 18:08
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37510291185 at 8e8149d failed: cmux-next generated files, cmux-next swift test.
Those jobs last passed at 9872eec. This pull request is one of 1 merged since: #17599.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37510568883 at df62960 failed: cmux-next Release compile (Xcode 26), cmux-next swift test.
Those jobs last passed at 9872eec. This pull request is one of 2 merged since: #17599, #17597.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/37510605955 at 96f7421 failed: cmux-next generated files, cmux-next swift test.
Those jobs last passed at 9872eec. This pull request is one of 3 merged since: #17599, #17597, #17537.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

This branch was successfully deployed

1 active deployment
artifacts — 72520727 Deployed Oct 6, 2026 by teamleaderleo via publish tree-addressed cmux-tui #1631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant