Repository navigation
cmux-next sidebar: headers keep their layout on hover - #17591
Conversation
cmux-b2's flicker sweep: a group or section header's hover controls narrowed its name, and a titled section's chevron mounted on hover. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A group header reserves its edit, add and count slots and a machine header its add slot, so hovering never re-truncates the name. A titled section's chevron stays mounted and fades. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
|
Batch queue: green. Batch stack Next: land it yourself with gh-merge-green on this receipt. |
|
Group header hover, long name, narrow sidebar. Each strip is at rest, then hovered, then at rest again. Before: the name is laid out at full width at rest and re-truncates when the hover controls appear, so the text moves under the pointer. After: the header always reserves the control slots, so the name truncates the same way at rest and on hover. |


Summary
Hovering sidebar headers moved things around (cmux-b2's flicker sweep, findings 2 to 4). Per the stability rule, hover now only shows or hides controls in slots that are always there:
isHidden.The workspace row's close and badge swap (finding 1) waits for #17520, which changes that row's trailing layout.
Testing
SidebarHoverStabilityTests(committed red in fbb66c0 before the fix): a truncated group header and machine header keep their name frame when hovered; a titled section's chevron is never hidden, at alpha 0 at rest and 1 on hover.check-no-godfilespasses locally. No new strings.Changelog
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes sidebar header hover instability so header names no longer shift or re-truncate when the pointer enters.
isHidden, avoiding remount flicker.SidebarHoverStabilityTestscovering name-frame stability and chevron fading.Written for commit 4acc822. Summary will update on new commits.