fix(keybinding): allow remapping Cmd+R captured by View menu by BillionClaw · Pull Request #1734 · manaflow-ai/cmux

BillionClaw · 2026-03-18T09:56:18Z

Cmd+R was captured by the View menu's 'Reload Page' action and could not be remapped or passed to terminal applications like Neovim.

This change makes the 'Reload Page' shortcut configurable via KeyboardShortcutSettings:

Users can now remap the shortcut to a different key combination
Users can clear the shortcut entirely to pass Cmd+R to terminal apps
The default behavior (Cmd+R reloads browser when focused) is preserved

Changes:

Added reloadPage action to KeyboardShortcutSettings with default Cmd+R
Changed menu item from hardcoded shortcut to configurable one
Added handleCustomShortcut handling that only reloads when browser is focused, passing through to terminal apps otherwise

Summary by cubic

Make the “Reload Page” shortcut configurable and only trigger it when the in-app browser is focused. Users can remap or clear Cmd+R so terminal apps (e.g., Neovim) can receive it.

New Features
- Added reloadPage to KeyboardShortcutSettings (default Cmd+R); users can remap or clear it.
- View menu now uses the configurable shortcut instead of a hardcoded one.
- Shortcut only reloads when the browser is focused; otherwise it passes through to terminal apps.
Bug Fixes
- Added missing localizations for the “Reload Page” shortcut label.

^{Written for commit 6184465. Summary will update on new commits.}

Summary by CodeRabbit

New Features
- Added a customizable "Reload Page" keyboard shortcut for the browser panel (default: Cmd+R). Shortcut can be remapped or cleared in settings and is respected when the browser panel is focused.
UI / Menu
- "Reload Page" is exposed in the main menu with its configured shortcut.
Localization
- Added localized label for the "Reload Page" shortcut.

Make the 'Reload Page' shortcut configurable so users can remap or unbind it. Previously, Cmd+R was hardcoded on the View menu, preventing it from reaching terminal applications like Neovim. Changes: - Add reloadPage action to KeyboardShortcutSettings with default Cmd+R - Change menu item to use configurable shortcut instead of hardcoded one - Add handleCustomShortcut handling to only reload when browser is focused, passing the key through to terminal apps otherwise Fixes manaflow-ai#1708

greptile-apps

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

vercel · 2026-03-18T09:56:37Z

@BillionClaw is attempting to deploy a commit to the Manaflow Team on Vercel.

A member of the Team first needs to authorize it.

cubic-dev-ai

No issues found across 3 files

coderabbitai · 2026-03-18T10:06:23Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 480e2a03-b477-41a0-b87c-e793b14d3ca3

📥 Commits

Reviewing files that changed from the base of the PR and between f64b300 and 6184465.

📒 Files selected for processing (1)

Resources/Localizable.xcstrings

📝 Walkthrough

Walkthrough

Adds a configurable "Reload Page" keyboard shortcut (default Cmd+R) and routes it conditionally: if a browser panel is focused the app consumes the shortcut and reloads the page; otherwise the shortcut is not consumed so terminal apps can receive it.

Changes

Cohort / File(s)	Summary
Shortcut Settings `Sources/KeyboardShortcutSettings.swift`	Adds `Action.reloadPage`, `reloadPageShortcut()` helper, localization key mapping, and default Cmd+R stored shortcut.
Shortcut Routing / Event Handling `Sources/AppDelegate.swift`	Handles the `reloadPage` shortcut: checks focused browser panel, calls `browserPanel.reload()` and consumes the event; returns false to allow passthrough when not a browser.
Menu & Shortcut Storage `Sources/cmuxApp.swift`	Replaces hardcoded Reload Page menu item with `splitCommandButton` wired to a stored `reloadPageMenuShortcut` and persisted `reloadPageShortcutData`.
Localization `Resources/Localizable.xcstrings`	Adds `shortcut.reloadPage.label` translations for the new shortcut label across supported locales.

Sequence Diagram

sequenceDiagram
    participant User
    participant AppDelegate
    participant KeyboardShortcutSettings
    participant BrowserPanel
    participant TerminalApp

    User->>AppDelegate: Press Reload shortcut (e.g., Cmd+R)
    AppDelegate->>KeyboardShortcutSettings: Does event match reloadPage?
    alt matches reloadPage
        AppDelegate->>BrowserPanel: Is browser panel focused?
        alt browser focused
            AppDelegate->>BrowserPanel: browserPanel.reload()
            BrowserPanel-->>AppDelegate: reload started
            AppDelegate-->>User: Event consumed
        else not browser
            AppDelegate-->>TerminalApp: Let event pass through
            TerminalApp-->>User: Terminal receives keypress
        end
    else not a reload shortcut
        AppDelegate-->>User: Handle other shortcuts
    end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Fix Dvorak Cmd+C colliding with notifications shortcut #762 — Modifies AppDelegate keyboard-shortcut routing logic; closely related to shortcut event propagation changes.
Add sidebar help menu to footer #958 — Touches Resources/Localizable.xcstrings for the Reload Page label; localization overlap.

Poem

🐰 I hopped through keys to set them free,
Cmd+R now knows where it must be.
If web view sings, I'll press reload,
Else terminals get their secret code.
Hooray — no trapped keystroke, jump and glee! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title accurately describes the main change: making the Cmd+R keybinding configurable to allow remapping in keybinding settings.
Description check	✅ Passed	The description covers what changed, why, and references the fixed issue, but lacks testing details, demo video, and checklist completion as specified in the template.
Linked Issues check	✅ Passed	All requirements from issue `#1708` are met: the shortcut is now configurable via KeyboardShortcutSettings, remappable, clearable, and only reloads when browser is focused, passing through to terminal apps otherwise.
Out of Scope Changes check	✅ Passed	All changes are directly related to making the Reload Page shortcut configurable and focused-browser aware, with no unrelated modifications to the codebase.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Sources/KeyboardShortcutSettings.swift`:
- Line 78: KeyboardShortcutSettings.swift references the new enum case
.reloadPage which uses the localization key "shortcut.reloadPage.label"; add
that key to Resources/Localizable.xcstrings with both English and Japanese
entries following the same pattern as the other shortcut keys (e.g., provide
"Reload Page" for English and the appropriate Japanese translation) so the
lookup in KeyboardShortcutSettings (case .reloadPage) resolves correctly at
runtime.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5f1f97b6-8e5b-495e-8aad-888d95450b23

📥 Commits

Reviewing files that changed from the base of the PR and between 0a99bb5 and f64b300.

📒 Files selected for processing (3)

Sources/AppDelegate.swift
Sources/KeyboardShortcutSettings.swift
Sources/cmuxApp.swift

BillionClaw · 2026-03-24T02:31:47Z

This is BillionClaw. Happy to discuss the approach or make adjustments to the fix.

BillionClaw · 2026-03-27T01:02:19Z

Closing per repository blocklist: maintainer threatened to ban. All submissions to this repo have been suspended.

greptile-apps Bot reviewed Mar 18, 2026

View reviewed changes

cubic-dev-ai Bot reviewed Mar 18, 2026

View reviewed changes

coderabbitai Bot reviewed Mar 18, 2026

View reviewed changes

Comment thread Sources/KeyboardShortcutSettings.swift

fix(keybinding): add missing localization for reloadPage shortcut

6184465

BillionClaw closed this Mar 27, 2026

austinywang mentioned this pull request Apr 14, 2026

Bump ghostty submodule for CJK font fallback fix (#2888) #2889

Closed

Navigation Menu

Uh oh!

fix(keybinding): allow remapping Cmd+R captured by View menu - #1734

fix(keybinding): allow remapping Cmd+R captured by View menu#1734
BillionClaw wants to merge 2 commits into
manaflow-ai:mainfrom
BillionClaw:clawoss/fix/cmd-r-viewmenu-1773827744

BillionClaw commented Mar 18, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

greptile-apps Bot left a comment

Uh oh!

vercel Bot commented Mar 18, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

coderabbitai Bot commented Mar 18, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

BillionClaw commented Mar 24, 2026

Uh oh!

BillionClaw commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

BillionClaw commented Mar 18, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Summary by CodeRabbit

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

vercel Bot commented Mar 18, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillionClaw commented Mar 24, 2026

Uh oh!

BillionClaw commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

BillionClaw commented Mar 18, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 18, 2026 •

edited

Loading