Fix missing Terminals tab while Cloud machine connects

[austinywang]

Changelog

Fixed: keep the Terminals tab visible while a new Cloud machine is connecting.

Problem

A connecting machine with no terminal snapshot omitted its Terminals group, leaving the sidebar with Ports, Displays, and Resources only.

Change

The tree builder now includes the Terminals group during .connecting, so the tab remains available and shows No terminals yet until the machine reports its terminals.

Validation

• Regression test commit: c060419efb5 (test: keep cloud terminals tab visible while connecting)
• Fix commit: 8909eeb9c6f (fix: show cloud terminals tab while connecting)
• git diff --check passed.
• Local app-host test execution is prohibited by the repository policy; compile admission/build will run through the fleet.

Callsign registration timed out, so this PR is signed unregistered.

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

---

Summary by cubic

Fixes the Cloud sidebar so the Terminals tab stays visible while a machine is connecting, instead of disappearing until the machine reports its first terminal snapshot.

• The tree builder now includes the Terminals group during the .connecting state, showing "No terminals yet" as a placeholder.
• Adds a regression test covering the connecting state.

^{Written for commit 8909eeb. Summary will update on new commits.}

Summary by CodeRabbit

• Bug Fixes
  • Cloud machines now show their Terminals group while connecting, including a “No terminals yet” placeholder when no terminals are available.

[cursor]

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used

📚 Code guidelines (3)

.github/review-bot-rules/test-determinism.md — configured
.github/review-bot-rules/swift-architectural-rethink.md — configured
.github/review-bot-rules/source-control-artifacts.md — configured

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: dab4ad91-5630-43a5-ba6a-6ce5f71a2ab8

📥 Commits

Reviewing files that changed from the base of the PR and between 9aefea4 and 8909eeb.

📒 Files selected for processing (2)

• Sources/Cloud/CloudTreeNode.swift
• cmuxTests/CloudSidebarSurfaceRegressionTests.swift

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

---

📝 Walkthrough

Walkthrough

Connecting cloud machines with available machine info now show a Terminals group. A regression test checks that a non-desktop machine’s group contains one “No terminals yet” placeholder.

Changes

Cloud terminals visibility

Layer / File(s)	Summary
Show terminals while connecting Sources/Cloud/CloudTreeNode.swift, cmuxTests/CloudSidebarSurfaceRegressionTests.swift	The cloud tree includes the Terminals group while a machine is connecting. The regression test verifies that the group contains exactly one “No terminals yet” placeholder.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: teamleaderleo

Merge Risk: ⚪ Minimal · up to 8909e

Connecting cloud machines can show the Terminals tab before terminals arrive, with a regression test for the empty state. No actionable merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 24 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (24 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: keeping the Terminals tab visible while a Cloud machine connects.
Description check	✅ Passed	The description explains the problem, change, regression test, and validation status. It omits the template’s demo video section and checklist, and reports that app-host tests have not run locally.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input	✅ Passed	The diff changes only when CloudTreeNodeBuilder adds the Terminals group and adds a regression test for its empty placeholder. terminalsGroupNode builds presentation nodes and the “No terminals ye…
Cmux Swift Actor Isolation	✅ Passed	The production diff only adds .connecting to the condition that appends the Terminals group in CloudTreeNodeBuilder.cloudChildren (line 891). It adds no model, service protocol, shared mutable typ…
Cmux Swift Blocking Runtime	✅ Passed	The production Swift diff only adds .connecting to the condition that includes the Terminals group. It adds no blocking or timing-based synchronization. The test diff adds deterministic assertions a…
Cmux Browser Automation Off-Main	✅ Passed	The diff changes only Sources/Cloud/CloudTreeNode.swift and cmuxTests/CloudSidebarSurfaceRegressionTests.swift. The browser automation rule applies to Sources/TerminalController.swift and `Contr…
Cmux Expensive Synchronous Load	✅ Passed	The production diff only adds .connecting to the condition that appends the Terminals group. cloudChildren filters the already supplied resources before that condition, and terminalsGroupNode on…
Cmux Cache Substitution Correctness	✅ Passed	The production diff only adds .connecting to the condition that displays the Terminals UI group. The group still uses the existing resources collection, which cloudChildren filters for terminals…
Cmux No Hacky Sleeps	✅ Passed	The custom check applies to production changes in TypeScript, JavaScript, shell, and build/runtime scripts. The diff changes Swift files only: a condition in Sources/Cloud/CloudTreeNode.swift and a …
Cmux Algorithmic Complexity	✅ Passed	The change adds .connecting to the Terminals-group condition. For connecting machines with terminals, the group already appeared through !terminals.isEmpty; the new path only builds a group for an…
Cmux Swift Concurrency	✅ Passed	The diff adds only a .connecting condition to the Terminals-group visibility check and a synchronous regression test. It adds no Dispatch queue, Combine state, completion-handler API, or fire-and-fo…
Cmux Swift @Concurrent	✅ Passed	The diff changes a synchronous condition in CloudTreeNodeBuilder.cloudChildren and adds a synchronous regression test. Neither changed function is async or uses @concurrent; the patch adds no as…
Cmux Swift Package Boundaries	✅ Passed	The production diff changes one condition in CloudTreeNodeBuilder so the sidebar includes its Terminals UI group while a machine connects. The group builder assembles outline rows and an empty-state…
Cmux Swiftpm Lockfiles	✅ Passed	The diff changes only Sources/Cloud/CloudTreeNode.swift and cmuxTests/CloudSidebarSurfaceRegressionTests.swift. It changes cloud tree behavior and adds a regression test. It does not change a Swif…
Cmux Swift Logging	✅ Passed	The diff adds only a .connecting condition to the Terminals-group check in Sources/Cloud/CloudTreeNode.swift and adds a regression test in cmuxTests/CloudSidebarSurfaceRegressionTests.swift. It …
Cmux User-Facing Error Privacy	✅ Passed	The production diff only adds .connecting to the condition that creates the terminals pool. The app presents that pool through CloudTreeMachineDetailLayout as a Terminals tab in the sidebar. Its e…
Cmux Full Internationalization	✅ Passed	The production diff only adds .connecting to the condition that displays the Terminals group. The existing No terminals yet placeholder uses String(localized:defaultValue:), and its `Resources/L…
Cmux Swiftui State Layout	✅ Passed	The diff does not introduce a SwiftUI state or layout pattern covered by the check. It changes a condition in CloudTreeNodeBuilder.cloudChildren to include the terminals group while connecting (Sour…
Cmux Architecture Rethink	✅ Passed	The diff makes a local visibility correction in CloudTreeNodeBuilder.cloudChildren: it adds .connecting to the existing condition that decides whether to add the Terminals group. The group remains…
Cmux Swift Auxiliary Window Close Shortcuts	✅ Passed	The PR changes only the cloud tree builder’s Terminals-group condition and adds a regression test. It does not add or materially change an NSWindow, NSPanel, NSWindowController, SwiftUI Window, or Win…
Cmux Source Artifacts	✅ Passed	The diff changes only Sources/Cloud/CloudTreeNode.swift and cmuxTests/CloudSidebarSurfaceRegressionTests.swift. These are intentional product source and test code, which the source-control-artifac…
Cmux No Test Or Debug Seam In Production Source	✅ Passed	PASS. The only production-source change is in Sources/Cloud/CloudTreeNode.swift: it adds .connecting to the condition that includes the Terminals group. It adds no test/debug accessor, guarded ext…

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Merge receipt for 8909eeb9c6: every check was green at merge (16 verified; 20 skipped by policy). Full suite runs on main after merge.

[github-actions]

Dogfood tours of 8909eeb9

cloud-machine-author-tour at 8909eeb9, on its merge ded5b328 that CI built: failure (run)

Failed: DogfoodScenarioUITests.swift:115: failed - Dogfood steps failed:

Key frames of cloud-machine-author-tour at 8909eeb

_{Tours are picked by the paths globs in dogfood/scenarios/*.json; a Dogfood-tours: a, b line in the description picks them instead (none turns this off). Look at every frame before merging: a green tour only means no step failed.}