Skip to content

ci(cmux-next): run every web bundle check on pull requests into feat-cmux-next - #17278

Closed
lawrencecchen wants to merge 3 commits into
feat-cmux-nextfrom
feat-cmux-next-web-bundle-pr-ci
Closed

lawrencecchen wants to merge 3 commits into
feat-cmux-nextfrom
feat-cmux-next-web-bundle-pr-ci

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

#17241 merged into feat-cmux-next with stale Settings page strings and broke the base: cmux-next-web-bundles.yml ran only on pushes, and checked neither the page strings nor the React pages bundle that safe-push.sh checks.

  • scripts/cmux-next/check-web-bundles.sh: runs node scripts/pages/gen-strings.mjs --check (in webviews/), build-pages-web.sh --check, build-webviews-app.sh --check, build-agent-pane-web.sh --check and build-agent-activity-web.sh --check; every check runs, and it fails naming each stale one with the regenerate commands.
  • .github/workflows/cmux-next-web-bundles.yml: also on pull_request into feat-cmux-next, with the same path list as push (adds schemas/settings, the pages bundle and its script); the bundles job runs the wrapper.
  • tests/test_cmux_next_web_bundle_checks.py (red first): fake checks prove all five run, gen-strings runs in webviews/, a stale page-strings fixture fails and names it while the later checks still run; and the workflow wiring. Registered in test-execution.toml and run by ci-guards.

Local: the new test, path-filter parity, the registry and test_ci_change_areas pass; a real run of the wrapper on the base is green in 20 s. Not merging (coordinator).

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Prevents stale generated web output from merging into feat-cmux-next by running the full set of bundle checks on pull requests, not just pushes. Previously the cmux-next-web-bundles workflow ran only on pushes and skipped the page strings, React pages bundle, and coordination index checks, which let #17241 merge stale Settings strings.

  • Adds scripts/cmux-next/check-web-bundles.sh that runs all six checks (coordination index, page strings, pages bundle, webviews app, agent pane, Agent Activity); every check runs even when one fails, and it names stale output with the regenerate commands.
  • Runs the wrapper on pull requests into feat-cmux-next, with the same path list as pushes, now including schemas/settings, the pages bundle, and the coordination index.
  • Adds tests/test_cmux_next_web_bundle_checks.py, registered in test-execution.toml and run by ci-guards.yml, proving all checks run, that gen-strings runs in webviews/, and that a stale fixture fails while later checks still run.

Written for commit 17d0a37. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7042e59f-def8-4a8a-9223-58c83ec61cb6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

lawrencecchen and others added 3 commits October 4, 2026 06:26
…le check

Red: cmux-next-web-bundles.yml runs only on pushes and checks neither the page
strings nor the pages bundle (#17241 merged stale Settings strings).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… check

#17241 merged into feat-cmux-next with stale Settings strings: the bundle
workflow ran only on pushes and checked neither the page strings nor the
React pages bundle. scripts/cmux-next/check-web-bundles.sh runs the same five
checks as safe-push.sh (gen-strings.mjs, build-pages-web.sh,
build-webviews-app.sh, build-agent-pane-web.sh, build-agent-activity-web.sh),
reports every stale one, and cmux-next-web-bundles.yml runs it on pull
requests into feat-cmux-next as well as on pushes.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
generate-coordination-index.py --check joins the PR checks (as in safe-push.sh):
the land-17066 merge brought back the pre-split COORDINATION.md and broke the
index check on the base.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@lawrencecchen
lawrencecchen force-pushed the feat-cmux-next-web-bundle-pr-ci branch from 1c7b3a3 to 17d0a37 Compare October 4, 2026 13:27
@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Closed by the unlanded-work audit: superseded. PRs into feat-cmux-next are retired (direct-landing rule, 2026-10-03), and the bundle checks run in cmux-next-web-bundles.yml (9f9587e) and safe-push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant