Revert "fix: repair NIGHTLY Sparkle quarantine metadata (#1703)"

[austinywang]

Why

The known-good nightly builds from March 17, 2026 at 5:17 PM PDT (a42e6663) and 5:52 PM PDT (1fabe9f3) already contained e1582582 (fix: restore Sparkle automatic update checks).

The only Sparkle-facing change between those known-good nightlies and the first broken nightly on March 18, 2026 at 1:23 AM PDT (629b63df) is #1703.

This PR reverts only #1703 instead of broadly reverting all March 17 updater changes.

Verification

• ./scripts/reload.sh --tag revert-sparkle-0317
• xcodebuild -project GhosttyTabs.xcodeproj -scheme cmux-unit -configuration Debug -destination 'platform=macOS' -derivedDataPath /tmp/cmux-revert-sparkle-0317-tests build-for-testing\n\n## Scope\n- Removes the quarantine-repair hooks added in UpdateDelegate and UpdateDriver\n- Removes UpdateQuarantineRepair.swift\n- Removes the regression tests added with #1703\n- Keeps e1582582 in place because known-good nightlies already included it

---

Summary by cubic

Reverts the quarantine metadata repair in the nightly Sparkle updater to restore the known-good behavior from Mar 17 and isolate the Mar 18 regression.

• Bug Fixes
  • Removed quarantine-repair hooks and logging from UpdateDelegate and UpdateDriver.
  • Deleted quarantine repair code and tests (UpdateQuarantineRepair.swift, UpdateQuarantineRepairTests.swift) and cleaned Xcode project references.
  • Kept automatic update checks intact; no other updater behavior changes.

^{Written for commit 1d0477f. Summary will update on new commits.}

Summary by CodeRabbit

• Refactor
  • Removed the quarantine-repair workflow from the app update process and related delegate handling.
• Tests
  • Removed test coverage for the quarantine-repair workflow and related discovery utilities.
• Chores
  • Cleaned up project build/test references related to the removed quarantine-repair components.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
cmux	Ready	Preview, Comment	Mar 18, 2026 8:57am

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e44ed9ff-ce6f-4742-90da-45e0db25ab27

📥 Commits

Reviewing files that changed from the base of the PR and between a41f9f6 and 1d0477f.

📒 Files selected for processing (1)

• GhosttyTabs.xcodeproj/project.pbxproj

---

📝 Walkthrough

Walkthrough

This PR removes the quarantine-repair feature from the update flow: it deletes the UpdateQuarantineRepair implementation and tests, removes related build/project references, and strips quarantine-repair calls and state from UpdateDelegate and UpdateDriver.

Changes

Cohort / File(s)	Summary
Project config GhosttyTabs.xcodeproj/project.pbxproj	Removed build-phase and file references for UpdateQuarantineRepair.swift and UpdateQuarantineRepairTests.swift.
Update integration Sources/Update/UpdateDelegate.swift, Sources/Update/UpdateDriver.swift	Removed delegate call and driver state/methods that invoked or tracked quarantine repair during extraction; eliminated related logging and helper calls.
Quarantine repair impl Sources/Update/UpdateQuarantineRepair.swift	Deleted entire file — all quarantine repair types, discovery, attribute inspection/mutation, and repair workflows removed.
Tests cmuxTests/UpdateQuarantineRepairTests.swift	Deleted entire test file that exercised quarantine repair, discovery, and xattr utilities.

Sequence Diagram(s)

mermaid
sequenceDiagram
rect rgba(200,200,255,0.5)
Updater->>UpdateDriver: begin extraction (old flow included repair)
end
rect rgba(200,255,200,0.5)
UpdateDriver->>UpdateQuarantineRepair: locate & repair archive/app (old)
UpdateQuarantineRepair-->>UpdateDriver: repair result
UpdateDriver-->>Updater: extraction complete
note right of UpdateQuarantineRepair: In new flow UpdateQuarantineRepair is removed\nand no repair step occurs

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Revert "fix: repair NIGHTLY Sparkle quarantine metadata (#1703)" #1725: Touches the same quarantine-repair code paths and project references; likely overlapping edits.
• fix: repair NIGHTLY Sparkle quarantine metadata #1703: Introduced the UpdateQuarantineRepair implementation, its tests, and integration points — directly related and potentially reverted by this change.

Poem

🐰 I hopped through caches, sniffed each file,

patched no more — I rest awhile.
My paws tapped code that once would mend,
Now lighter paths the update wend.
Hooray, a simpler burrowed end. 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically identifies the change as a revert of PR #1703 that addressed Sparkle quarantine metadata, matching the file removals and scope changes documented in the changeset.
Description check	✅ Passed	The description includes a clear 'Why' section explaining the regression context and reasoning, and a 'Verification' section with steps to test the revert, though the 'Testing' and 'Demo Video' sections from the template are not explicitly present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch revert/sparkle-since-2026-03-17

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 5 files