cmux-next: add sidebar workspace groups and tab rows by teamleaderleo · Pull Request #17186 · manaflow-ai/cmux

teamleaderleo · 2026-10-03T19:33:31Z

What changed

cmux-next now renders workspace groups in the sidebar with a compact colored header dot and text, plus one thin colored vertical rail tying their member rows together. Group members keep their normal kind icon inset with no additional group indent. The same rail treatment applies to grouped Projects and their sessions. Group headers are small-radius rows rather than capsule pills.

The opt-in sidebar.showWorkspaceTabs setting renders each workspace's tabs beneath it with the existing row-kind inset and tab rail treatment. Workspace-group actions cover create, selection grouping, collapse, rename, color, reorder, membership, and next/previous navigation.

Validation

Exact pushed HEAD 235686e573a142eca2529d5319d0f93645412582 compiled successfully on the fleet in job f60463d8038af7ae466bca68 with tag pr-17186-sidebar-groups-v18; terminal receipt: artifacts/fleet/235686e573a142eca2529d5319d0f93645412582-terminal.json; artifact digest: sha256:e35363a7c7e38905de6cf53f50f4a9d7f04759fbe97f9b7ebfe1211cb4bb3d94.
The exact artifact was pulled directly from fleet CAS on the leased capture mini. No app or zip crossed through Big Red.
The capture bundle is artifacts/capture/dbe28cb6cbee7f9e4f8e25b83d2f0a7bb756d3b1/. groups.png visibly shows a blue Product group dot and thin vertical rails joining workspace-2 and workspace-3; groups-state.json provides picker-host evidence for the same sidebar UI; the final exact-head fleet compile is listed separately. The final host could not finalize recording.mp4 (reported to the coordinator), while the earlier bounded capture at artifacts/capture/9db0eeb1db760b7e29fe4c53df0aa9df858ea1d1/recording/recording.mp4 completed successfully. All UI actions were foreground CUA-driver actions in bounded runs.
swiftc -frontend -parse passed for every changed Swift file.
bun build web/data/cmux-shortcuts.ts --target node passed.
JSON parsing passed for the settings schema, action export, and web schema.
git diff --check passed.
python3 scripts/check-workspace-package-groups.py passed.
Localization entries for all required macOS locales were audited. The repository-wide localization checker still reports pre-existing catalog parity errors outside this change; the current base evidence is documented in the PR comments.
Swift package tests are covered by hosted CI and the exact-head fleet compile; Big Red is not a native Swift builder.

🤖 Generated with Claude Code

coderabbitai · 2026-10-03T19:33:38Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 5b4f63c8-f0fb-495c-b508-ad7855b71cda

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-03T19:36:25Z

CI failure attribution

CI passes on 235686e573 (run 37162822391 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's.

cursor · 2026-10-03T20:24:20Z

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

cursor · 2026-10-03T20:32:22Z

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

cursor · 2026-10-03T23:00:20Z

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

cursor · 2026-10-03T23:02:58Z

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

teamleaderleo · 2026-10-03T23:33:27Z

Base audit after rebasing onto current feat-cmux-next 5ca2a60e2fb43c51624f70d3afa772396af2bf54:

The base cmux-next run 37160782148 reports the pre-existing SettingsSchema god-type red: 1049 lines against the 1000-line limit, and the pre-existing localization catalog red: 408 errors across 84 tables and 21 languages. These are unchanged by this PR.
The same base run's Swift test job reports unrelated baseline failures in VariantRegistryTests, SidebarRailViewTests, SettingsSchemaExportTests, ManagedPreferencesManifestTests, and SettingsGroupIdentityTests; the sidebar group changes do not touch those baseline failures.

The branch adds no lint:allow markers and carries no VmPrivateNetworkUnavailableError import or other base-fix changes.

teamleaderleo · 2026-10-03T23:55:34Z

Current-base recheck: feat-cmux-next is now b7ef80daa6942aabd445e29c1767b5ef58e02a35. Its cmux-next run still reports the same inherited reds: SettingsSchema at 1049 lines against the 1000-line limit and 408 localization errors across 84 tables and 21 languages. Its Swift test job also retains the unrelated baseline failures in SettingsSchemaExportTests, ManagedPreferencesManifestTests, SettingsGroupIdentityTests, SidebarRailViewTests, VariantRegistryTests, and BackdropArtTests.

The rebased branch remains limited to group lines, tab rows, and the sidebar split. It adds no lint allowances, VmPrivateNetworkUnavailableError import, or other base-fix changes.

…bers JSONSerialization prints doubles as 0.1 on Xcode 26 and 0.10000000000000001 on Xcode 27, so schemas/settings/settings-schema.json and docs/mdm/com.manaflow.cmux.json were stale on one toolchain or the other. DeterministicJSON formats every number with Swift's shortest round-trip description and keeps the JSONSerialization layout and key order, so the files change only where a number was long. Regenerated both files plus docs/mdm plist and md, which were also stale on the base (sidebar.showWorkspaceTabs from #17186 was never exported).

… row title (was a fixed inset #17186 moved) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

…17186 moved them 2 pt right) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

… row title (was a fixed inset #17186 moved) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

…17186 moved them 2 pt right) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

sidebar.showWorkspaceTabs (#17186) already lists tabs inline, so the disclosure collapses them per workspace instead of a second sidebar.nestedTabs key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

#17186 already ships sidebar.showWorkspaceTabs, so drop the second sidebar.nestedTabs key. With tabs listed, each workspace row's chevron hides or lists its own tabs; sidebar.showCounts stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

sidebar.showWorkspaceTabs (#17186) already lists tabs inline, so the disclosure collapses them per workspace instead of a second sidebar.nestedTabs key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…#17520) * test(cmux-next): put the workspace tab disclosure on showWorkspaceTabs sidebar.showWorkspaceTabs (#17186) already lists tabs inline, so the disclosure collapses them per workspace instead of a second sidebar.nestedTabs key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(cmux-next sidebar): opt-in tab counts and a per-workspace tabs chevron With sidebar.showWorkspaceTabs on, each workspace row gets a chevron that collapses or expands its tabs. sidebar.showCounts (default off) shows a workspace's tab count in a fixed trailing slot. Settings artifacts are carried over from the previous base and regenerated next. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(cmux-next): regenerate settings artifacts for sidebar.showCounts Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(cmux-next sidebar): keep SidebarListView under the god-type limit The list's model-derived layout options come from SidebarModel.listOptions(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(cmux-next): regenerate settings schema, MDM docs and Settings bundle on the new base Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * next-batch: regenerate webviews formatting * cmux-next sidebar: regenerate settings artifacts on the new base Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * cmux-next sidebar: rebuild settings page on the new base Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: cmux-next batch queue <41898282+github-actions[bot]@users.noreply.github.com>

teamleaderleo force-pushed the feat-cmux-next-sidebar-groups branch 6 times, most recently from 058f9c5 to 95a5cac Compare October 3, 2026 22:44

teamleaderleo force-pushed the feat-cmux-next-sidebar-groups branch from ff26774 to 70b4c50 Compare October 3, 2026 23:02

teamleaderleo force-pushed the feat-cmux-next-sidebar-groups branch from 70b4c50 to 9db0eeb Compare October 3, 2026 23:12

teamleaderleo force-pushed the feat-cmux-next-sidebar-groups branch from 9db0eeb to dbe28cb Compare October 3, 2026 23:34

teamleaderleo added 9 commits October 3, 2026 16:46

cmux-next: add sidebar workspace groups and tab rows

6097ab6

fix(cmux-next): unwrap grouped rail color

f790de8

fix(cmux-next): simplify group navigation lookup

74139e1

refactor: split sidebar tab models

f0e7804

fix(cmux-next): avoid workspace group shortcut collisions

8fc477a

cmux-next: align group rails with tab groups

a292e17

cmux-next: keep sidebar grouping within check budgets

91c137d

cmux-next: keep schema budget unchanged

d588930

cmux-next: fix sidebar setting descriptor text type

235686e

teamleaderleo force-pushed the feat-cmux-next-sidebar-groups branch from dbe28cb to 235686e Compare October 3, 2026 23:46

teamleaderleo merged commit 36a16ec into feat-cmux-next Oct 3, 2026
59 of 61 checks passed

teamleaderleo deleted the feat-cmux-next-sidebar-groups branch October 3, 2026 23:57

teamleaderleo mentioned this pull request Oct 4, 2026

test(cmux-next): align sidebar assertions with grouped rail #17229

Closed

lawrencecchen added a commit that referenced this pull request Oct 4, 2026

test(cmux-next): group header title alignment checks a real workspace…

6c8fd12

… row title (was a fixed inset #17186 moved) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

lawrencecchen added a commit that referenced this pull request Oct 4, 2026

fix(cmux-next): group header names align with workspace titles again (#…

d3eb598

…17186 moved them 2 pt right) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

lawrencecchen added a commit that referenced this pull request Oct 4, 2026

test(cmux-next): group header title alignment checks a real workspace…

57d5fa1

… row title (was a fixed inset #17186 moved) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

lawrencecchen added a commit that referenced this pull request Oct 4, 2026

fix(cmux-next): group header names align with workspace titles again (#…

cfe13f1

…17186 moved them 2 pt right) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

teamleaderleo mentioned this pull request Oct 6, 2026

cmux-next sidebar: opt-in tab counts and a per-workspace tabs chevron #17520

Merged

Navigation Menu

Repository navigation

cmux-next: add sidebar workspace groups and tab rows - #17186

cmux-next: add sidebar workspace groups and tab rows#17186
teamleaderleo merged 9 commits into
feat-cmux-nextfrom
feat-cmux-next-sidebar-groups

teamleaderleo commented Oct 3, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 3, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions Bot commented Oct 3, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Oct 3, 2026

Uh oh!

cursor Bot commented Oct 3, 2026

Uh oh!

cursor Bot commented Oct 3, 2026

Uh oh!

cursor Bot commented Oct 3, 2026

Uh oh!

teamleaderleo commented Oct 3, 2026

Uh oh!

teamleaderleo commented Oct 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

teamleaderleo commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Validation

Uh oh!

coderabbitai Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI failure attribution

Uh oh!

cursor Bot commented Oct 3, 2026

Bugbot is paused — on-demand spend limit reached

Uh oh!

cursor Bot commented Oct 3, 2026

Bugbot is paused — on-demand spend limit reached

Uh oh!

cursor Bot commented Oct 3, 2026

Bugbot is paused — on-demand spend limit reached

Uh oh!

cursor Bot commented Oct 3, 2026

Bugbot is paused — on-demand spend limit reached

Uh oh!

teamleaderleo commented Oct 3, 2026

Uh oh!

teamleaderleo commented Oct 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Oct 3, 2026 •

edited

Loading

coderabbitai Bot commented Oct 3, 2026 •

edited

Loading

github-actions Bot commented Oct 3, 2026 •

edited

Loading