Repository navigation
fix(l10n): translate New Machine plan loading strings - #17150
austinywang wants to merge 1 commit into
Conversation
#17135 added machines.new.plan.loading/.error/.retry with English copied into every locale, which fails the localization parity check on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (2)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThree Cloud-plan messages now have translations in 19 locales. The changes cover the loading message, retry label, and message asking users to retry shortly while plan details load. ChangesCloud plan localization
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The Cloud plan messages are translated in existing locale entries, with no identified issue that needs to be resolved before merging. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 25✅ Passed checks (25 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CI failure attributionCI failed on
Matched log linesNot re-run automatically: Written by |
mainfails Fast static checks (24 localization parity errors) since #17135 addedmachines.new.plan.loading,.errorand.retrywith the English text copied into every locale. This translates the three strings in all 19 non-English locales, keeping "Cloud" as the product name like the catalog's other Cloud machine strings, and reusingcommon.retry's wording for Retry (plus a Khmer form, whichcommon.retrylacks). The diff touches only those 57 value lines.Verification:
python3 scripts/verify-local.pypasses (xcstrings, localization, localization-defaults, feature-flags); before this change--only localizationreported the 24 parity errors.Changelog
Fixed: The New Machine sheet's plan loading and retry text is translated in every supported language.
— unregistered
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Translates the New Machine sheet's plan loading, error, and retry strings in all 19 non-English locales. These strings were added in #17135 with English text copied into every locale, which fails the localization parity check on main.
The diff touches only 57 value lines in
Resources/Localizable.xcstrings. "Cloud" stays as the product name to match the catalog's other Cloud machine strings, and the Retry wording reusescommon.retry's translations (with a dedicated Khmer entry).python3 scripts/verify-local.pypasses after this change.Written for commit 959543d. Summary will update on new commits.
Summary by CodeRabbit