Skip to content

fix(l10n): translate New Machine plan loading strings - #17150

Open
austinywang wants to merge 1 commit into
mainfrom
fix-new-machine-plan-localization
Open

austinywang wants to merge 1 commit into
mainfrom
fix-new-machine-plan-localization

Conversation

@austinywang

@austinywang austinywang commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

main fails Fast static checks (24 localization parity errors) since #17135 added machines.new.plan.loading, .error and .retry with the English text copied into every locale. This translates the three strings in all 19 non-English locales, keeping "Cloud" as the product name like the catalog's other Cloud machine strings, and reusing common.retry's wording for Retry (plus a Khmer form, which common.retry lacks). The diff touches only those 57 value lines.

Verification: python3 scripts/verify-local.py passes (xcstrings, localization, localization-defaults, feature-flags); before this change --only localization reported the 24 parity errors.

Changelog

Fixed: The New Machine sheet's plan loading and retry text is translated in every supported language.

— unregistered

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Translates the New Machine sheet's plan loading, error, and retry strings in all 19 non-English locales. These strings were added in #17135 with English text copied into every locale, which fails the localization parity check on main.

The diff touches only 57 value lines in Resources/Localizable.xcstrings. "Cloud" stays as the product name to match the catalog's other Cloud machine strings, and the Retry wording reuses common.retry's translations (with a dedicated Khmer entry). python3 scripts/verify-local.py passes after this change.

Written for commit 959543d. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Localization
    • Added translations for Cloud plan loading, retry, and “try again shortly” messages in 19 languages.

#17135 added machines.new.plan.loading/.error/.retry with English copied
into every locale, which fails the localization parity check on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (2)
.github/review-bot-rules/full-internationalization.md — configured
.github/review-bot-rules/source-control-artifacts.md — configured

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 13b25ca8-35d7-481c-b770-eb810ea935d5
📥 Commits

Reviewing files that changed from the base of the PR and between 1a7d5cd and 959543d.

📒 Files selected for processing (1)
  • Resources/Localizable.xcstrings

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

Three Cloud-plan messages now have translations in 19 locales. The changes cover the loading message, retry label, and message asking users to retry shortly while plan details load.

Changes

Cloud plan localization

Layer / File(s) Summary
Translate Cloud plan messages
Resources/Localizable.xcstrings
The loading message, retry label, and plan-details loading message now have translated values in 19 locales.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: lawrencecchen

Merge Risk: ⚪ Minimal · up to 95954

The Cloud plan messages are translated in existing locale entries, with no identified issue that needs to be resolved before merging.

Architecture Summary

Architecture risk: 🔵 Low · up to 95954

The change affects 1 system.

Changed systems: Resources

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — Resources (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in Resources/Localizable.xcstrings: Replaced the English loading message in 19 locale entries with translations stating that the Cloud machine plan is loading.
  • observed — Modified behavior in Resources/Localizable.xcstrings: Replaced the English retry label in 19 locale entries with translated retry labels.
  • observed — Modified behavior in Resources/Localizable.xcstrings: Replaced the English message that Cloud plan details are still loading and asks the user to retry shortly with translations in 19 locale entries.
🚥 Pre-merge checks | ✅ 25
✅ Passed checks (25 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the localization change to the New Machine plan loading strings.
Description check ✅ Passed The description explains the localization issue and resulting change, reports verification, and includes a user-facing changelog entry. It omits the template’s checklist; the demo requirement appears …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input ✅ Passed The PR changes only Resources/Localizable.xcstrings. The diff updates localized string values; it does not change Cloud terminal creation, transport, renderer admission, input ownership, or auth and…
Cmux Swift Actor Isolation ✅ Passed The reviewed diff changes only 57 string values in Resources/Localizable.xcstrings. It contains no Swift source changes, so it does not introduce or worsen a Swift actor-isolation issue.
Cmux Swift Blocking Runtime ✅ Passed The reviewed diff changes only values in Resources/Localizable.xcstrings. It changes no Swift files and introduces no synchronization or timing behavior covered by this check.
Cmux Browser Automation Off-Main ✅ Passed The check applies to browser socket automation changes. The pull request changes only Resources/Localizable.xcstrings, replacing English values with translations for three localization strings. It c…
Cmux Expensive Synchronous Load ✅ Passed The pull request changes only Resources/Localizable.xcstrings. The diff contains translated string values and no Swift source changes or agent-history loading call sites. It does not add or move an …
Cmux Cache Substitution Correctness ✅ Passed The pull request changes only Resources/Localizable.xcstrings. Its 57 additions and 57 deletions replace English localization values with translated text. It changes no production Swift, TypeScript,…
Cmux No Hacky Sleeps ✅ Passed The reviewed diff changes only Resources/Localizable.xcstrings. Its patch updates translated string values and adds no TypeScript, JavaScript, shell, or runtime-script changes, timers, delays, or po…
Cmux Algorithmic Complexity ✅ Passed PASS. The reviewed diff changes only Resources/Localizable.xcstrings and replaces localized string values for three machine-plan messages. It adds no production Swift, TypeScript, JavaScript, shell,…
Cmux Swift Concurrency ✅ Passed The reviewed diff changes only Resources/Localizable.xcstrings. It contains no Swift file changes, so it does not introduce or expand any of the legacy Swift concurrency patterns covered by this check…
Cmux Swift @Concurrent ✅ Passed The pull request changes only Resources/Localizable.xcstrings. The diff contains localized string values and no Swift code, so the Swift @concurrent check does not apply.
Cmux Swift Package Boundaries ✅ Passed The reviewed diff changes only Resources/Localizable.xcstrings. No Swift files changed, so the Swift package-boundary check does not apply.
Cmux Swiftpm Lockfiles ✅ Passed The reviewed diff changes only Resources/Localizable.xcstrings. It does not change a SwiftPM package, Xcode project, .gitignore, workflow, or dependency. The SwiftPM lockfile check does not apply.
Cmux Swift Logging ✅ Passed The diff changes only localized values in Resources/Localizable.xcstrings. It adds or materially changes no Swift code, logging statement, or diagnostic output.
Cmux User-Facing Error Privacy ✅ Passed The changed strings appear in the New Machine sheet UI: NewMachineSheet.swift displays the loading and retry strings, and NewMachineSheetPresenter.swift sets the plan-load error. The translations …
Cmux Full Internationalization ✅ Passed The PR changes only Resources/Localizable.xcstrings. It updates translations for machines.new.plan.loading, .retry, and .error. Each key has entries for all 20 catalog locales: English and all…
Cmux Swiftui State Layout ✅ Passed The diff changes only Resources/Localizable.xcstrings, with 57 localization value updates. It introduces no SwiftUI views, state, or layout code, so none of the state-layout failure conditions apply.
Cmux Architecture Rethink ✅ Passed The reviewed diff changes only Resources/Localizable.xcstrings: 57 values across three plan-loading strings and 19 locales. It changes no Swift code and introduces none of the architectural patterns…
Cmux Swift Auxiliary Window Close Shortcuts ✅ Passed The PR changes only Resources/Localizable.xcstrings. Its diff updates localization values and adds no Swift window code, so it does not introduce or materially change an auxiliary window or its close-…
Cmux Source Artifacts ✅ Passed The only changed path is Resources/Localizable.xcstrings. The diff updates translated values in the localization catalog, which the source-artifact policy explicitly allows. No local or generated ar…
Cmux No Test Or Debug Seam In Production Source ✅ Passed The pull request changes only Resources/Localizable.xcstrings. It changes no Swift files under production Sources/, so it introduces no test or debug seam covered by this check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

CI failure attribution

CI failed on 959543df4e (run 37126528519 attempt 1): 1 code.

Job Verdict Why
macos / macOS compile admission code a compile error
Matched log lines
macos / macOS compile admission: /tmp/cmux-ci/src/cmuxTests/RightSidebarTabCustomizationTests.swift:126:36: error: cannot find 'RightSidebarModeBarDragLayout' in scope

Not re-run automatically: macos / macOS compile admission is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant