Skip to content

ci: route unrelated next packages to focused tests - #17114

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
fix/cmux-next-package-routing
Oct 3, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
fix/cmux-next-package-routing

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

cmux-next’s workflow path filter treated every Packages/macOS/**, Packages/Shared/**, and Packages/iOS/** edit as a full CmuxNext Swift suite. That made unrelated package PRs pay the six minute suite even when their own focused package tests were the useful signal.

The route now leaves CmuxNext package changes on the side workflow, while unrelated Swift package changes use the existing focused swift-package-tests lane and compile admission. The broad package globs were removed from the cmux-next workflow trigger. Webview-only routing from #17109 remains one compile plus web validation.

Validation:

  • targeted CI routing tests for webview and package paths
  • python3 -m compileall -q scripts/ci/detect_ci_change_areas.py tests/test_ci_change_areas.py
  • git diff --check

Resource checks: this PR changes only Linux routing logic and workflow conditions. Idle CPU and memory growth are unchanged because no resident process or loop is added. Disk use is bounded to existing checkouts, logs, and package caches; no new stores or unbounded artifacts are introduced.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Redirects unrelated Swift package changes in Packages/** away from the full CmuxNext suite and into the focused per-package test lane, so unrelated package PRs no longer pay the six-minute CmuxNext run.

  • Removed the broad Packages/macOS/**, Packages/Shared/**, and Packages/iOS/** globs from the cmux-next.yml pull request trigger; only Packages/macOS/CmuxNext/** keeps the CmuxNext workflow there.
  • Base branch pushes to feat-cmux-next still run the full side workflow for every package input.
  • The ci.yml routing now sends non-CmuxNext package edits on pull requests to the existing swift-package-tests lane with compile admission.
  • Webview-only changes still run one compile plus web validation.
  • Added CI routing tests for package and webview paths.

Written for commit 0aa65dd. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 4a36d3d0-d5e7-4ecb-b1b0-9a764449830f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Follow-up correction: broad package globs remain on the push trigger so feat-cmux-next base pushes retain full coverage; only pull_request routing narrows unrelated package PRs to focused tests.

@teamleaderleo
teamleaderleo merged commit 21710d9 into feat-cmux-next Oct 3, 2026
42 checks passed
@teamleaderleo
teamleaderleo deleted the fix/cmux-next-package-routing branch October 3, 2026 04:41
lawrencecchen added a commit that referenced this pull request Oct 4, 2026
- ci.yml dogfood-build (#17204) runs on a Mac but needed only `changes`, so a
  red static stage could still bill Mac minutes. It now also needs
  static-preflight, the same lines as main's #17107.
- cmux-next.yml's push filter is wider than its pull_request filter on
  purpose since #17114 (base pushes keep full side coverage for
  Packages/{macOS,Shared,iOS}/**). The parity test now records that in
  EXEMPTIONS with the reason.
- #17164 gated macos-placement on needs.path_route.outputs.macos, but the
  side-lane placement test context had no path_route output. The context now
  carries a native route, and a no-Mac-work route must skip the placement.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant