Repository navigation
ci: route unrelated next packages to focused tests - #17114
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Follow-up correction: broad package globs remain on the push trigger so feat-cmux-next base pushes retain full coverage; only pull_request routing narrows unrelated package PRs to focused tests. |
- ci.yml dogfood-build (#17204) runs on a Mac but needed only `changes`, so a red static stage could still bill Mac minutes. It now also needs static-preflight, the same lines as main's #17107. - cmux-next.yml's push filter is wider than its pull_request filter on purpose since #17114 (base pushes keep full side coverage for Packages/{macOS,Shared,iOS}/**). The parity test now records that in EXEMPTIONS with the reason. - #17164 gated macos-placement on needs.path_route.outputs.macos, but the side-lane placement test context had no path_route output. The context now carries a native route, and a no-Mac-work route must skip the placement. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
cmux-next’s workflow path filter treated every
Packages/macOS/**,Packages/Shared/**, andPackages/iOS/**edit as a full CmuxNext Swift suite. That made unrelated package PRs pay the six minute suite even when their own focused package tests were the useful signal.The route now leaves CmuxNext package changes on the side workflow, while unrelated Swift package changes use the existing focused
swift-package-testslane and compile admission. The broad package globs were removed from the cmux-next workflow trigger. Webview-only routing from #17109 remains one compile plus web validation.Validation:
python3 -m compileall -q scripts/ci/detect_ci_change_areas.py tests/test_ci_change_areas.pygit diff --checkResource checks: this PR changes only Linux routing logic and workflow conditions. Idle CPU and memory growth are unchanged because no resident process or loop is added. Disk use is bounded to existing checkouts, logs, and package caches; no new stores or unbounded artifacts are introduced.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Redirects unrelated Swift package changes in
Packages/**away from the full CmuxNext suite and into the focused per-package test lane, so unrelated package PRs no longer pay the six-minute CmuxNext run.Packages/macOS/**,Packages/Shared/**, andPackages/iOS/**globs from thecmux-next.ymlpull request trigger; onlyPackages/macOS/CmuxNext/**keeps the CmuxNext workflow there.feat-cmux-nextstill run the full side workflow for every package input.ci.ymlrouting now sends non-CmuxNext package edits on pull requests to the existingswift-package-testslane with compile admission.Written for commit 0aa65dd. Summary will update on new commits.