Repository navigation
Probe CJK coverage explicitly in the single-font injection test - #16884
Merged
Merged
Conversation
#9193 made CJK font-fallback injection fail closed when the configured family cannot be resolved. testShouldInjectCJKFontFallbackAllowsSingle FontWithoutExplicitOverrides relied on JetBrains Mono being installed, so it failed on CI runners without that font. It now passes a coverage probe that reports no CJK coverage, which tests the single-font rule without depending on the machine's fonts.
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe single-font fallback test now injects a range-coverage probe. It checks for ChangesFont fallback test
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Other Merge Risk: ⚪ Minimal · up to This makes the fallback test independent of fonts installed on the test machine without changing product behavior. No actionable merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lawrencecchen
changed the title
Contributor
|
Merge receipt for |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Oct 2, 2026
23d3e88 Probe CJK coverage explicitly in the single-font injection test (manaflow-ai#16884)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's full suite on b9ca453 (https://github.com/manaflow-ai/cmux/actions/runs/37017476521) failed a test that had not run while the app test target could not compile (fixed in #16797).
#9193 made CJK font-fallback injection fail closed when the configured family cannot be resolved.
testShouldInjectCJKFontFallbackAllowsSingleFontWithoutExplicitOverridesrelied on JetBrains Mono being installed, so it failed on runners without that font. It now passes a coverage probe that reports no CJK coverage. That tests the rule (a single font without overrides still gets injection) without depending on installed fonts. Product behavior is unchanged; #9193 has its own tests for the fail-closed path.The same full-suite run also failed
SimulatorPrivatePrivacyAdapterTests"Runtime-wide TCC readback groups applications and stays bounded" once. It is not changed here: it passed 25 of 25 local stress runs, its query returns all 258 rows on SQLite 3.43.2 (the macOS 15 runner's version), and the code it covers has not changed since 2026-09-10. It looks like a rare flake under CI load.Testing
macos / macOS compile admissionrancmuxTests/GhosttyMouseFocusTests, andtestShouldInjectCJKFontFallbackAllowsSingleFontWithoutExplicitOverridespassed.Changelog
No user-facing change.