Skip to content

cmux-tui: rustfmt machine_provider_transport.rs - #16862

Merged
lawrencecchen merged 1 commit into
mainfrom
fix-cmux-tui-fmt-machine-provider-transport
Oct 2, 2026
Merged

lawrencecchen merged 1 commit into
mainfrom
fix-cmux-tui-fmt-machine-provider-transport

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

main fails cargo fmt --check in two test assertions in cmux-tui/crates/cmux-tui/src/machine_provider_transport.rs, so every hosted cmux-tui test job on main stops at the formatting step before any test runs (seen in run 37008421240). This PR is formatting only.

Changelog

none

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Reformats two test assertions in machine_provider_transport.rs so cargo fmt --check passes and the hosted cmux-tui test jobs no longer stop at the formatting step.

  • No functional changes; the assertions are equivalent before and after formatting.

Written for commit 68c7904. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • No user-facing bugs were fixed in this update.
  • New Features
    • No end-user features or capabilities were added or changed. Existing SSH connection behavior remains unchanged, and this update does not alter how the product works for end users.

main fails `cargo fmt --check` in two assertions of this file's tests, so
every hosted cmux-tui test job on main stops at the formatting step before
any test runs. Formatting only.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (2)
docs/cloud-guest-upgrades.md — configured
.github/review-bot-rules/source-control-artifacts.md — configured

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 5896f974-c581-4c8e-b607-cf179a995430

📥 Commits

Reviewing files that changed from the base of the PR and between 342bd9d and 68c7904.

📒 Files selected for processing (1)
  • cmux-tui/crates/cmux-tui/src/machine_provider_transport.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The SSH argument assertion was reformatted. Its expected arguments and condition are unchanged.

Changes

SSH argument assertion

Layer / File(s) Summary
SSH argument assertion formatting
cmux-tui/crates/cmux-tui/src/machine_provider_transport.rs
The assertion checks the expected --, destination, and remote control-command argument sequence. Its condition is unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 68c79

The SSH assertion is reformatted without changing what it checks, so the PR introduces no merge-blocking behavior change.

Architecture Summary

Architecture risk: 🔵 Low · up to 68c79

The change affects 1 system.

Changed systems: cmux-tui

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — cmux-tui (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in cmux-tui/crates/cmux-tui/src/machine_provider_transport.rs: Reformatted the assertion checking for the exact --, destination, and remote control-command argument sequence; the assertion’s condition is unchanged.
🚥 Pre-merge checks | ✅ 24 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the formatting problem and states that the changelog is none, but it omits the required Testing section and does not state which command ran or what passed. Add a Testing section. State whether cargo fmt --check or the applicable CI job was run, the result, and what remains unverified. Remove non-applicable template sections or explain why they do not apply.
✅ Passed checks (24 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the formatting-only change to machine_provider_transport.rs.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input ✅ Passed PASS: The reviewed range changes only machine_provider_transport.rs. The base and head files are identical after whitespace removal, and the patch only reformats one SSH argument assertion. No Cloud…
Cmux Swift Actor Isolation ✅ Passed PASS: The pull request changes only cmux-tui/crates/cmux-tui/src/machine_provider_transport.rs. The diff reformats a Rust test assertion and introduces no Swift or production actor-isolation changes…
Cmux Swift Blocking Runtime ✅ Passed PASS: The pull request changes only cmux-tui/crates/cmux-tui/src/machine_provider_transport.rs, a Rust test file. The diff only reformats an existing assertion. It introduces no production Swift cod…
Cmux Browser Automation Off-Main ✅ Passed PASS: The pull request changes only a Rust formatting assertion in cmux-tui/crates/cmux-tui/src/machine_provider_transport.rs. It does not modify browser socket commands, `Sources/TerminalController…
Cmux Expensive Synchronous Load ✅ Passed PASS: The pull request changes only a Rust test assertion in cmux-tui/crates/cmux-tui/src/machine_provider_transport.rs. The review-scoped diff contains no Swift files and adds no production agent-h…
Cmux Cache Substitution Correctness ✅ Passed PASS. The PR changes only formatting in the Rust test file cmux-tui/crates/cmux-tui/src/machine_provider_transport.rs. The diff does not modify a Swift, TypeScript, or JavaScript production path, an…
Cmux No Hacky Sleeps ✅ Passed PASS: The pull request changes only a Rust test assertion in machine_provider_transport.rs. It does not modify TypeScript, JavaScript, shell, or build/runtime scripts, and it introduces no sleep, ti…
Cmux Algorithmic Complexity ✅ Passed PASS. The pull request changes only formatting in a Rust test assertion in machine_provider_transport.rs. It introduces no production Swift, TypeScript, JavaScript, shell, or runtime code, and the a…
Cmux Swift Concurrency ✅ Passed PASS: The authoritative diff changes only one Rust file, cmux-tui/crates/cmux-tui/src/machine_provider_transport.rs. It only reformats an existing assertion. No Swift files or Swift concurrency patt…
Cmux Swift @Concurrent ✅ Passed PASS: The pull request changes only one .rs file and reformats a Rust assertion. The reviewed diff contains no Swift files, @concurrent annotations, nonisolated async functions, or Swift call si…
Cmux Swift Package Boundaries ✅ Passed The pull request changes only cmux-tui/crates/cmux-tui/src/machine_provider_transport.rs, a Rust file. It introduces no Swift or SwiftPM package changes, so the Swift package boundary check is not a…
Cmux Swiftpm Lockfiles ✅ Passed The pull request changes only cmux-tui/crates/cmux-tui/src/machine_provider_transport.rs. The diff reformats a Rust test assertion and does not change SwiftPM files, Xcode project files, `.gitignore…
Cmux Swift Logging ✅ Passed PASS: The pull request changes only a Rust test assertion in machine_provider_transport.rs. The authoritative diff contains no Swift files and adds or changes no logging statements, so the Swift log…
Cmux User-Facing Error Privacy ✅ Passed PASS. The only changed file change reformats an assertion inside the Rust #[cfg(test)] test module. The expected SSH argument sequence and behavior remain unchanged. No production user-facing error,…
Cmux Full Internationalization ✅ Passed PASS. The PR changes one file and only reformats an assertion inside the #[cfg(test)] mod tests block. The assertion values and behavior are unchanged. No production user-facing text, localization c…
Cmux Swiftui State Layout ✅ Passed The pull request changes only one Rust file, machine_provider_transport.rs, and only reformats an existing test assertion. The diff introduces no SwiftUI view, state, layout, or render-time mutation…
Cmux Architecture Rethink ✅ Passed PASS: The pull request changes one Rust test assertion in machine_provider_transport.rs by formatting it. The diff introduces no Swift code and no architectural behavior. It does not add timing, pol…
Cmux Swift Auxiliary Window Close Shortcuts ✅ Passed PASS: The pull request changes only Rust formatting in cmux-tui/crates/cmux-tui/src/machine_provider_transport.rs. The reviewed diff contains no Swift changes and no cmux-owned auxiliary window code…
Cmux Source Artifacts ✅ Passed The pull request changes only cmux-tui/crates/cmux-tui/src/machine_provider_transport.rs, a hand-written Rust source/test file. The diff only reformats an existing assertion and adds no local output…
Cmux No Test Or Debug Seam In Production Source ✅ Passed PASS: The pull request changes only cmux-tui/crates/cmux-tui/src/machine_provider_transport.rs, a Rust file. It changes test assertion formatting only. No Swift file under a production Sources/ pa…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawrencecchen
lawrencecchen merged commit b9ca453 into main Oct 2, 2026
74 of 75 checks passed
@lawrencecchen
lawrencecchen deleted the fix-cmux-tui-fmt-machine-provider-transport branch October 2, 2026 14:05
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Merge receipt for 68c7904807: every check was green at merge (13 verified; 20 skipped by policy). Full suite runs on main after merge.

rustybret pushed a commit to rustybret/bmux that referenced this pull request Oct 2, 2026
b9ca453 cmux-tui: rustfmt machine_provider_transport.rs (manaflow-ai#16862)
342bd9d fix(ci): restore shared Codex fork monitor helper (manaflow-ai#16797)
bc45a33 Merge pull request manaflow-ai#16768 from manaflow-ai/cloud-new-machine-top
ded01a6 water-fill sidebar tabs around wider floors
eba1ade preserve selected sidebar tab width
8ab67b5 iOS dogfood: app-receipt readiness mode for the iPhone launcher (manaflow-ai#16845)
3436ac0 fix cloud sidebar warning budget
5de4664 Merge remote-tracking branch 'origin/cloud-new-machine-top' into repair-pr16768
f4ac955 fix: import shared Codex monitor contract
46671c9 fix: satisfy package namespace conventions
3c8a9c4 fix: share Codex fork monitor contract in package
93a9ca0 clear stale cloud creation rows
2bbdbfc Merge main (72bdb81) into repair-pr16768
5f04117 Merge remote-tracking branch 'origin/cloud-new-machine-top' into repair-pr16768
c42884f fix: retain app-side Codex monitor compatibility
7c23f4a preserve cloud upgrade affordance and agent localization
d25f264 gate cloud machine button by plan availability
2552863 fix cloud row accessibility state reuse
8740001 chore: remove duplicate cloud settings import
4a6a549 fix cloud sidebar review findings
c7dc7a1 fix cloud sidebar localization coverage
dddaedc resources readings start on the first tab's title
8a26e59 keep main's invite-only cloud header
83c0cf4 review fixes: restore main's resolved new workspace action, keep open tab rows current and open across collapse, quiet spacer for voiceover, scope collapsed defaults to cloud machines, tab row menu, tests for collapsed workspaces
62efbbf cloud sidebar redesign: new cloud machine button, regrouped machine rows with ports, terminals and resources tabs, one hover system, responsive sidebar tabs

# Conflicts:
#	.github/workflows/ci-guards.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant