Skip to content

Drop unused url bindings from Cloud port rows - #16834

Closed
lawrencecchen wants to merge 1 commit into
mainfrom
fix-cloud-port-unused-url
Closed

lawrencecchen wants to merge 1 commit into
mainfrom
fix-cloud-port-unused-url

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

#16350 (#16350) removed the inline Open in cmux action from port rows but left three case .port(let resource, let url, _) bindings in CloudTreeNode, CloudTreeRowContentView, and CloudTreeRowToolTip whose url is never used. Those three warnings exceed the Swift warning budget (budget 0 for each bucket), so macos / macOS compile admission fails on main and on every PR once the test target compiles again (see #16797, run https://github.com/manaflow-ai/cmux/actions/runs/37006162552). The bindings are now _.

Testing: the warning-budget step in compile admission is the check. No behavior change, so no test.

Changelog

No user-facing change.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Removes unused url bindings from Cloud port row cases in CloudTreeNode, CloudTreeRowContentView, and CloudTreeRowToolTip. The unused bindings tripped the Swift warning budget and broke macOS compile admission on main and on every PR.

No behavior change; the url was left unused after the inline Open action was removed.

Written for commit 4a5e76a. Summary will update on new commits.

Review in cubic

#16350 removed the inline Open in cmux action but left three
case .port(let resource, let url, _) bindings whose url is unused. The
three warnings exceed the Swift warning budget, which fails macOS
compile admission on main and on every PR.
@cursor

cursor Bot commented Oct 2, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Duplicate of #16797 (commit c8af4f7 carries the same fix).

@lawrencecchen
lawrencecchen deleted the fix-cloud-port-unused-url branch October 2, 2026 12:43
@coderabbitai

coderabbitai Bot commented Oct 2, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a3b45f91-2245-42c5-9786-510361e63e53

📥 Commits

Reviewing files that changed from the base of the PR and between 680f0de and 4a5e76a.

📒 Files selected for processing (3)
  • Sources/Cloud/CloudTreeNode.swift
  • Sources/Cloud/CloudTreeRowContentView.swift
  • Sources/Cloud/CloudTreeRowToolTip.swift
 ___________________________________________________________________________
< In Vino Veritas, In Codice Bugas. In wine, there is truth; in code, bugs. >
 ---------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant