Repository navigation
Drop unused url bindings from Cloud port rows - #16834
lawrencecchen wants to merge 1 commit into
Conversation
#16350 removed the inline Open in cmux action but left three case .port(let resource, let url, _) bindings whose url is unused. The three warnings exceed the Swift warning budget, which fails macOS compile admission on main and on every PR.
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
#16350 (#16350) removed the inline Open in cmux action from port rows but left three
case .port(let resource, let url, _)bindings inCloudTreeNode,CloudTreeRowContentView, andCloudTreeRowToolTipwhoseurlis never used. Those three warnings exceed the Swift warning budget (budget 0 for each bucket), somacos / macOS compile admissionfails on main and on every PR once the test target compiles again (see #16797, run https://github.com/manaflow-ai/cmux/actions/runs/37006162552). The bindings are now_.Testing: the warning-budget step in compile admission is the check. No behavior change, so no test.
Changelog
No user-facing change.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Removes unused
urlbindings from Cloud port row cases inCloudTreeNode,CloudTreeRowContentView, andCloudTreeRowToolTip. The unused bindings tripped the Swift warning budget and broke macOS compile admission on main and on every PR.No behavior change; the
urlwas left unused after the inline Open action was removed.Written for commit 4a5e76a. Summary will update on new commits.