ci: pin Xcode 26.6 for macOS 27 runners - #16547
Conversation
The AWS M4 Pro workers move to macOS 27 in place. scripts/select-ci-xcode.sh fails a job on a runner whose macOS major has no line in scripts/ci/xcode-pins.txt, and every pin must keep the .xcode-version major (26), so macOS 27 runners use Xcode 26.6, installed next to Xcode 27. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe Xcode pin table now maps macOS 27 runners to Xcode 26.6. Its comments describe the runner pool and retain the requirement that each pin matches the major version in ChangesXcode pin table
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change adds a configuration row so macOS 27 runners use Xcode 26.6, which is installed on those workers alongside Xcode 27. No concrete defect remains, and the change is low risk to merge. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The new mapping preserves existing toolchain validation and does not show expanded permissions or credential access. Deployment readiness remains unverified: no macOS 27 runner is reported available yet, and its installed toolchain and host-state isolation have not been demonstrated. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 25✅ Passed checks (25 passed)
✨ Finishing Touches 💡 1🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="scripts/ci/xcode-pins.txt">
<violation number="1" location="scripts/ci/xcode-pins.txt:18">
P3: docs/ci-runners.md:85 still enumerates the pin mapping as "Xcode 26.3 on macOS 15 and Xcode 26.6 on macOS 26 today", and the new `27 26.6` pin is now the third pool in scripts/ci/xcode-pins.txt. The doc stays accurate only until the first runner reports macOS 27; update the enumeration (or add the macOS 27 pool note) in this PR so the documented pin contract matches the file.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| # macOS Xcode | ||
| 15 26.3 | ||
| 26 26.6 | ||
| 27 26.6 |
There was a problem hiding this comment.
P3: docs/ci-runners.md:85 still enumerates the pin mapping as "Xcode 26.3 on macOS 15 and Xcode 26.6 on macOS 26 today", and the new 27 26.6 pin is now the third pool in scripts/ci/xcode-pins.txt. The doc stays accurate only until the first runner reports macOS 27; update the enumeration (or add the macOS 27 pool note) in this PR so the documented pin contract matches the file.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At scripts/ci/xcode-pins.txt, line 18:
<comment>docs/ci-runners.md:85 still enumerates the pin mapping as "Xcode 26.3 on macOS 15 and Xcode 26.6 on macOS 26 today", and the new `27 26.6` pin is now the third pool in scripts/ci/xcode-pins.txt. The doc stays accurate only until the first runner reports macOS 27; update the enumeration (or add the macOS 27 pool note) in this PR so the documented pin contract matches the file.</comment>
<file context>
@@ -7,8 +7,12 @@
# macOS Xcode
15 26.3
26 26.6
+27 26.6
</file context>
CI failure attributionCI passes on Written by |
|
Merge receipt for |
70e997f Merge pull request manaflow-ai#16199 from manaflow-ai/16189-cloud-sidebar-icons 5e4a6f5 Fix terminal scrollback follow after accepted input (manaflow-ai#16529) ae5c960 switch account, cmux sign-in page, and saved sessions like gmail (manaflow-ai#16364) 5610998 test: pin Flash While Typing off in the typing-dismiss no-flash test (manaflow-ai#16625) db21906 Fix sidebar template catalog and Cloud machine-row tests; drop stale preview generator (manaflow-ai#16595) 2ec0306 ci: pin Xcode 26.6 for macOS 27 runners (manaflow-ai#16547) dc56459 fix: make Cloud command palette actions follow workspace capabilities (manaflow-ai#16273) 638b468 Fix mobile Feed notification duplicates and update warning (manaflow-ai#16352) 49d798e test: use deterministic Cloud header sizing e2fc8fc Merge remote-tracking branch 'upstream/main' into 16189-cloud-sidebar-icons 4b2db7c test: allow Cloud header controls to settle 80ca30f Merge remote-tracking branch 'upstream/main' into 16189-cloud-sidebar-icons e2f2b7d fix: constrain Cloud header action layout 75990f6 fix: remove duplicate pane test binding 8738ba2 fix: restore custom sidebar preview resources 2c6819a Merge remote-tracking branch 'upstream/main' into 16189-cloud-sidebar-icons 017b63b fix: use local SSH command quoting ac5eba5 fix: compile sidebar usage owner selection 90b0655 fix: make custom upload endpoint policy explicit 82ddf7c fix: pass remote paste policy to custom uploads 77ec507 Merge remote-tracking branch 'upstream/main' into 16189-cloud-sidebar-icons eaceb98 Merge remote-tracking branch 'upstream/main' into 16189-cloud-sidebar-icons 8436277 Merge main (4e9d779) into 16189-cloud-sidebar-icons c17fa5d Merge main (488eaf7) into 16189-cloud-sidebar-icons 9672805 Cloud sidebar tests: import CmuxFoundation for GlobalFontMagnification eae5972 fix(tests): restore PaneResizeShortcutTests' controller binding dd91af2 fix(tests): allow bounded main queue drain timeout aff65ce test: check the vm ready poll interval in cmuxCLITests so cmuxTests compiles 91d743a Merge commit '5e83d8029eedca144c10096fa8b3664a940092b3' into 16189-cloud-sidebar-icons 022502a Merge main (7ba9740) into 16189-cloud-sidebar-icons 7f1297d fix: list setting actions in Actions discovery so main compiles (manaflow-ai#16222) aa5e7e8 Merge main (b3ca418) into 16189-cloud-sidebar-icons b53c137 Merge main (1831681) into 16189-cloud-sidebar-icons 4400412 Cloud sidebar: withhold New Workspace while the fleet read is failing 71ac098 fix: restore main's build after manaflow-ai#14868 and manaflow-ai#13232 crossed in CmuxConfig d9dfb3e Cloud workspace targeting: never resolve New Workspace to a locked machine 73f59e7 Merge main (c12e934) into 16189-cloud-sidebar-icons 5a43fcb Cloud sidebar: move section icons to headers and guard create rows 9d32421 Cloud sidebar: test section identity icons and guarded create rows
Summary
The AWS M4 Pro fleet hosts move from macOS 15 to macOS 27 in place, so Xcode 27 can run there.
scripts/select-ci-xcode.shfails a job on a runner whose macOS major has no line inscripts/ci/xcode-pins.txt, andtests/test_ci_macos_xcode_selection.pyrequires every pin to keep the.xcode-versionmajor (26). This adds27 26.6: macOS 27 runners build with Xcode 26.6, which is installed next to Xcode 27.Testing
python3 tests/test_ci_macos_xcode_selection.pypasses locally. No runner is on macOS 27 yet.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Pins Xcode 26.6 for macOS 27 runners so CI jobs don't fail when the AWS M4 Pro fleet upgrades to macOS 27 in place.
27 26.6line toscripts/ci/xcode-pins.txt.Written for commit 1bbfcf4. Summary will update on new commits.
Summary by CodeRabbit