Skip to content

fix: export Foundation for SSH paste policy - #16524

Closed
teamleaderleo wants to merge 3 commits into
mainfrom
fix/ssh-image-paste
Closed

teamleaderleo wants to merge 3 commits into
mainfrom
fix/ssh-image-paste

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fixes the post-merge Swift package compile failure from #16523 by exporting Foundation from the remote paste policy module before exposing its UUID and URL API.

Sundial g1 🛠️

Validation

The failure was reproduced in hosted macos / swift-package-tests and macos / macOS compile admission on #16523. This change addresses the reported access-control errors directly. Local Swift syntax and repository guards pass.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes the Swift package compile failure by exporting Foundation from the remote paste policy, and moves pasted image uploads into per-session private remote directories with automatic cleanup.

  • Uploads now go to ~/.cache/cmux/paste/<session-id>/cmux-paste-<uuid>.<ext> instead of /tmp/cmux-drop-*.
  • Adds a policy that creates and maintains the directory, removes stale or oversized files, enforces 0600 permissions, and cleans up on session teardown.
  • Rolls back uploaded files on failure and removes the directory when the remote session ends.

Written for commit b67f6b0. Summary will update on new commits.

Review in cubic

teamleaderleo and others added 3 commits October 1, 2026 15:13
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 7d01a3b6-9de8-47b4-9345-ff06fa957676

📥 Commits

Reviewing files that changed from the base of the PR and between 6d86537 and b67f6b0.

📒 Files selected for processing (10)
  • Packages/macOS/CmuxRemoteSession/Sources/CmuxRemoteSession/Session/RemoteSessionCoordinator+Lifecycle.swift
  • Packages/macOS/CmuxRemoteSession/Sources/CmuxRemoteSession/Session/RemoteSessionCoordinator+Upload.swift
  • Packages/macOS/CmuxRemoteSession/Sources/CmuxRemoteSession/Session/RemoteSessionCoordinator.swift
  • Packages/macOS/CmuxRemoteSession/Sources/CmuxRemoteSession/Values/RemotePasteFileTransferPolicy.swift
  • Packages/macOS/CmuxRemoteSession/Tests/CmuxRemoteSessionTests/RemotePasteFileTransferPolicyTests.swift
  • Sources/TerminalCustomUploadRunner.swift
  • Sources/TerminalSSHSessionDetector.swift
  • cmuxTests/TerminalAndGhosttyTests.swift
  • cmuxTests/TerminalUploadCommandTests.swift
  • cmuxTests/WorkspaceRemoteConnectionTests.swift
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@teamleaderleo
teamleaderleo enabled auto-merge (squash) October 1, 2026 22:34
auto-merge was automatically disabled October 1, 2026 22:34

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant