Skip to content

fix(ci): install Go for iOS App Store archive - #16486

Merged
teamleaderleo merged 1 commit into
mainfrom
fix/ios-appstore-go
Oct 1, 2026
Merged

teamleaderleo merged 1 commit into
mainfrom
fix/ios-appstore-go

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

The iOS CloudVPN target now builds the real wireguard-go archive for Release builds, but the App Store Connect workflow did not provision Go. Its archive therefore stopped at Build wireguard-go with go was not found on PATH, before App Store authentication.

This adds the pinned Go 1.26.x setup used by the other Cloud tunnel Release lanes, with module caching disabled because this workflow does not use a repository Go module.

The triggering iOS CloudVPN change landed in #15935 from @azooz2003-bit.

Validation: git diff --check; Ruby YAML parse passed.

— Juniper g1 🗝️


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

The iOS App Store archive workflow now sets up Go before invoking Xcode, so the CloudVPN Release archive can build the wireguard-go bridge instead of failing with go was not found on PATH.

  • Uses the pinned Go 1.26.x with module caching disabled, matching the other Cloud tunnel Release lanes.

Written for commit 66f46ea. Summary will update on new commits.

Review in cubic

The iOS CloudVPN Release archive now builds the wireguard-go bridge, so the App Store workflow must provision the pinned Go toolchain before invoking Xcode.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo
teamleaderleo enabled auto-merge (squash) October 1, 2026 20:20
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 7aeae2ba-ff47-4f42-888c-e3c44a5b54db

📥 Commits

Reviewing files that changed from the base of the PR and between bbb73b6 and 66f46ea.

📒 Files selected for processing (1)
  • .github/workflows/ios-appstore-upload.yml
 ____________________
< I dream in semver. >
 --------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo
teamleaderleo merged commit e0dc415 into main Oct 1, 2026
45 of 50 checks passed
@teamleaderleo
teamleaderleo deleted the fix/ios-appstore-go branch October 1, 2026 20:22
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Merge receipt for 66f46ead09, merged 2026-10-01 20:22:27 UTC

  • Not verified at merge: ci-status (not reported), CI fast guards (in progress), guards (18) (failure)
  • Verified: Fast static checks, GhosttyKit release check, Web complexity, web-validation
  • Skipped by policy: browser, Claude wrapper regressions, Dogfood build #​${{ github.event.pull_request.number }}, full-suite-coverage, macos, remote-daemon, suite-coverage, web, web-build, web-database-tests, web-tests
  • Full suite: runs on main after merge.

Labeled merged-unverified: if main breaks near this merge, look here first.

@github-actions github-actions Bot added the merged-unverified A judging check was not green at merge; see the merge receipt comment label Oct 1, 2026
rustybret pushed a commit to rustybret/bmux that referenced this pull request Oct 1, 2026
984179e fix: two more crossed-merge compile breaks on main (sidebar test seam, Cloud agent launch) (manaflow-ai#16490)
b1b876c fix(ios): prevent composer shortcut strip edge snapping (manaflow-ai#16128)
337861c ci: keep janitor sweeps green on refused cancellations (manaflow-ai#16488)
e0dc415 fix(ci): install Go before iOS App Store archive (manaflow-ai#16486)
c247a88 rename the duplicate node options resume test so ci's selector check passes (manaflow-ai#16481)
bbb73b6 ci: a job stuck with no runner no longer cancels jobs running on a mini (manaflow-ai#16479)
28ed45d fix(cli): repair main seed compile errors (manaflow-ai#16485)

# Conflicts:
#	.github/workflows/ios-appstore-upload.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-unverified A judging check was not green at merge; see the merge receipt comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant