-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix: unblock main CI (settings compile, bonsplit tests) #16408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b874a11
9b170c0
2e29c7f
360bc43
0279a2c
72ed68c
e6ba67d
8ec30fb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -98,10 +98,12 @@ struct CustomSidebarValidationTests { | |||||||
| func downloadableCustomSidebarExamplesValidate() throws { | ||||||||
| let directory = examplesDirectory() | ||||||||
| let report = validator.validate(directory: directory, dataContext: Self.richSidebarContext) | ||||||||
| // manifest.json is the built-in template catalog's index, not a sidebar. | ||||||||
| let sidebars = report.entries.filter { $0.name != "manifest" } | ||||||||
|
|
||||||||
| #expect(report.names.sorted() == ["activity", "agents-board", "agents-cards", "agents-dense", "agents-focus", "agents-timeline", "btop-agents", "clock", "compact", "finder", "focus", "kitchen-sink", "panel-info", "panel-sessions", "panel-subagents", "panel-todo", "ports", "status-board", "workspaces"]) | ||||||||
| #expect(report.validCount == 19) | ||||||||
| #expect(report.errorCount == 0) | ||||||||
| #expect(sidebars.map(\.name).sorted() == ["activity", "agents-board", "agents-cards", "agents-dense", "agents-focus", "agents-timeline", "btop-agents", "clock", "compact", "finder", "focus", "kitchen-sink", "panel-info", "panel-sessions", "panel-subagents", "panel-todo", "ports", "status-board", "workspaces"]) | ||||||||
| #expect(sidebars.filter(\.isValid).count == 19) | ||||||||
| #expect(sidebars.allSatisfy(\.isValid)) | ||||||||
|
Comment on lines
+105
to
+106
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P3: Prompt for AI agents
Suggested change
|
||||||||
| } | ||||||||
|
|
||||||||
| @MainActor | ||||||||
|
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: This plain
//comment between the enum's///doc block and the declaration detaches the doc comment: Swift associates a doc comment only with the declaration it immediately precedes, soCustomSidebarTemplateGalleryRequestloses "Holds a gallery request until the progressively mounted Custom Sidebars section…" in Xcode quick help / DocC. Convert the line to a///doc line so it stays part of the doc block; the namespace scanner matches the marker against raw text regardless, so the suppression still works (verified: the rule fires without the marker and is silenced with it).Prompt for AI agents