Repository navigation
fix(browser): unwrap optional page restoration URL - #16395
austinywang wants to merge 1 commit into
Conversation
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
CI failure attributionCI failed on
Matched log linesNot re-run automatically: Written by |
Dogfood tours of
|
|
Hosted compile admission on this head no longer reports |
|
Correctness review: the one-line |
teamleaderleo
left a comment
There was a problem hiding this comment.
Superseded on main: 538aaf6 ("Normalize instance tags and fix browser restoration compile") added the same let documentURL, guard at Sources/Panels/BrowserPanel+PageRestoration.swift:84. Merging this onto current main produces an empty diff, so it can close.
|
Closing: covered on main by 538aaf6, which added the same documentURL unwrap. |
main's nightly Release build failed during compile admission because the Memory Saver page-restoration path passed its optionaldocumentURLintoBrowserFormStateSnapshot.isSameDocument, which requires concrete URLs. The guard now unwraps the URL before comparing session state, while preserving the existing nil behavior for panes with no committed document.The failure is recorded in main run 36823012853, job 110244894895, at
Sources/Panels/BrowserPanel+PageRestoration.swift:87.The focused hosted run on this head no longer reports that browser error. It remains blocked by the independent duplicate notification accent declaration in
Sources/Update/UpdateTitlebarAccessory.swift; that updater/notification repair is tracked in #16388, and this PR intentionally does not touch updater files.Testing
python3 scripts/verify-local.py --only swift-syntax --swift-changed origin/mainpython3 scripts/swift_file_length_budget.pygit diff --checkChangelog
Fixed: page restoration now compiles when a discarded browser pane has no committed URL.