Skip to content

fix(coderouter): fail OpenCode uploads cleanly when the client body errors on Bun 1.3 #16360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lawrencecchen wants to merge 1 commit into from
Closed

fix(coderouter): fail OpenCode uploads cleanly when the client body errors on Bun 1.3 #16360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions web/services/coderouter/opencodeProxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,8 +808,12 @@ function pinnedFetch(pin: ProviderPin): typeof fetch {
});
outgoing.on("error", reject);
if (body) {
// pipeline destroys the request when the client body fails.
pipeline(Readable.fromWeb(body as import("node:stream/web").ReadableStream), outgoing, (error) => {
// pipeline destroys the request when the client body fails. The body
// is read as an async iterable, not through Readable.fromWeb: Bun
// 1.3's fromWeb throws a source stream error as an uncaught
// exception instead of passing it to pipeline.
const source = Readable.from(body as import("node:stream/web").ReadableStream<Uint8Array>, { objectMode: false });
pipeline(source, outgoing, (error) => {
if (error) reject(error);
});
} else {
Expand Down
Loading