ci: avoid rerunning guards after settled fast-guard failure - #16258
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
Merge receipt for |
488eaf7 fix(cloud): make Cloud workspace reconciliation always settle (manaflow-ai#16158) 02b80fe ci: cmux-tui artifact publishing runs in its own artifacts environment (manaflow-ai#16267) 71bb553 ci: propagate settled fast-guard failures (manaflow-ai#16258) 3121d49 ci: fold Testbox guard checks into fast guard lane (manaflow-ai#16247) # Conflicts: # .github/workflows/ci-guards.yml # .github/workflows/cmux-tui-artifacts.yml # .github/workflows/testbox-broker-guard.yml
When the independent
CI fast guardsworkflow settles as a failure,ci-guards.ymlcurrently treats that result as unavailable and reruns the full 81-stepciguard group. That duplicates work on another runner while preserving no additional signal.This change propagates a settled fast-guard failure as a single failure result and reserves the full fallback group for a missing or still-unavailable fast-guard check. The local planner and tests cover the three states (
success,failure,unavailable).Validation:
expected 1 notification error, got 2).Summary by cubic
Stops rerunning the full
ciguard group after the independentCI fast guardsworkflow settles as a failure.Previously the status poller reduced both "unavailable" and "failed" to the same fallback, duplicating the 81-step suite on another runner without added signal. Now a settled failure propagates as a single failed result, and the fallback group runs only while the check is missing or still pending. The poller exposes a
stateoutput (success,failure,unavailable), and thecimatrix leg exits 1 when that state isfailure. Local planner runs are unaffected because propagation relies on an Actions-only step.Written for commit 0fef449. Summary will update on new commits.