Skip to content

ci: avoid rerunning guards after settled fast-guard failure - #16258

Merged
teamleaderleo merged 1 commit into
mainfrom
ci/avoid-failed-fast-guard-duplicate
Sep 30, 2026
Merged

teamleaderleo merged 1 commit into
mainfrom
ci/avoid-failed-fast-guard-duplicate

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

When the independent CI fast guards workflow settles as a failure, ci-guards.yml currently treats that result as unavailable and reruns the full 81-step ci guard group. That duplicates work on another runner while preserving no additional signal.

This change propagates a settled fast-guard failure as a single failure result and reserves the full fallback group for a missing or still-unavailable fast-guard check. The local planner and tests cover the three states (success, failure, unavailable).

Validation:

  • Focused structural/unit tests pass.
  • Full local CI guard group: 78 passed, 2 Linux-only skipped, 1 unrelated existing notification-semantics failure (expected 1 notification error, got 2).

Summary by cubic

Stops rerunning the full ci guard group after the independent CI fast guards workflow settles as a failure.

Previously the status poller reduced both "unavailable" and "failed" to the same fallback, duplicating the 81-step suite on another runner without added signal. Now a settled failure propagates as a single failed result, and the fallback group runs only while the check is missing or still pending. The poller exposes a state output (success, failure, unavailable), and the ci matrix leg exits 1 when that state is failure. Local planner runs are unaffected because propagation relies on an Actions-only step.

Written for commit 0fef449. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 5c67939d-b7cf-4441-bae2-8462bd89ba03

📥 Commits

Reviewing files that changed from the base of the PR and between 3121d49 and 0fef449.

📒 Files selected for processing (5)
  • .github/workflows/ci-guards.yml
  • scripts/ci/fast_guard_status.py
  • scripts/ci/run_ci_guards.py
  • tests/test_ci_fast_guard_status.py
  • tests/test_ci_guard_workflow_structure.py
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@teamleaderleo
teamleaderleo merged commit 71bb553 into main Sep 30, 2026
61 checks passed
@teamleaderleo
teamleaderleo deleted the ci/avoid-failed-fast-guard-duplicate branch September 30, 2026 22:28
@github-actions

Copy link
Copy Markdown
Contributor

Merge receipt for 0fef449bfb: every check was green at merge (12 verified; 20 skipped by policy). Full suite runs on main after merge.

rustybret pushed a commit to rustybret/bmux that referenced this pull request Sep 30, 2026
488eaf7 fix(cloud): make Cloud workspace reconciliation always settle (manaflow-ai#16158)
02b80fe ci: cmux-tui artifact publishing runs in its own artifacts environment (manaflow-ai#16267)
71bb553 ci: propagate settled fast-guard failures (manaflow-ai#16258)
3121d49 ci: fold Testbox guard checks into fast guard lane (manaflow-ai#16247)

# Conflicts:
#	.github/workflows/ci-guards.yml
#	.github/workflows/cmux-tui-artifacts.yml
#	.github/workflows/testbox-broker-guard.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant