Repository navigation
fix(tests): allow bounded main queue drain timeout - #16232
teamleaderleo wants to merge 1 commit into
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
CI failure attributionCI failed on
Matched log linesNot re-run automatically: Written by |
|
main's cmuxTests bundle has three independent compile errors right now: |
The same change as #16232 (7a51764), carried so this PR can restore main's cmuxTests build in one piece. #15381 made LastSurfaceClosePreferenceTests and WorkspaceCloseTabsContextMenuTests call drainMainQueue(timeout:), but the shared helper takes no arguments. Refs #15488 Co-authored-by: Leo Li <cheerleaderleo@outlook.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 505f346)
The same change as #16232 (7a51764), carried so this PR can restore main's cmuxTests build in one piece. #15381 made LastSurfaceClosePreferenceTests and WorkspaceCloseTabsContextMenuTests call drainMainQueue(timeout:), but the shared helper takes no arguments. Refs #15488 Co-authored-by: Leo Li <cheerleaderleo@outlook.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The same change as #16232 (7a51764), carried so this PR can restore main's cmuxTests build in one piece. #15381 made LastSurfaceClosePreferenceTests and WorkspaceCloseTabsContextMenuTests call drainMainQueue(timeout:), but the shared helper takes no arguments. Refs #15488 Co-authored-by: Leo Li <cheerleaderleo@outlook.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Closing in favour of #16245, which makes the same |
Tests added by #15381 call the shared
drainMainQueue(timeout:)helper, but the helper only accepted the no-argument form. The app-host test product therefore failed to compile at every timeout call site.Add an optional timeout parameter while preserving the existing one-second default. This keeps the tests' bounded main-queue spin behavior and restores compilation for all current callers.
Validation:
swiftc -parse cmuxTests/TabManagerUnitTests.swiftpython3 scripts/verify-local.py --only swift-syntax --swift-changed origin/maingit diff --checkSummary by cubic
Fixes test compilation by letting
drainMainQueue(timeout:)accept an optional timeout parameter while keeping the one-second default, so tests can bound their main-queue drain time.Written for commit 7a51764. Summary will update on new commits.