Repository navigation
test: use the transaction's json helper in the malformed cleanup fixture - #16194
Conversation
Inside sql.begin's callback TypeScript no longer narrows the module-level `sql` to non-null, so web-typecheck fails on main with TS18047 since #15423. The rows are written through `tx`, so encode them with `tx.json` as well. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
Merge receipt for
Labeled |
web-typecheck fails on main since #15423:
web/tests/vm-workflows.test.ts(6219,37): error TS18047: 'sql' is possibly 'null'. The call sits insidesql.begin(async (tx) => …), where TypeScript drops the earlier null narrowing of the module-levelsql. The inserts already go throughtx, so the fixture now encodes the JSON withtx.jsontoo.bunx tsc --noEmit -p webreports 0 errors.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes a web typecheck failure by switching the malformed cleanup fixture to use
tx.jsoninstead ofsql.jsoninsidesql.begin, where TypeScript no longer narrows the module-levelsql.Written for commit 762349b. Summary will update on new commits.