Repository navigation
fix: suppress socat stdout in _cmux_send to prevent OK leak - #1619
Conversation
The socat path in _cmux_send did not redirect stdout/stderr, causing the cmux socket's "OK" response to print to the user's terminal on every shell integration event (new tab, cd, precmd, preexec). The ncat path avoids this via --send-only, and the nc path already redirects to /dev/null. This aligns the socat path with both. Fixes manaflow-ai#1618 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@fvallenilla is attempting to deploy a commit to the Manaflow Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughBoth bash and zsh shell integration scripts add output redirection to the socat fallback path in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present. |
There was a problem hiding this comment.
No issues found across 2 files
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
…ow-ai#1619) The socat path in _cmux_send did not redirect stdout/stderr, causing the cmux socket's "OK" response to print to the user's terminal on every shell integration event (new tab, cd, precmd, preexec). The ncat path avoids this via --send-only, and the nc path already redirects to /dev/null. This aligns the socat path with both. Fixes manaflow-ai#1618 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
/dev/nullin_cmux_sendfor both zsh and bash shell integrationsncatpath uses--send-onlyand thencpath already redirects — thesocatpath was the only one leaking the socket response to the terminalRoot cause
The cmux socket responds with
OKto every message.socatreads bidirectionally by default, so without output suppression it prints that response to stdout. On systems wherencatis absent butsocatis installed (common on macOS via Homebrew), this causes a spuriousOKto appear on every new tab, directory change, and shell prompt.Fixes #1618
Test plan
socatbut noncat, open a new terminal tab — noOKshould appearcd /tmp && cd -— noOKshould appearGenerated with Claude Code
Summary by cubic
Stop the cmux socket
OKfrom appearing in the terminal by redirectingsocatstdout/stderr to/dev/nullin_cmux_sendfor bothbashandzsh. This aligns thesocatpath withncat --send-only/ncand prevents strayOKon new tabs,cd, and prompts whenncatis missing.Written for commit aae07c2. Summary will update on new commits.
Summary by CodeRabbit