Skip to content

test: bound the footprint check by reads on both sides of the capture #16141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
austinywang merged 1 commit into from
Sep 30, 2026
Merged

test: bound the footprint check by reads on both sides of the capture #16141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions cmuxTests/CmuxTopSnapshotScopeTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,14 +271,18 @@ struct CmuxTopSnapshotScopeTests {

@Test func testSummaryPayloadIncludesPhysicalFootprintMemoryBytes() async throws {
let pid = Int(Darwin.getpid())
let expectedFootprintBytes = try #require(physicalFootprintBytes(for: pid), "proc_pid_rusage did not return physical footprint for current process")

// The capture samples this process between these two reads, while the app host keeps allocating.
let footprintBeforeCapture = try #require(physicalFootprintBytes(for: pid), "proc_pid_rusage did not return physical footprint for current process")
let snapshot = await CmuxTopProcessSnapshot.capture(includeProcessDetails: false)
let footprintAfterCapture = try #require(physicalFootprintBytes(for: pid), "proc_pid_rusage did not return physical footprint for current process")
let payload = snapshot.summaryPayload(for: [pid])
let memoryBytes = int64(payload["memory_bytes"])
let (lowest, highest) = (min(footprintBeforeCapture, footprintAfterCapture), max(footprintBeforeCapture, footprintAfterCapture))

#expect((memoryBytes) > (0))
#expect((abs(memoryBytes - expectedFootprintBytes)) <= (max(16 * 1024 * 1024, expectedFootprintBytes / 5)))
#expect(intArray(payload["memory_source_fallback_pids"]).isEmpty)
#expect((memoryBytes) >= (lowest - max(16 * 1024 * 1024, lowest / 5)))
#expect((memoryBytes) <= (highest + max(16 * 1024 * 1024, highest / 5)))
}

@Test func testSamplePayloadDescribesPhysicalFootprintFallbackSource() async {
Expand Down Expand Up @@ -887,11 +891,7 @@ while allocations:
// proc_pid_rusage imports as rusage_info_t *; callers pass the concrete
// rusage struct address cast to that opaque buffer type.
let buffer = baseAddress.assumingMemoryBound(to: rusage_info_t?.self)
return proc_pid_rusage(
pid_t(pid),
RUSAGE_INFO_V2,
buffer
)
return proc_pid_rusage(pid_t(pid), RUSAGE_INFO_V2, buffer)
}
guard result == 0 else { return nil }
return int64Clamped(info.ri_phys_footprint)
Expand Down
Loading