Skip to content

docs: add Kiro and Hermes to Feed matrix - #16106

Merged
teamleaderleo merged 1 commit into
manaflow-ai:mainfrom
nightcityblade:fix/issue-15679
Oct 1, 2026
Merged

teamleaderleo merged 1 commit into
manaflow-ai:mainfrom
nightcityblade:fix/issue-15679

Conversation

@nightcityblade

@nightcityblade nightcityblade commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The Feed support matrix claimed to be complete but omitted two registered integrations. It now lists Kiro CLI and Hermes Agent with their configuration paths and native Feed hook events.

Fixes #15679

Testing

  • git diff --check origin/main...HEAD
  • ./scripts/localize-changes --base origin/main (passed; 10 catalogs, 9 locales, no changed localization keys)
  • python3 scripts/verify-local.py --affected origin/main (passed the affected feature-flags check)
  • Compared both rows with CLI/CMUXCLI+AgentHookCatalog.swift on current main

Localization audit: the only changed user-facing surface is docs/feed.md. No UI, web message, or localization catalog keys changed, and the localization audit passed. A native build was not run because this is documentation-only.

Changelog

none

Demo Video

N/A — documentation-only change.

  • Video URL or attachment: N/A

Checklist

  • Behavior changes have added or updated tests, or Testing says why not
  • UI, settings, menu, schema, help-text or user-facing docs change: localization audited, and the result is stated above
  • New or changed v2 socket method allowlisted for cmux ssh: N/A — no socket changes
  • iOS connectivity, auth, lifecycle, workspace action, terminal I/O or mobile RPC contract change: N/A — no iOS changes
  • User-facing docs updated if needed
  • Reviewed with a subagent before merge (cmux-review), and all bot and human review comments resolved

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Adds Kiro CLI and Hermes Agent to the Feed support matrix in docs/feed.md, which previously omitted these registered integrations. Each new row lists the configuration path and native Feed hook events. Fixes #15679.

Written for commit 3366c06. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Documentation
    • Updated the supported-agent reference to include Hermes Agent and Kiro CLI, along with their configuration paths and Feed trigger events.
    • The reference now covers these agents alongside the existing supported-agent information.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 48be7f3d-54bc-44dc-b46e-aee32f19f722

📥 Commits

Reviewing files that changed from the base of the PR and between d916e5c and 3366c06.

📒 Files selected for processing (1)
  • docs/feed.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The Feed support table now lists Hermes Agent and Kiro CLI, their configuration paths, and their Feed trigger events.

Changes

Feed documentation

Layer / File(s) Summary
Update the agent support table
docs/feed.md
The table adds configuration paths and Feed trigger events for Hermes Agent and Kiro CLI.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other · Severity of issue fixed: Low

Suggested reviewers: austinywang

Merge Risk: ⚪ Minimal · up to 3366c

The Feed table now documents supported Hermes Agent and Kiro CLI integrations. No merge-blocking issue is indicated.

Architecture Summary

Architecture risk: 🔵 Low · up to 3366c

The change affects 1 system.

Changed systems: docs

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — docs (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in docs/feed.md: The hook integration table adds Hermes Agent, listing ~/.hermes/config.yaml or $HERMES_HOME/config.yaml and its four tool/approval events, and Kiro CLI, listing ~/.kiro/agents/cmux.json or $KIRO_HOME/agents/cmux.json and its preToolUse / postToolUse events. OpenCode, Cursor CLI, and Gemini entries remain in the table.

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Cmux Full Internationalization ❌ Error The PR adds two user-facing rows to docs/feed.md in English only. The file is exposed to users through the cmux docs CLI resource (docs/feed.md) and GitHub-rendered Markdown, so the operational-… Move the Feed matrix into a locale-aware rendered-docs source that uses next-intl or an equivalent locale source. Add accurate Hermes Agent and Kiro CLI entries for en, ja, zh-CN, zh-TW, ko, de, es, fr, it, da, pl, `…
✅ Passed checks (24 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main documentation change: adding Kiro and Hermes to the Feed matrix.
Description check ✅ Passed The description follows the required template and explains the problem, resulting documentation change, testing performed, localization audit, changelog, demo status, and checklist state. The subagent…
Linked Issues check ✅ Passed Issue #15679 requires docs/feed.md to include Kiro CLI and Hermes Agent in the complete Feed support matrix. The diff adds both rows, including their configuration paths and native Feed hook events.…
Out of Scope Changes check ✅ Passed The pull request changes only the Feed support table in docs/feed.md. Both added rows directly address issue #15679. No unrelated source, runtime, or localization changes appear in the reviewed diff…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Cmux Cloud Persistent Session And Early Input ✅ Passed PASS — The pull request changes only docs/feed.md, adding two documentation rows. It does not change Cloud terminal creation, transport, renderer admission, input routing, authentication, idempotenc…
Cmux Swift Actor Isolation ✅ Passed PASS: The pull request changes only docs/feed.md and adds two documentation table rows. The authoritative diff contains no Swift files or production code changes, so it cannot introduce or worsen Sw…
Cmux Swift Blocking Runtime ✅ Passed The scoped pull-request diff changes only docs/feed.md with two documentation rows. It changes no Swift files and introduces no semaphores, blocking waits, sleeps, delayed dispatch, polling, main-qu…
Cmux Browser Automation Off-Main ✅ Passed PASS — The pull request changes only docs/feed.md, adding two documentation table rows. It does not change browser socket commands, TerminalController.swift, execution policy, worker routing, WebK…
Cmux Expensive Synchronous Load ✅ Passed PASS: The pull request changes only docs/feed.md. The diff adds two documentation table rows and changes no Swift files or runtime call sites. It does not add or move an expensive synchronous agent-…
Cmux Cache Substitution Correctness ✅ Passed The pull request changes only docs/feed.md. The diff adds two documentation table rows and contains no production Swift, TypeScript, or JavaScript changes. Therefore, the cache substitution correctn…
Cmux No Hacky Sleeps ✅ Passed PASS: The pull request changes only docs/feed.md, adding two documentation rows. It introduces no TypeScript, JavaScript, shell, or build/runtime code, and it adds no sleeps, timers, polling, or wal…
Cmux Algorithmic Complexity ✅ Passed PASS: The authoritative PR diff changes only docs/feed.md. It adds two Markdown table rows and changes no production Swift, TypeScript, JavaScript, shell, or runtime code. The algorithmic-complexity…
Cmux Swift Concurrency ✅ Passed The pull request changes only docs/feed.md. It adds two documentation rows and changes no Swift files or Swift concurrency patterns. The custom check does not apply.
Cmux Swift @Concurrent ✅ Passed PASS: The pull request changes only docs/feed.md; the authoritative diff contains no Swift files, async functions, call sites, or concurrency annotations. The cmux Swift @concurrent check is there…
Cmux Swift Package Boundaries ✅ Passed PASS: The authoritative PR diff changes only docs/feed.md. It adds two documentation rows and contains no Swift files or production Swift code changes, so the Swift package-boundary check is not app…
Cmux Swiftpm Lockfiles ✅ Passed PASS: The reviewed range changes only docs/feed.md with two documentation rows. It contains no Package.swift, Package.resolved, .gitignore, workflow, Xcode project, or dependency changes, so t…
Cmux Swift Logging ✅ Passed PASS — The pull request changes only docs/feed.md. The diff adds two Markdown table rows and does not add or modify Swift logging, runtime code, diagnostics, or secrets handling. The Swift logging c…
Cmux User-Facing Error Privacy ✅ Passed PASS: The authoritative PR diff changes only docs/feed.md and adds two support-matrix rows for Hermes Agent and Kiro CLI. These are documentation entries, not user-facing errors, alerts, command out…
Cmux Swiftui State Layout ✅ Passed PASS: The review-scoped diff changes only docs/feed.md with two documentation rows. It contains no Swift or SwiftUI changes, so the SwiftUI state-layout failure conditions do not apply.
Cmux Architecture Rethink ✅ Passed The pull request changes only docs/feed.md. It adds two documentation rows and changes no Swift files or runtime architecture. The architectural-rethink failure conditions are not applicable.
Cmux Swift Auxiliary Window Close Shortcuts ✅ Passed PASS: The pull request changes only docs/feed.md (+2 rows). The authoritative diff contains no Swift changes and no NSWindow, NSPanel, NSWindowController, SwiftUI Window, or WindowGroup co…
Cmux Source Artifacts ✅ Passed The PR changes only docs/feed.md. The patch adds two hand-written documentation table rows and does not add logs, caches, build output, scratch directories, copied artifacts, or other source-control…
Cmux No Test Or Debug Seam In Production Source ✅ Passed The pull request changes only docs/feed.md (+2 lines). It changes no Swift file under a production Sources/ path, so it cannot introduce a test or debug seam in production source.
Full details: Cmux Full Internationalization

Explanation

The PR adds two user-facing rows to docs/feed.md in English only. The file is exposed to users through the cmux docs CLI resource (docs/feed.md) and GitHub-rendered Markdown, so the operational-doc exception does not apply. The diff adds no locale-specific source or entries in web/messages/, despite web/i18n/routing.ts defining 20 supported locales.

Resolution

Move the Feed matrix into a locale-aware rendered-docs source that uses next-intl or an equivalent locale source. Add accurate Hermes Agent and Kiro CLI entries for en, ja, zh-CN, zh-TW, ko, de, es, fr, it, da, pl, ru, bs, ar, no, pt-BR, th, tr, km, and uk in the matching web/messages/*.json files. Ensure each locale renders the new rows and avoid copied English or placeholder translations.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nightcityblade

nightcityblade commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor Author

recheck

I amended only the author/committer metadata of fabb612 to the GitHub-linked noreply address, producing 3366c06. The source tree and commit message are unchanged, so the documented validation results still apply.

@teamleaderleo

teamleaderleo commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Thanks @nightcityblade, this was good to merge. The Kiro and Hermes Feed entries match their documented hook paths and events, and CI was approved before merge :)

@teamleaderleo
teamleaderleo merged commit 877df6f into manaflow-ai:main Oct 1, 2026
37 checks passed
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Merge receipt for 3366c06811: every check was green at merge (8 verified; 15 skipped by policy). Full suite runs on main after merge.

rustybret pushed a commit to rustybret/bmux that referenced this pull request Oct 1, 2026
877df6f docs: add Kiro and Hermes to Feed matrix (manaflow-ai#16106)
b5aa76c Re-land Cloud machine stale status punctuation (manaflow-ai#16010)
4fdd903 Merge pull request manaflow-ai#15345 from manaflow-ai/fix-v2-startup-local-route-impl
73ae480 fix(cli): list browser JSON flags in help (manaflow-ai#16098)
2bb742d fix(agents): preserve HTML-like Codex auto-naming messages (manaflow-ai#15984)
0d1b8dd fix(web): restore the seats-follow-membership copy the dashboard port dropped (manaflow-ai#16265)
be10c64 fix: recover interrupted Cloud vm run creates (manaflow-ai#16221)
28742a8 docs: document agent session recovery command (manaflow-ai#16108)
bcaf5e4 test: resolve the temp root before comparing rerun xcconfig paths (manaflow-ai#16372)
86230a5 Add built-in custom sidebar templates (manaflow-ai#15931)
5ccac53 fix(session): discard persisted listening ports on restore (manaflow-ai#12436)
882b6fc fix(flags): extend the fourteen reviewBy dates that expire on 2026-10-02 (manaflow-ai#15922)
45914ae docs: document Kimi session restore (manaflow-ai#16107)
2f574d6 Treat aborted Codex turns as terminal monitor events
f59f37d Remove stale Cloud reorder indicator on cleanup
eba8488 Fix drag cleanup and message inbox fixture
0d2b312 Include CLI error type in CLI tests
5955b67 Include CLI error type in app target
94acff9 Repair stale macOS test compile references
0117647 Fix isolated test window geometry cleanup
4b7b837 Fix canonical identity and accent color compile errors
538aaf6 Normalize instance tags and fix browser restoration compile
2c33e92 Fix post-merge compile blockers
5ea8219 Merge remote-tracking branch 'origin/main' into fix-v2-startup-local-route-impl
825e0d3 Fail closed when release gate V2 origin is unset
c21b0a8 Publish warmup recovery and preserve workspace IDs
f66904b Allow full relay rollover soak to finish
2ca91b5 Harden forget cleanup and Codex iteration proof
b908dde Bound endpoint warmup retries and retry on foreground
859ca92 Retry endpoint warmup after transient failures
97e5a7f Cancel timed out endpoint warmup
c5caca7 Serialize snapshot encoding in persistence actor
c589ff8 Bound Codex workload log polling
40aa04e Harden startup identity cache and snapshot invalidation
f06f502 Use shared deadline scheduler for endpoint warmup
2fa7297 Validate combined host status before reuse
5386126 Scope paired Mac cache before reconnect reuse
a34c7ee Bound endpoint warmup timeout independently of cancellation
b834f86 Bound cached endpoint warmup and diagnostics
00959bf Revalidate scope after cached snapshot restore
1b444a0 Keep attach tickets in memory during retries
6985f9e Repair cached runtime reconciliation and warmup retries
08c8047 Make explicit snapshot deletion win races
4c78ecf Preserve v2 runtime ownership through auth and soak
b1f7a18 Await workspace snapshot removal
0583749 Move snapshot restore off the main actor
7ea8285 Persist workspace snapshots off the main actor
07f7c13 Bound snapshot maintenance and relay gate timing
6b68c8c Keep real usage terminals available for verification
2f5c012 Normalize hidden Mac snapshot identities
5c5388e Stabilize real usage release gate lifecycle
344cac1 fix: bound cached startup and redact snapshots
1ce9bc8 fix: preserve and prune cached workspace snapshots
1887e53 fix: close release gate workload hazards
27fba71 Merge main (0398322) into fix-v2-startup-local-route-impl
d9724bc test: compile the vm ready poll policy into cmuxCLITests
beadd57 test: drive hook state recovery through the bundled CLI
c3b97e1 Use shared queue drain helper after compile repair
a11fc3c test: restore cmuxTests compile on main
c5a9d15 Keep close tab test queue drain compatible with main
07b9624 Hit test the measured text line in inline link regression
6c9f137 Merge main (a66a8bb) into fix-v2-startup-local-route-impl
4cbdeea Measure inline link view before hit testing
82618ef Await actor epoch during cached warmup
59cbda2 Fix cached endpoint warmup self lifetime
a06061a Keep release gate on approved runner route
1c10a44 Leave staging gate outside protected environments
8c4cfb5 Use staging environment for staging release gates
1db5b80 Pin manual gate to an available trusted Mac
b934ccf Route manual gate through selected owned pool
9ecd5aa Allow trusted owned runner for manual gate
5afde77 Use supported hosted macOS label for manual gate
2359026 Allow hosted runner for manual Iroh acceptance gate
01b0f64 Make release-gate evidence durable and ordered
c7cb704 Bind real-use replay to the requested workspace
5bd6005 Require real Codex workload evidence
35c7723 Measure app-side foreground readiness
e52cb3e Recover backup pairing when only demo row is cached
849ed89 Harden v2 startup state and workspace targeting
02bb470 Bind iOS e2e checks to the Codex workspace
76178d0 Document complete iOS e2e driver contract
908e2ee Merge green main into v2 startup branch
185be6c Make iOS e2e driver open a workspace
45f19d0 Keep IROH gate independent of Ghostty helper fetches
5f67eea Allow full relay gate to publish its verdict
9574395 Measure release gate rows at UIKit visibility
f3928a3 fix: persist every complete workspace snapshot
c5cb772 fix: measure cached workspace rows before Iroh readiness
c84fb67 ci: install axe before iOS Iroh gate
451933a Retain foreground state during snapshot reconciliation
eb1aa35 Preserve local demo workspace ownership
14dc577 Upload real Iroh usage evidence
41659c1 Add real Codex and background coverage to Iroh gate
5696ef1 Close workspace snapshot scope races
cb9d421 Prevent stale workspace snapshots from resurfacing
4f7f4b5 Restore scoped workspace snapshots before paired Mac load
a93af42 Give real relay gate cleanup time
61a88a2 Fix workspace snapshot initializer ordering
8bc596e Verify relay renewal at its real lifetime
99ca1d8 Cache scoped workspace rows during v2 startup
5aeab39 Enforce sub-2.5-second workspace startup gate
4fe8ac5 Warm cached v2 state before auth bootstrap
bf90a77 fix mobile attach parsing with CLI diagnostics
f7db0fa Merge remote-tracking branch 'origin/main' into fix-v2-startup-local-route-impl
1a91f7c test: keep workspace creation override signatures current
db62464 test: pass remote workspace flag through overrides
241ba19 test: avoid asserting startup cache implementation details
1e87a6e fix simulator launch environment propagation
6a17189 fix: keep release gate on workspace list
fa8f1c1 fix: retry stored Mac after auth restore
2bbb2ef fix: remove merge artifact from mobile shell
0ba4041 Merge remote-tracking branch 'origin/main' into fix-v2-startup-local-route-impl
2b64a40 test: preserve simulator startup diagnostics in release gates
73bd646 fix: avoid speculative duplicate Iroh dials
814ebe7 perf: reuse hydrated pairing cache during startup
27c401b Revert "perf: publish startup workspace rows before pairing persistence"
c146010 perf: publish startup workspace rows before pairing persistence
582713d fix: drain parallel iroh preconnect task
b980721 perf: preconnect iroh before first authenticated request
a396428 fix: use v2 identity for combined host status
5901f7d test: preserve admitted identity in combined startup status
5c504e8 fix: match cached host status in combined workspace response
9fac2b6 perf: build combined host proof from live service
0cf1b27 perf: combine startup workspace and host status
1ece6fc test: persist onboarding before cached launch
6372c0c test: measure cached pairing release-gate startup
73bc8cf test: reject injected credentials during cached startup verification
792a561 Revert "perf: reuse hydrated pairing snapshot during startup"
c9a6b58 Revert "perf: start cached pairing dial during startup hydration"
93d0db5 Revert "fix: bind optional cached pairing row correctly"
12ef215 fix: bind optional cached pairing row correctly
16cd25d perf: start cached pairing dial during startup hydration
d8a9c75 perf: reuse hydrated pairing snapshot during startup
4f6f58b fix: dial cached route before startup backup refresh
7814fd2 test: prove startup dials during backup refresh

# Conflicts:
#	.github/workflows/iroh-release-gate.yml
@teamleaderleo

Copy link
Copy Markdown
Collaborator

Merged, thank you @nightcityblade! The Feed matrix now documents Kiro and Hermes session recovery for users :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs/feed.md omits Kiro and Hermes Agent despite registered Feed hooks

2 participants