Skip to content

ci: make owned-pool rescue side-lane sweeper-only - #16076

Merged
teamleaderleo merged 1 commit into
mainfrom
fix/ci-owned-pool-rescue-sweeper
Sep 30, 2026
Merged

teamleaderleo merged 1 commit into
mainfrom
fix/ci-owned-pool-rescue-sweeper

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

ci-owned-pool-rescue.yml received workflow_run events for 11 side-lane workflows even though those workflows have no picker and their trusted attempt-1 jobs already run on the fleet. Each event could start a separate rescue watch that saves no run. The incident report counted 429 rescue runs today, with 25 completed and 21 in progress, and the full watch budget is about 61 minutes.

Change

Side lanes are now sweeper-only. Their workflow_run entries and SOURCE_WORKFLOW_PATHS declarations are removed. The screenshots and nightly workflow triggers remain. Explicit workflow_dispatch watches and the side-lane target rules remain available for a named run.

The workflow test now asserts exactly the two retained workflow-run sources and verifies that no side-lane path is declared.

Verification

  • python3 tests/test_ci_owned_pool_rescue.py: 115 passed
  • python3 tests/test_ci_workflow_run_sources.py: passed, 120 workflows
  • actionlint .github/workflows/ci-owned-pool-rescue.yml: passed
  • git diff --check: passed

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Prevents ci-owned-pool-rescue from spawning a rescue watch for side-lane workflows, which have no picker and already run on the fleet. Side lanes now rely on the periodic sweeper: their workflow_run triggers and SOURCE_WORKFLOW_PATHS entries are removed, while screenshots and nightly triggers stay. Explicit workflow_dispatch watches and side-lane target rules remain for named runs.

Updates the workflow test to assert the two retained workflow-run sources and verify no side-lane path is declared.

Written for commit 556523d. Summary will update on new commits.

Review in cubic

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 8e3a8847-b322-43b4-9aab-90ed4b8f9ad0

📥 Commits

Reviewing files that changed from the base of the PR and between a24a1b5 and 556523d.

📒 Files selected for processing (2)
  • .github/workflows/ci-owned-pool-rescue.yml
  • tests/test_ci_owned_pool_rescue.py
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo
teamleaderleo enabled auto-merge (squash) September 30, 2026 15:51
@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@teamleaderleo
teamleaderleo merged commit 15996b0 into main Sep 30, 2026
55 of 56 checks passed
@teamleaderleo
teamleaderleo deleted the fix/ci-owned-pool-rescue-sweeper branch September 30, 2026 15:56
@github-actions

Copy link
Copy Markdown
Contributor

Merge receipt for 556523d4fd: every check was green at merge (10 verified; 13 skipped by policy). Full suite runs on main after merge.

rustybret pushed a commit to rustybret/bmux that referenced this pull request Sep 30, 2026
e709b69 fix(cloud): stop reconciling panes a Cloud workspace already shows (manaflow-ai#16025)
d13dde3 Diff viewer: viewed state, file filter, generated and large diffs collapsed (manaflow-ai#15536)
e0d5c5e test: pay the Pi fixtures' first exec before timing them (manaflow-ai#16028)
e2e0b61 ci: disable unstable UI test dispatch lane (manaflow-ai#16075)
15996b0 ci: sweep side lanes instead of rescuing workflow runs (manaflow-ai#16076)
3dcf462 Recover terminal chat when transcript files are replaced (manaflow-ai#16045)
272d069 fix(agent-chat): let Stop cancel a queued or starting ACP turn (manaflow-ai#15925)
30bd116 test: cover invalid unquoted Xcode extension paths (manaflow-ai#16054)
a24a1b5 Make GitHub references in the agent chat transcript clickable (manaflow-ai#15916)
86d1cfc Reap failed Codex app-server startups before retrying (manaflow-ai#15977)
890cd1e fix(sidebar): expose workspace close button to accessibility (manaflow-ai#15965)
faf4c8f docs: define agent fan-out and reusable Cloud work environments (manaflow-ai#15836)
ab20b79 ci: cut cmux-tui Testbox warmup hold time (manaflow-ai#15557)
31fb228 Promote devbox images with cmux-tui 7d17754 (VT replay blank-cell fix) (manaflow-ai#16072)
e0da0a6 feat(acp): cmux as a read-only ACP host, phase 1 (manaflow-ai#15976)
3ed1d77 Reap failed ACP startups and temporary catalog probes (manaflow-ai#15979)
f5c3567 Add a Focus TextBox Input item to the View menu (manaflow-ai#15730)
b3a1ca1 Document the 32 CLI verbs the contract table was missing, and guard it (manaflow-ai#15993)
3bba04e Say which app-host result file could not be read (manaflow-ai#15997)
7ef6d3a Resume Cloud Codex chats after app-server restart (manaflow-ai#15915)
a803f36 fix: surface simulator process output reader failures (manaflow-ai#15880)
f6a0163 Keep terminal approval notices from moving the composer (manaflow-ai#15886)
b8ab767 test: isolate feature flag defaults between runs (manaflow-ai#15587)
5150a9b Keep unsent cloud prompts recoverable (manaflow-ai#15902)
233bd6d Restore terminal attention when transcript chat reconnects (manaflow-ai#15891)
573f998 Resolve a dogfood menu path against the direct children of each open menu (manaflow-ai#15923)
7b7a1b2 test(ci): assert the registry guard's exit code, and handle merge_group (manaflow-ai#16017)

# Conflicts:
#	.github/workflows/ci-guards.yml
#	.github/workflows/ci-owned-pool-rescue.yml
#	.github/workflows/ci-ui-tests.yml
#	.github/workflows/ci.yml
#	.github/workflows/cmux-tui-testbox-warmup.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant