feat(cloud): show machine creator on sidebar rows

Sources/Cloud/CloudMachineCreatorLabel.swift

@@ -0,0 +1,22 @@
+import CmuxCloud
+import Foundation
+
+/// How a Cloud machine's author reads on its row.
+///
+/// Its own file, away from the row content, for a dull reason worth writing
+/// down: `scripts/localize-changes` cannot parse a `defaultValue` containing a
+/// `\u{...}` escape, and `CloudTreeMachineRowContent` has several. A new string
+/// added there is invisible to the tool, so it lives here where the tool can
+/// see it.
+struct CloudMachineCreatorLabel {
+    /// Nil when there is nothing worth showing: no author, or an author whose
+    /// name nobody has recorded. The account id is deliberately not a fallback.
+    /// A row reading "by 7f3a91c2" is the same unreadable list of generated
+    /// names this is meant to fix, with one more opaque token in it.
+    static func text(creator: VMCreator?) -> String? {
+        guard let name = creator?.displayName?.trimmingCharacters(in: .whitespacesAndNewlines),
+              !name.isEmpty
+        else { return nil }
+        return String(format: String(localized: "machines.row.createdBy", defaultValue: "by %@"), name)
+    }
+}

Sources/Cloud/CloudSidebarDebugLabWindow.swift

@@ -119,6 +119,11 @@ private struct CloudSidebarDebugControls: View {
                                 }
                             }
                             .labelsHidden()
+                            // `labelsHidden()` leaves the picker with nothing a
+                            // dogfood tour can aim at, so a tour could reach the
+                            // lab but never change preset. The presets are the
+                            // point of the lab.
+                            .accessibilityIdentifier("CloudSidebarDebugLab.preset")
                             Spacer(minLength: 0)
                             CloudSidebarDebugResetButton(
                                 title: String(localized: "debug.cloudSidebarSpacing.preset", defaultValue: "Preset"),
@@ -302,6 +307,10 @@ private enum CloudSidebarDebugFixture {
                 isDesktop: true,
                 activity: .ready,
                 createdAt: Date(timeIntervalSinceNow: -86_400 * 12),
+                // A name long enough to compete with the id and the age on the
+                // same line: the lab exists to show the crowded case, not the
+                // flattering one.
+                createdBy: VMCreator(userId: "debug-user-1", displayName: "Ada Lovelace"),
                 label: "production-hotfix-review-machine-with-a-deliberately-very-long-name",
                 slug: "patient-otter",
                 stats: VMStats(
@@ -316,6 +325,21 @@ private enum CloudSidebarDebugFixture {
                     diskTotalMb: 102_400,
                     diskUsedMb: 77_824
                 )
+            ),
+            // The row above truncates its subtitle inside the id, so the author
+            // never reaches the screen there. A short-id machine is what shows
+            // the change at all: one crowded row and one that fits, which is
+            // also the pair the design call needs to look at.
+            MachineSnapshot(
+                id: "vm-4f2a",
+                provider: "freestyle",
+                image: "cmux-debug-base-image",
+                isDesktop: false,
+                activity: .ready,
+                createdAt: Date(timeIntervalSinceNow: -7_200),
+                createdBy: VMCreator(userId: "debug-user-2", displayName: "Grace Hopper"),
+                label: "api-smoke-test",
+                slug: "brave-otter"
             )
         ]
     }

Sources/Cloud/CloudTreeMachineRowContent.swift

@@ -145,6 +145,11 @@ struct CloudTreeMachineRowContent: View {
             parts.append(machine.id)
         }
         parts.append(machine.kindLabel)
+        // Before the age, so "by Ada Lovelace · 3 hours ago" reads as one
+        // thought: who made it and when.
+        if let author = CloudMachineCreatorLabel.text(creator: machine.createdBy) {
+            parts.append(author)
+        }
         if let createdAt = machine.createdAt {
             // `now`, not `Date()`: every other part of this struct reads the
             // injected clock, so the age was the one value a test could not

cmux.xcodeproj/project.pbxproj

@@ -774,6 +774,7 @@
 		9EC6BCBA151ECA395FAFFFEC /* CloudLinkFailureMessageTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 78F253D557E6B9613AC4DB5C /* CloudLinkFailureMessageTests.swift */; };
 		8E7B97505657BF3E66091D9B /* CloudLinkRetryBackoffTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = FF5E22859B10B563032FECE7 /* CloudLinkRetryBackoffTests.swift */; };
 		7A0CE1000000000000000732 /* CloudLoopbackPortForwardTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7A0CE1000000000000000731 /* CloudLoopbackPortForwardTests.swift */; };
+		2CA3DFCD62CD4AECA4B8ABD1 /* CloudMachineCreatorLabel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 81D600EB49C54071A2CCBE62 /* CloudMachineCreatorLabel.swift */; };
 		A44FBE43FCD42CFEEB6EAF6F /* CloudMachineCreatorTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9E6CE8A534885E9CE99D3F84 /* CloudMachineCreatorTests.swift */; };
 		9E21585251BFCA0BAF06B10B /* CloudMachineDeleteOptimismTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 5DEADB23282C5C0D06630294 /* CloudMachineDeleteOptimismTests.swift */; };
 		A13086000000000000000002 /* CloudMachineDragSourceTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = A13086000000000000000001 /* CloudMachineDragSourceTests.swift */; };
@@ -5203,6 +5204,7 @@
 		78F253D557E6B9613AC4DB5C /* CloudLinkFailureMessageTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "CloudLinkFailureMessageTests.swift"; sourceTree = "<group>"; };
 		FF5E22859B10B563032FECE7 /* CloudLinkRetryBackoffTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "CloudLinkRetryBackoffTests.swift"; sourceTree = "<group>"; };
 		7A0CE1000000000000000731 /* CloudLoopbackPortForwardTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CloudLoopbackPortForwardTests.swift; sourceTree = "<group>"; };
+		81D600EB49C54071A2CCBE62 /* CloudMachineCreatorLabel.swift */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.swift; path = CloudMachineCreatorLabel.swift; sourceTree = "<group>"; };
 		9E6CE8A534885E9CE99D3F84 /* CloudMachineCreatorTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "CloudMachineCreatorTests.swift"; sourceTree = "<group>"; };
 		5DEADB23282C5C0D06630294 /* CloudMachineDeleteOptimismTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "CloudMachineDeleteOptimismTests.swift"; sourceTree = "<group>"; };
 		A13086000000000000000001 /* CloudMachineDragSourceTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CloudMachineDragSourceTests.swift; sourceTree = "<group>"; };
@@ -9347,6 +9349,7 @@
 				C621745E616B46C2A15DEBAA /* TerminalController+CloudSidebar.swift */,
 				967FB1138CEB42A88FD2B008 /* TerminalNotificationStore+CloudSidebar.swift */,
 				7C4E0550C4414C31B7893FDF /* CloudSidebarRowSnapshot.swift */,
+				81D600EB49C54071A2CCBE62 /* CloudMachineCreatorLabel.swift */,
 				FB09B103918144A9A420D765 /* CloudTreeMachineRowContent.swift */,
 				55995802F81B4EE8BCA5F4D4 /* CloudTreeLocalMachineRowContent.swift */,
 				2ACA3E3EF18BE12C7DF6A173 /* CloudTreeMachineResourceSection.swift */,
@@ -14290,6 +14293,7 @@
 				8057A5361378502071A49E66 /* CloudFilePreviewLease.swift in Sources */,
 				902ED2709F9B61E9E4B59A24 /* CloudGuestURLService.swift in Sources */,
 				124760000000000000000028 /* CloudImagePasteInputLease.swift in Sources */,
+				2CA3DFCD62CD4AECA4B8ABD1 /* CloudMachineCreatorLabel.swift in Sources */,
 				C6428DFF1BF84994BE7F09B1 /* CloudMachineLoadingReservation.swift in Sources */,
 				9725D4F54BA8B82A24941D3E /* CloudMachineMenuVerbs.swift in Sources */,
 				A1308600000000000000000A /* CloudMachineReorderDrop.swift in Sources */,

cmuxTests/CloudMachineCreatorTests.swift

@@ -149,4 +149,65 @@ struct CloudMachineCreatorTests {
         #expect(unnamedCreator["userId"] as? String == "user-b")
         #expect(unnamedCreator["displayName"] is NSNull)
     }
+
+    /// Every hop above carries the author and the sidebar still does not show
+    /// it, which is the whole complaint: on a team the fleet reads as a list of
+    /// generated three-word names with no way to tell whose is whose. The row's
+    /// second line already holds the machine's other identity facts (its id,
+    /// its kind, its age) and the tooltip repeats that line, so the author
+    /// belongs there rather than behind a new control.
+    @Test("the machine row says who made it")
+    func rowSubtitleNamesTheAuthor() {
+        let content = CloudTreeMachineRowContent(machine: Self.machine(
+            createdBy: VMCreator(userId: "user-a", displayName: "Ada Lovelace")
+        ))
+        #expect(content.subtitle.contains("by Ada Lovelace"))
+        // The tooltip is how a single-line row reaches the same facts, so the
+        // default preset must not be the one that hides the author.
+        #expect(content.toolTip.contains("by Ada Lovelace"))
+        // Still the machine's own line: the author is added to the identity
+        // facts, not put in place of them.
+        #expect(content.subtitle.contains("vm-1"))
+        #expect(content.subtitle.contains("Base"))
+    }
+
+    /// The two ways there is no name to show. A known account with no recorded
+    /// name is the interesting one: the account id is not a name, and a row
+    /// reading "by 7f3a91c2" is one more generated token in the pile this is
+    /// meant to clear, so the row says nothing rather than something opaque.
+    @Test("a machine with no named author says nothing about one")
+    func rowStaysQuietWithoutAName() {
+        let unnamed = CloudTreeMachineRowContent(machine: Self.machine(
+            createdBy: VMCreator(userId: "7f3a91c2", displayName: nil)
+        ))
+        #expect(unnamed.subtitle.contains("by ") == false)
+        #expect(unnamed.subtitle.contains("7f3a91c2") == false)
+
+        let anonymous = CloudTreeMachineRowContent(machine: Self.machine(createdBy: nil))
+        #expect(anonymous.subtitle.contains("by ") == false)
+        // The separator is not left dangling either way.
+        #expect(anonymous.subtitle.hasSuffix("·") == false)
+    }
+
+    @Test("a name of only whitespace is not a name")
+    func blankNameShowsNoAuthor() {
+        #expect(CloudMachineCreatorLabel.text(creator: VMCreator(userId: "u", displayName: "   ")) == nil)
+        #expect(CloudMachineCreatorLabel.text(creator: nil) == nil)
+        #expect(CloudMachineCreatorLabel.text(creator: VMCreator(userId: "u", displayName: "Ada")) == "by Ada")
+    }
+
+    /// Labelled, so the subtitle also carries the id, and old enough that the
+    /// relative age is a stable string rather than "in 0 seconds".
+    private static func machine(createdBy: VMCreator?) -> MachineSnapshot {
+        MachineSnapshot(
+            id: "vm-1",
+            provider: "fixture",
+            image: "devbox",
+            isDesktop: false,
+            activity: .ready,
+            createdAt: Date(timeIntervalSinceNow: -3 * 60 * 60),
+            createdBy: createdBy,
+            label: "build box"
+        )
+    }
 }

cmuxUITests/DogfoodScenarioUITests.swift

@@ -15,6 +15,8 @@ import Darwin
 ///
 /// A failing step is recorded and the tour continues, so one bad identifier
 /// still leaves every later screenshot; the test fails at the end listing them.
+/// Cloud sidebar evidence tours: `cloud-sidebar-audit-tour` and
+/// `cloud-machine-author-tour` in `dogfood/scenarios/`.
 final class DogfoodScenarioUITests: XCTestCase {
     private var socketPath = ""
     private var lastSocketError = "no attempt"

dogfood/scenarios/cloud-machine-author-tour.json

@@ -0,0 +1,67 @@
+{
+  "launch": {
+    "args": [
+      "-fileExplorer.isVisible",
+      "YES"
+    ]
+  },
+  "steps": [
+    {
+      "wait": 1.5
+    },
+    {
+      "click": "RightSidebarModeButton.machines"
+    },
+    {
+      "wait": 1.2
+    },
+    {
+      "shot": "10-right-sidebar-cloud"
+    },
+    {
+      "menu": [
+        "Help",
+        "Cloud Sidebar Spacing Lab…"
+      ]
+    },
+    {
+      "wait": 1.5
+    },
+    {
+      "shot": "20-lab-compact",
+      "screen": true
+    },
+    {
+      "tree": "20-lab-compact"
+    },
+    {
+      "click": "CloudSidebarDebugLab.preset"
+    },
+    {
+      "wait": 0.6
+    },
+    {
+      "tree": "21-preset-menu"
+    },
+    {
+      "key": "a"
+    },
+    {
+      "key": "return"
+    },
+    {
+      "wait": 1.2
+    },
+    {
+      "shot": "30-lab-aero",
+      "screen": true
+    },
+    {
+      "tree": "30-lab-aero"
+    }
+  ],
+  "paths": [
+    "Sources/Cloud/*",
+    "Packages/macOS/CmuxCloud/*"
+  ]
+}