Repository navigation
Start each app-host test process at the default window size #15985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
cat .github/review-bot-rules/no-test-debug-seam-in-production-source.md git diff 6d7ad149121a3034a63aa20be6f267380862924a 22a9d1ab2ee6acfc1399bf44f4c7d2738895ebc1 -- Sources/AppDelegate.swift rg -n 'forgetPersistedWindowGeometryForTestProcess' Sources cmuxTestsRepository: manaflow-ai/cmux
Length of output: 6210
🏁 Script executed:
Repository: manaflow-ai/cmux
Length of output: 41462
Isolate the XCTest geometry reset in a dedicated debug file.
The app-host startup call may require this debug facility in the app target, but that does not exempt it from the isolation rule. Move
forgetPersistedWindowGeometryForTestProcessout ofSources/AppDelegate.swiftand into a dedicated debug file or folder. Preserve the#if DEBUGstartup call.🤖 Prompt for AI Agents