docs(agent-chat): correct provider claims and pin ACP argv

[teamleaderleo]

Summary

Correct the agent-chat provider documentation and make the provider tests assert the argv behavior they are meant to protect.

• Put the Amp paragraph outside the numbered list and restore Amp to the native stream-JSON family. Amp's current docs show -x/--execute, --stream-json, and --stream-json-input: https://ampcode.com/docs/cli/streaming-json
• Clarify that Amp has no first-party ACP subcommand, while naming the third-party amp-acp bridge without recommending it.
• Keep cursor-agent with a comment grounded in Cursor's installer, which currently creates agent as primary and cursor-agent as a legacy symlink: https://cursor.com/install
• Document Cursor's cursor/ask_question, cursor/create_plan, and cursor_login capability gaps.
• Keep one read-only provider registry accessor, assert provider shape with toMatchObject, and pin cursor/goose/gemini ACP argv behavior. A synthetic provider test proves model arguments are appended when models is present.

Validation

• cd agent-chat && bun install && bun run check: 22 scripts and 11 Bun test files; 40 tests passed, 0 failed, 110 assertions.
• Focused provider command was red at 4a307204df0 with 3 passed and 1 failed because the command accessor was not exposed.
• The same focused command was green at 38648dcd009 with 4 passed and 0 failed.
• python3 scripts/verify-local.py: 15 of 15 applicable checks passed; no Swift files were selected, so native compilation and app launch were not run.
• ./scripts/localize-changes: 0 changed catalog or message keys; strict localization validation passed.
• GitHub Markdown rendering confirmed </ol> before the Amp paragraph.

Changelog

Changed: Correct agent provider family documentation and note Cursor ACP limitations.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

Next included review available in 3 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 2e7bae29-05cc-4110-ba99-c2e84a349a51

📥 Commits

Reviewing files that changed from the base of the PR and between 4da3bb3 and 38648dc.

📒 Files selected for processing (5)

• agent-chat/README.md
• agent-chat/adapters/acp.ts
• agent-chat/server.ts
• agent-chat/test/provider-registry.test.ts
• agent-chat/test/providers.test.ts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[teamleaderleo]

Review

Reviewed the two-commit diff from 0e44675036c through 38648dcd009. The README renders the Amp paragraph after </ol>, the Amp CLI and Cursor installer links are current, the provider registry has one read-only test accessor, and the tests exercise both no-model and model-appending ACP argv paths.

Fixed

• Restored Amp to the native stream-JSON family and clarified its ACP status and bridge.
• Added the Cursor installer rationale and both documented ACP capability gaps.
• Replaced registry-literal assertions with shape plus commandForSession behavior assertions.

Left

Nothing blocking. Local checks are green; hosted checks were still running when this receipt was posted.

[github-actions]

Merge receipt for 38648dcd00: every check was green at merge (12 verified; 16 skipped by policy). Full suite runs on main after merge.

[teamleaderleo]

Review: Checked the merged two-commit diff, the rendered Markdown structure, current Amp and Cursor source links, provider registry access, and focused plus full test output. Found no blocking issue.\n\nFixed: Restored Amp to the native stream-JSON family, clarified ACP bridge wording, documented Cursor ACP gaps, added the installer rationale, and pinned provider argv behavior.\n\nLeft: No implementation for Cursor question or authentication handling, because the requested scope was documentation and tests only.