fix(worktree-seed): budget each pattern and refuse dangling escapes

[teamleaderleo]

What this is

A follow-up to #15413 carrying two review findings that did not make the merge.

The two defects

WorktreeSeedPlanner.plan shared one directory-visit budget across the whole file. A greedy ** pattern could spend the budget, leaving later patterns with no walk and reporting them as unmatched. aPatternAfterABudgetExhaustingOneIsStillTried and aBudgetExhaustingPatternIsNotReportedAsMatchingNothing fail without the fix.

WorktreeSeedRepository.isInside resolved only the selected symlink, so dangling links and chained links whose targets were outside the repository could look safe. aDanglingSymlinkOutOfTheRepositoryIsAnEscape and the review-added aChainedSymlinkOutOfTheRepositoryIsAnEscape fail without the boundary fix; aDanglingSymlinkInsideTheRepositoryIsNotAnEscape verifies that missing targets under the repository remain allowed.

Red and green

The focused command is swift test in an extracted scratch package because CMUXAgentLaunch does not build on Linux. The test-only baseline ran 81 tests with three red test names: aPatternAfterABudgetExhaustingOneIsStillTried, aBudgetExhaustingPatternIsNotReportedAsMatchingNothing, and aDanglingSymlinkOutOfTheRepositoryIsAnEscape. The primary fix then ran 81 tests with 0 failures. The review repair added the chained-link regression, and the final run passed all 82 tests.

Test quality

The budget assertion now requires exactly 5 directory listings, the question-mark test reuses its existing repository local, the filename constant assertion was removed under the cmux-testing regression-and-quality rule against source-shape tests, and the blank/comment parser test now propagates errors instead of using try!.

Not in this PR

The review also asked for shadow-before-triage reordering, so a path inside a wholesale-selected directory would be reported as shadowed rather than excluded, refused, or already present. main now has aNegatedPositiveMatchInsideASelectedDirectoryIsStillIneffective, which asserts the current both-lists behavior on purpose. Changing that behavior is a design change, not a fix, so it is left for a separate proposal.

Changelog

none

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

Next included review available in 7 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 7c8fd739-faec-42f2-ab35-b1225d5edcda

📥 Commits

Reviewing files that changed from the base of the PR and between fc13b7c and 6fbc221.

📒 Files selected for processing (7)

• Packages/macOS/CMUXAgentLaunch/Sources/CMUXAgentLaunch/WorktreeSeed/WorktreeSeedPlan.swift
• Packages/macOS/CMUXAgentLaunch/Sources/CMUXAgentLaunch/WorktreeSeed/WorktreeSeedPlanner.swift
• Packages/macOS/CMUXAgentLaunch/Sources/CMUXAgentLaunch/WorktreeSeed/WorktreeSeedRepository.swift
• Packages/macOS/CMUXAgentLaunch/Tests/CMUXAgentLaunchTests/WorktreeSeedFileTests.swift
• Packages/macOS/CMUXAgentLaunch/Tests/CMUXAgentLaunchTests/WorktreeSeedPatternTests.swift
• Packages/macOS/CMUXAgentLaunch/Tests/CMUXAgentLaunchTests/WorktreeSeedPlannerTests.swift
• Packages/macOS/CMUXAgentLaunch/Tests/CMUXAgentLaunchTests/WorktreeSeedRepositoryTests.swift

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[github-actions]

Merge receipt for 6fbc221daa: every check was green at merge (23 verified; 21 skipped by policy). Full suite runs on main after merge.