Repository navigation
fix(workspace): restore DevTools UI when returning to workspace - #1584
BillionClaw wants to merge 1 commit into
Conversation
When switching workspaces with DevTools open, returning to the original workspace caused the DevTools panel to display blank. This happened because the DevTools restoration logic was not triggered when the browser portal became visible again after a workspace switch. Call restoreDeveloperToolsAfterAttachIfNeeded() when reconciling browser portal visibility for visible panels. This ensures DevTools is properly restored when a workspace with open DevTools becomes visible again. Fixes manaflow-ai#1494
|
@BillionClaw is attempting to deploy a commit to the Manaflow Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change adds a call to restore DevTools state within browser portal visibility handling in the Workspace module. When a browser panel becomes visible after workspace transitions, the DevTools UI restoration is invoked post-refresh and anchor operations, addressing the blank DevTools panel issue during workspace switches. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing per repository blocklist: maintainer threatened to ban. All submissions to this repo have been suspended. |
Summary
Fixed an issue where the DevTools panel would display blank after switching workspaces and returning to a workspace with DevTools open.
What changed:
restoreDeveloperToolsAfterAttachIfNeeded()inreconcileBrowserPortalVisibilityForCurrentRenderedLayout()when a browser panel becomes visibleWhy:
When switching workspaces, the browser portal is hidden via
hideAllBrowserPortalViews(). When returning to the workspace,reconcileBrowserPortalVisibilityForCurrentRenderedLayout()makes the portal visible again, but DevTools was not being restored, causing a blank panel.Testing
swift buildBrowserPanelViewcalls the same method during view updates)Checklist
Fixes #1494
Summary by cubic
Fix blank DevTools panel when returning to a workspace after switching. DevTools are restored when the browser portal becomes visible again.
restoreDeveloperToolsAfterAttachIfNeeded()inreconcileBrowserPortalVisibilityForCurrentRenderedLayout()when a browser panel becomes visible.Written for commit 529f7dc. Summary will update on new commits.
Summary by CodeRabbit