Repository navigation
feat: show image previews inside terminal panes - #15834
teamleaderleo wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CI failure attributionCI failed on
Not re-run automatically: Written by |
|
Migrated to upstream PR #15846 so the work and CI run directly in |
|
Superseded by upstream PR #15846. |
What changed
Image-only Cmd+V pastes now show a cmux-owned preview card inside the terminal pane before the paste is consumed. This keeps Codex and Claude Code's existing attachment behavior intact while making the image visible where the user is composing; other terminal harnesses get the same behavior automatically.
Clicking the card opens a larger popover preview. A close button dismisses it, the card follows the terminal input cursor during pane geometry changes, and accessibility labels are localized for all supported macOS locales.
This stacks on #14948 (
feat/image-paste-ctrl-v-agents), which provides the optional Codex/Claude Ctrl+V routing.Validation
git diff --checkpython3 scripts/localization_catalog.py check --root .Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Image-only Cmd+V pastes now show a preview card inside the terminal pane before the paste is consumed. Codex and Claude Code's existing attachment behavior is unchanged, and other terminal harnesses get this behavior automatically.
The card is an AppKit overlay rather than terminal output, so scrollback, selection, and the agent's
[Image #N]placeholder stay untouched. Clicking the card opens a larger popover preview, and a close button dismisses it. The card follows the terminal input cursor during pane geometry changes, and accessibility labels are localized for all supported macOS locales.This stacks on
#14948(feat/image-paste-ctrl-v-agents), which provides the optional Codex/Claude Ctrl+V routing.Written for commit fc17be7. Summary will update on new commits.