Skip to content

fix: keep window lifecycle events in History timeline - #15628

Merged
teamleaderleo merged 2 commits into
feat-history-sidebar-controlsfrom
feat/history-menu-open-pane
Oct 1, 2026
Merged

teamleaderleo merged 2 commits into
feat-history-sidebar-controlsfrom
feat/history-menu-open-pane

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The History stack records windowOpened and windowClosed lifecycle events with a window ID, but the default Timeline filtered them out because it only accepted events with a workspace ID. The workspace-first projection also did not match window IDs.

This stacked follow-up:

  • includes window-scoped events in the Timeline mode;
  • matches window IDs to the live workspace topology; and
  • adds a regression proving a window-close event appears on its workspace timeline.

It also exposes the History pane directly from the History menu, using the same right-sidebar focus route as the command palette.

Verification

  • swiftc -frontend -parse Sources/VaultHistoryTimelineModel.swift Sources/VaultHistoryWorkspaceTimelineProjection.swift cmuxTests/VaultHistoryGroupingTests.swift
  • git diff --check

The full repository verification lane is not available on this historical PR branch because its newer scripts/verify-local.py and localization tooling are absent; the changed Swift files parse successfully.

Changelog

  • Fixed: Keep window lifecycle events visible in the History Timeline.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes the History timeline so window lifecycle events (open/close) stay visible and appear on their workspace's timeline instead of being filtered out.

  • Includes window-scoped events in Timeline mode and matches window IDs to the live workspace topology.
  • Adds a regression test proving a window-close event shows up on its workspace timeline.
  • Adds an "Open History as Pane" button to the History menu that focuses the right sidebar pane, same as the command palette.

Written for commit c182ed0. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 2eaaf6d9-8ba8-4be8-9db9-2f6cbc010c3d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 29, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

@austinywang this is the small stacked follow-up for the History work in #9131/#9148. It keeps window lifecycle events visible in the Timeline and adds the direct History-menu entry. The parent PRs should land before this one; happy to rebase or adjust once you decide the merge order.

@teamleaderleo teamleaderleo reopened this Sep 30, 2026
@teamleaderleo
teamleaderleo merged commit b25d19a into feat-history-sidebar-controls Oct 1, 2026
6 checks passed
@teamleaderleo
teamleaderleo deleted the feat/history-menu-open-pane branch October 1, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant