fix: keep window lifecycle events in History timeline - #15628
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
@austinywang this is the small stacked follow-up for the History work in #9131/#9148. It keeps window lifecycle events visible in the Timeline and adds the direct History-menu entry. The parent PRs should land before this one; happy to rebase or adjust once you decide the merge order. |
Summary
The History stack records
windowOpenedandwindowClosedlifecycle events with a window ID, but the default Timeline filtered them out because it only accepted events with a workspace ID. The workspace-first projection also did not match window IDs.This stacked follow-up:
It also exposes the History pane directly from the History menu, using the same right-sidebar focus route as the command palette.
Verification
swiftc -frontend -parse Sources/VaultHistoryTimelineModel.swift Sources/VaultHistoryWorkspaceTimelineProjection.swift cmuxTests/VaultHistoryGroupingTests.swiftgit diff --checkThe full repository verification lane is not available on this historical PR branch because its newer
scripts/verify-local.pyand localization tooling are absent; the changed Swift files parse successfully.Changelog
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes the History timeline so window lifecycle events (open/close) stay visible and appear on their workspace's timeline instead of being filtered out.
Written for commit c182ed0. Summary will update on new commits.