Skip to content

ci: preserve owned routing during Blacksmith outage - #15614

Merged
teamleaderleo merged 1 commit into
ci/pickers-account-capacityfrom
ci/cloud-overflow-picker-rescue
Sep 29, 2026
Merged

teamleaderleo merged 1 commit into
ci/pickers-account-capacityfrom
ci/cloud-overflow-picker-rescue

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

What changed

When CI_CLOUD_OVERFLOW_SAVED records an active Blacksmith outage, the PR picker now:

  • accepts the switched MACOS_RUNNER_PR value;
  • preserves owned split, root, GUI, and warm placement;
  • removes Blacksmith labels from the candidate order;
  • leaves retry_runner empty so retries stay on the owned route.

The owned-pool rescue watcher pauses while the record exists, avoiding a cancellation that would re-run work onto the dead Blacksmith pool. Normal picker and rescue behavior resumes when the record is removed and the runner variables are restored.

Validation

  • New picker outage and wiring tests pass.
  • New rescue pause and workflow wiring tests pass.
  • Python compilation and YAML parsing pass.
  • git diff --check passes.

This is a dependent PR for #15609 and intentionally contains only the outage integration.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Keeps the PR picker and owned-pool rescue on owned runners during a Blacksmith outage so work doesn't re-run onto a dead pool.

  • When CI_CLOUD_OVERFLOW_SAVED records an active Blacksmith outage, the picker accepts the switched MACOS_RUNNER_PR value, preserves owned split, root, GUI, and warm placement, removes Blacksmith labels from the candidate order, and leaves retry_runner empty.
  • The owned-pool rescue pauses while the record exists, avoiding a cancellation that would re-run work onto Blacksmith.
  • Picker and rescue behavior resumes normally once the record is removed.

Validation

  • New picker, rescue pause, and workflow wiring tests pass.
  • Python compilation and YAML parsing pass; git diff --check passes.

Written for commit 38fbea5. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ce84a4b5-86fd-4333-abef-7909853e6de7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo
teamleaderleo merged commit 559cfe6 into ci/pickers-account-capacity Sep 29, 2026
16 of 17 checks passed
@teamleaderleo
teamleaderleo deleted the ci/cloud-overflow-picker-rescue branch September 29, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant