Skip to content

fix(ci): classify SDK-less Xcode pin failures - #15605

Merged
teamleaderleo merged 1 commit into
mainfrom
fix/xcode-pin-machine-signatures
Sep 29, 2026
Merged

teamleaderleo merged 1 commit into
mainfrom
fix/xcode-pin-machine-signatures

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The merged Xcode pin handling classifies missing pin paths as machine failures, but the focused-test redispatch helper still missed two equivalent selector errors: an installed Xcode with no usable SDK and the legacy pool-pin message. SDK-less selector errors also omitted the installed-Xcode inventory needed to diagnose the host.

Change

  • classify SDK-less and legacy pool-pin selector failures as machine failures in machine_failure.py;
  • include the installed Xcode inventory in both SDK-less selector annotations;
  • add focused regression coverage for both paths.

The first PR (#15598) already added the runtime marker and classifier used by the main CI attribution path. This follow-up keeps the focused redispatch and selector diagnostics consistent with it.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Classifies SDK-less and legacy pool-pin Xcode selection failures as machine failures, and reports the installed Xcode inventory in the SDK-less error messages for easier host diagnosis.

  • Adds the two missing error patterns to the machine_failure.py classifier.
  • Includes the installed Xcode list in both SDK-less error messages.
  • Adds regression coverage for both failure paths in the fast-path and classifier tests.

Written for commit 7ff76c0. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 30637720-df3e-446f-86df-b41d2f09cdb0

📥 Commits

Reviewing files that changed from the base of the PR and between 551a923 and 7ff76c0.

📒 Files selected for processing (4)
  • scripts/ci/machine_failure.py
  • scripts/select-ci-xcode.sh
  • tests/test_ci_machine_failure.py
  • tests/test_ci_xcode_selection_fast_path.sh
 _________________________________________
< Make it work, make it right, make it 🥕. >
 -----------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

github-actions Bot added a commit that referenced this pull request Sep 29, 2026
github-actions Bot added a commit that referenced this pull request Sep 29, 2026
github-actions Bot added a commit that referenced this pull request Sep 29, 2026
github-actions Bot added a commit that referenced this pull request Sep 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Dogfood tours of 7ff76c04

sidebar-and-chrome-tour at 7ff76c04: passed (run)

sidebar-and-chrome-tour at 7ff76c04

Key frames of sidebar-and-chrome-tour at 7ff76c0 04-three-workspaces 10-split-right 15-command-palette 24-settings

Tours are picked by the paths globs in dogfood/scenarios/*.json; a Dogfood-tours: a, b line in the description picks them instead (none turns this off). Look at every frame before merging: a green tour only means no step failed.

github-actions Bot added a commit that referenced this pull request Sep 29, 2026
github-actions Bot added a commit that referenced this pull request Sep 29, 2026
@teamleaderleo
teamleaderleo marked this pull request as ready for review September 29, 2026 14:17
@teamleaderleo
teamleaderleo enabled auto-merge (squash) September 29, 2026 14:17
@teamleaderleo
teamleaderleo merged commit 39d4a47 into main Sep 29, 2026
89 of 90 checks passed
@teamleaderleo
teamleaderleo deleted the fix/xcode-pin-machine-signatures branch September 29, 2026 14:19
@github-actions

Copy link
Copy Markdown
Contributor

Merge receipt for 7ff76c048f: every check was green at merge (25 verified; 25 skipped by policy). Full suite runs on main after merge.

rustybret pushed a commit to rustybret/bmux that referenced this pull request Sep 29, 2026
c7fea92 Fix Codex monitor recovery during transient owner loss (manaflow-ai#15612)
c48b690 fix: settle Claude Stop reentry after hook block (manaflow-ai#15603)
39d4a47 fix(ci): classify all missing Xcode pin failures (manaflow-ai#15605)
c0538b5 test: isolate mobile lifecycle registry from live host (manaflow-ai#15566)
c9ced10 test: remove flaky shell startup timing assertion (manaflow-ai#15589)
4de2a66 test: isolate mirror topology fixtures from window docks (manaflow-ai#15573)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant