Repository navigation
ci: route hardcoded Blacksmith labels through the runner variables - #15592
Merged
Merged
Conversation
Eleven Linux jobs (cmux-tui, cmux-cloud-cli, ios-e2e route/backend) and two iOS E2E macOS lanes named a Blacksmith label with no variable, so pointing LINUX_RUNNER / MACOS_RUNNER_* elsewhere during a Blacksmith outage could not move them. They now read the same variables as every other job, with the standard fork pull-request branch first. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
teamleaderleo
enabled auto-merge (squash)
September 29, 2026 12:27
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Merge receipt for
|
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 29, 2026
6093e59 test(cloud-vm): cover missing attach address b639b65 fix(iroh-v2): omit bearer device attribution c9a74d6 ci: E2E picker routes owned labels by the online runners, not CI_OWNED_POOL_SLOTS (manaflow-ai#15582) 194ae87 fix(tests): compile cmuxTests again after manaflow-ai#15116 and manaflow-ai#15550 (manaflow-ai#15561) 8bfc872 ci: live runners decide root, gui and side routing; CI_OWNED_POOL_SLOTS is the fallback only (manaflow-ai#15572) 1516426 ci: route hardcoded Blacksmith labels through the runner variables (manaflow-ai#15592) # Conflicts: # .github/workflows/cmux-cloud-cli.yml # .github/workflows/cmux-tui.yml # .github/workflows/ios-e2e.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several jobs hardcoded a Blacksmith label with no variable. During the 2026-09-29 Blacksmith stall, pointing
LINUX_RUNNER/MACOS_RUNNER_*at GitHub-hosted runners or the owned minis couldn't move them, and reruns stayed queued on the dead pool. Affected: iOS E2E'sroutejob and 10 other Linux jobs acrosscmux-tui,cmux-cloud-cliandios-e2e, plus two iOS E2E macOS lanes.These jobs now read the same variables as every other job. Each one checks the standard fork-PR branch first, so fork code never follows a variable onto a self-hosted runner (
test_ci_fork_runner_routing). When the variables are unset, behaviour is unchanged. This PR is needed before a single overflow switch can move every job.Testing:
scripts/verify-local.py --allpasses 15/15. These pass:test_ci_fork_runner_routing,test_ci_linux_guard_routing,test_runner_label_policy,test_ci_workflow_guards_are_wired.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Routes the hardcoded Blacksmith runner labels through
LINUX_RUNNERandMACOS_RUNNER_*so those jobs can switch pools during a Blacksmith outage.Bug Fixes
cmux-tui,cmux-cloud-cli, andios-e2ehardcoded a Blacksmith label, so pointing the runner variables at alternatives couldn't move them when the pool stalled on 2026-09-29.Written for commit 28e2875. Summary will update on new commits.
Summary by CodeRabbit