iOS e2e gate: terminal driver, two-machine workflow draft, and four connectivity-gate fixes

Packages/Shared/CmuxIrxTransport/Sources/CmuxIrxTransport/IrxConnection.swift

@@ -391,7 +391,7 @@ public actor IrxConnection {
     /// is the relay URL for relayed paths and the socket address otherwise.
     public nonisolated func selectedPath() -> (isRelay: Bool, remoteAddress: String)? {
         let paths = connection.paths()
-        guard let selected = paths.first(where: { $0.isSelected }) else {
+        guard let selected = paths.first(where: { $0.isSelected }) ?? paths.first else {
             return nil
         }
         return (selected.isRelay, "\(selected.remoteAddr)")

Packages/iOS/CmuxMobileShellUI/Sources/CmuxMobileShellUI/MobileWhatsNewCenter.swift

@@ -28,15 +28,6 @@ public final class MobileWhatsNewCenter {
 
     static let markerKey = "dev.cmux.mobile.whatsNew.newestAcknowledgedEntryId"
 
-    #if DEBUG
-    /// `CMUX_UITEST_SUPPRESS_WHATS_NEW=1` (environment or launch argument)
-    /// keeps the launch sheet away during automated Debug runs. Debug-only,
-    /// mirroring the other `CMUX_UITEST_*` hooks in `UITestConfig`.
-    static var suppressedForAutomation: Bool {
-        ProcessInfo.processInfo.environment["CMUX_UITEST_SUPPRESS_WHATS_NEW"] == "1"
-            || ProcessInfo.processInfo.arguments.contains("CMUX_UITEST_SUPPRESS_WHATS_NEW=1")
-    }
-    #endif
     static let acknowledgedAnnouncementsKey = "dev.cmux.mobile.whatsNew.acknowledgedAnnouncementIds"
     static let cacheKey = "dev.cmux.mobile.whatsNew.remoteList.v1"
     static let requestPath = "/api/whats-new"
@@ -230,14 +221,6 @@ public final class MobileWhatsNewCenter {
     /// advances past a page that was skipped this way unless a newer binary
     /// page was acknowledged above it).
     var unseenPages: [MobileWhatsNewPage] {
-        #if DEBUG
-        // Automated drivers (the Iroh release gate, the iOS e2e gate) run a
-        // fresh install every time, so the launch sheet would cover the
-        // workspace UI and block their readiness probes. The knob suppresses
-        // presentation only; markers are untouched, so a normal launch of the
-        // same container still shows the pages.
-        if Self.suppressedForAutomation { return [] }
-        #endif
         let acknowledged = acknowledgedAnnouncementIDs
         let unseenAnnouncements = announcementPages.filter { !acknowledged.contains($0.id) }
         let visible = visibleBinaryEntries
@@ -337,4 +320,3 @@ public final class MobileWhatsNewCenter {
 
 }
 #endif
-

Packages/iOS/CmuxMobileShellUI/Sources/CmuxMobileShellUI/MobileWhatsNewPresentationPolicy.swift

@@ -0,0 +1,26 @@
+import SwiftUI
+
+/// Composition-level policy for the one-time What's New launch sheet.
+///
+/// Debug automation can suppress the launch presentation while keeping the
+/// catalog and acknowledgement state intact. The policy is supplied by the
+/// app composition root so the catalog model remains independent of process
+/// environment variables.
+public struct MobileWhatsNewPresentationPolicy: Sendable {
+    public var suppressLaunchPresentation: Bool
+
+    public init(suppressLaunchPresentation: Bool = false) {
+        self.suppressLaunchPresentation = suppressLaunchPresentation
+    }
+}
+
+private struct MobileWhatsNewPresentationPolicyKey: EnvironmentKey {
+    static let defaultValue = MobileWhatsNewPresentationPolicy()
+}
+
+public extension EnvironmentValues {
+    var mobileWhatsNewPresentationPolicy: MobileWhatsNewPresentationPolicy {
+        get { self[MobileWhatsNewPresentationPolicyKey.self] }
+        set { self[MobileWhatsNewPresentationPolicyKey.self] = newValue }
+    }
+}

Packages/iOS/CmuxMobileShellUI/Sources/CmuxMobileShellUI/WorkspaceShellView.swift

@@ -229,6 +229,7 @@ struct WorkspaceShellView: View {
     /// sheet presents, so remote list changes mid-presentation cannot mutate
     /// an open sheet.
     @Environment(MobileWhatsNewCenter.self) private var whatsNewCenter: MobileWhatsNewCenter?
+    @Environment(\.mobileWhatsNewPresentationPolicy) private var whatsNewPresentationPolicy
     @Environment(\.mobileWebAppSession) private var whatsNewWebAppSession
     @Environment(\.colorScheme) private var whatsNewColorScheme
     @State private var whatsNewSheetPages: [MobileWhatsNewPage] = []
@@ -699,7 +700,8 @@ struct WorkspaceShellView: View {
     /// sheet already occupying the presenter) never marks pages as seen.
     private func presentWhatsNewIfNeeded() {
         guard let whatsNewCenter, whatsNewCenter.hasCompletedInitialRefresh,
-              !showsWhatsNewSheet else { return }
+              !showsWhatsNewSheet,
+              !whatsNewPresentationPolicy.suppressLaunchPresentation else { return }
         let pages = whatsNewCenter.unseenPages
         guard !pages.isEmpty else { return }
         whatsNewCandidatePages = pages

Packages/iOS/CmuxMobileSupport/Sources/CmuxMobileSupport/UITestConfig.swift

@@ -157,6 +157,30 @@ public struct UITestConfig {
         #endif
     }
 
+    /// Suppresses the one-time What's New launch sheet for automated Debug
+    /// launches. The app composition root converts this input into an explicit
+    /// presentation policy; the catalog model does not read process state.
+    public static var suppressWhatsNewLaunch: Bool {
+        suppressWhatsNewLaunch(
+            from: ProcessInfo.processInfo.environment,
+            arguments: ProcessInfo.processInfo.arguments
+        )
+    }
+
+    /// Resolves the What's New launch suppression flag from explicit process
+    /// inputs so the Debug composition policy remains testable.
+    public static func suppressWhatsNewLaunch(
+        from env: [String: String],
+        arguments: [String] = []
+    ) -> Bool {
+        #if DEBUG
+        return env["CMUX_UITEST_SUPPRESS_WHATS_NEW"] == "1"
+            || arguments.contains("CMUX_UITEST_SUPPRESS_WHATS_NEW=1")
+        #else
+        return false
+        #endif
+    }
+
     /// Whether the full-app UI-test harness should treat the account-owned
     /// revoke step of Forget Computer as successful. The remaining operation,
     /// including durable paired-Mac deletion, store refresh, shell routing, and

Packages/iOS/CmuxMobileSupport/Tests/CmuxMobileSupportTests/UITestConfigTests.swift

@@ -61,6 +61,47 @@ import Testing
         #expect(UITestConfig.value(for: "CMUX_UITEST_ADD_DEVICE_HOST", env: env) == nil)
     }
 
+    @Test func whatsNewLaunchSuppressionUsesEnvironmentOrArgument() {
+        #if DEBUG
+        #expect(
+            UITestConfig.suppressWhatsNewLaunch(
+                from: ["CMUX_UITEST_SUPPRESS_WHATS_NEW": "1"]
+            )
+        )
+        #expect(
+            UITestConfig.suppressWhatsNewLaunch(
+                from: [:],
+                arguments: ["CMUX_UITEST_SUPPRESS_WHATS_NEW=1"]
+            )
+        )
+        #expect(
+            UITestConfig.suppressWhatsNewLaunch(
+                from: ["CMUX_UITEST_SUPPRESS_WHATS_NEW": "0"],
+                arguments: ["CMUX_UITEST_SUPPRESS_WHATS_NEW=1"]
+            )
+        )
+        #else
+        #expect(
+            UITestConfig.suppressWhatsNewLaunch(
+                from: ["CMUX_UITEST_SUPPRESS_WHATS_NEW": "1"]
+            ) == false
+        )
+        #endif
+        #expect(UITestConfig.suppressWhatsNewLaunch(from: [:]) == false)
+        #expect(
+            UITestConfig.suppressWhatsNewLaunch(
+                from: ["CMUX_UITEST_SUPPRESS_WHATS_NEW": "0"],
+                arguments: ["CMUX_UITEST_SUPPRESS_WHATS_NEW=0"]
+            ) == false
+        )
+        #expect(
+            UITestConfig.suppressWhatsNewLaunch(
+                from: ["CMUX_UITEST_SUPPRESS_WHATS_NEW": "true"],
+                arguments: ["CMUX_UITEST_SUPPRESS_WHATS_NEW=10"]
+            ) == false
+        )
+    }
+
     #if DEBUG
     @Test(arguments: ["eligible", "ineligible"])
     func autoConnectMigrationFixtureRequiresMockDataAndParsesEligibility(_ raw: String) {