Skip to content

fix(localization): remove duplicate Claude stop strings - #15416

Closed
teamleaderleo wants to merge 1 commit into
manaflow-ai:mainfrom
teamleaderleo:fix/xcstrings-stopfailure-duplicates
Closed

teamleaderleo wants to merge 1 commit into
manaflow-ai:mainfrom
teamleaderleo:fix/xcstrings-stopfailure-duplicates

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Remove the second, byte-identical copy of ten agent.claude.stopFailure.* entries from Resources/Localizable.xcstrings. Current main contains both copies, so test_localizable_xcstrings_structure.py fails on PR merge refs even when a PR does not touch localization.

Evidence

Before: PR #15411 run 36448920976 failed test_keys_are_unique with these ten keys.

After:

  • python3 tests/test_localizable_xcstrings_structure.py — 3/3 passed
  • python3 tests/test_lint_xcstrings.py — 4/4 passed
  • duplicate values were byte-for-byte identical; all nine locales and %@ placeholder coverage are preserved
  • independent review found no findings

No app build or native test was run on Air Blue.

— Mochi


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Removes the duplicate copies of ten agent.claude.stopFailure.* entries from Resources/Localizable.xcstrings. Both copies were byte-identical, so removing the second copy fixes the test_keys_are_unique failure in test_localizable_xcstrings_structure.py for PR merge refs without changing any localization content.

Written for commit bcd2525. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Localization
    • Removed localized Claude stop-failure messages and status text across supported languages.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 57432529-1e35-4edc-b42c-c4cb7555a67e

📥 Commits

Reviewing files that changed from the base of the PR and between 9eb402d and bcd2525.

📒 Files selected for processing (1)
  • Resources/Localizable.xcstrings
💤 Files with no reviewable changes (1)
  • Resources/Localizable.xcstrings

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The localization catalog no longer contains Claude stop-failure messages and status strings in English, Japanese, Simplified and Traditional Chinese, German, French, Arabic, Spanish, and Korean.

Changes

Claude stop-failure localization

Layer / File(s) Summary
Remove stop-failure strings
Resources/Localizable.xcstrings
Removed the generic failure message and status strings for API errors, authentication, billing, dropped connections, output limits, overload, rate limits, and usage limits across nine locales.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to bcd25

The duplicate strings are removed without losing the stop-failure translations. No actionable merge risk remains after normal checks.

🚥 Pre-merge checks | ✅ 25
✅ Passed checks (25 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the removal of duplicate Claude localization strings.
Description check ✅ Passed The description explains the problem, identifies the affected entries, reports the relevant structure and lint tests, preserves locale and placeholder coverage, and states that no app build or native …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input ✅ Passed PASS. The authoritative PR range changes only Resources/Localizable.xcstrings and deletes 590 localization lines. It does not change Cloud terminal creation, transport, renderer gating, input owners…
Cmux Swift Actor Isolation ✅ Passed The pull-request diff changes only Resources/Localizable.xcstrings and deletes localization entries. It contains no .swift files or Swift production changes, so it cannot introduce or worsen the s…
Cmux Swift Blocking Runtime ✅ Passed PASS: The pull request changes only Resources/Localizable.xcstrings and deletes 590 localization lines. It introduces no Swift code and no blocking or timing-based synchronization construct.
Cmux Browser Automation Off-Main ✅ Passed PASS. The authoritative PR diff changes only Resources/Localizable.xcstrings and deletes ten duplicate agent.claude.stopFailure.* localization entries. It contains no browser commands, WebKit/AppK…
Cmux Expensive Synchronous Load ✅ Passed The pull request changes only Resources/Localizable.xcstrings and contains no Swift changes. It does not add or move any synchronous agent-history load or affect an interactive Swift path.
Cmux Cache Substitution Correctness ✅ Passed The pull request changes only Resources/Localizable.xcstrings. The patch deletes localized agent.claude.stopFailure.* records and changes no production Swift, TypeScript, or JavaScript code. There…
Cmux No Hacky Sleeps ✅ Passed The pull request changes only Resources/Localizable.xcstrings and removes duplicate localization entries. It introduces no TypeScript, JavaScript, shell, build/runtime code, timers, sleeps, polling,…
Cmux Algorithmic Complexity ✅ Passed The PR changes only Resources/Localizable.xcstrings and contains 0 additions with 590 deletions. It removes one byte-identical copy of each of ten localization keys; one copy of each key remains. No…
Cmux Swift Concurrency ✅ Passed PASS: The pull request changes only Resources/Localizable.xcstrings and deletes 590 localization lines. It does not modify Swift code or introduce async, Dispatch, Combine, completion-handler, or Ta…
Cmux Swift @Concurrent ✅ Passed The pull request changes only Resources/Localizable.xcstrings and contains no Swift files, Swift declarations, async call sites, or concurrency annotations. The cmux Swift @concurrent check is the…
Cmux Swift Package Boundaries ✅ Passed The authoritative PR diff changes only Resources/Localizable.xcstrings and contains no Swift or package-source changes. The Swift package-boundaries check does not apply.
Cmux Swiftpm Lockfiles ✅ Passed PASS: The review-scoped diff changes only Resources/Localizable.xcstrings, removing duplicate localization entries. It does not change a SwiftPM package, Package.swift, Package.resolved, `.gitig…
Cmux Swift Logging ✅ Passed PASS: The pull request changes only Resources/Localizable.xcstrings and deletes localization entries. It adds or materially changes no Swift code or logging, so the Swift logging failure conditions …
Cmux User-Facing Error Privacy ✅ Passed PASS: The PR changes only Resources/Localizable.xcstrings and contains 0 additions and 590 deletions. It removes duplicate agent.claude.stopFailure.* entries; the head revision retains one copy of…
Cmux Full Internationalization ✅ Passed The PR changes only Resources/Localizable.xcstrings and deletes one duplicate copy of ten agent.claude.stopFailure.* entries. The base has two declarations of each key, and the deleted objects are…
Cmux Swiftui State Layout ✅ Passed The pull request changes only Resources/Localizable.xcstrings and removes localization entries. The diff contains no Swift or SwiftUI changes, so it does not introduce any state or layout violation …
Cmux Architecture Rethink ✅ Passed PASS: The PR changes only Resources/Localizable.xcstrings and deletes 590 lines. It introduces no Swift code, timing or blocking repair path, mutable state, observer, side channel, duplicate entrypo…
Cmux Swift Auxiliary Window Close Shortcuts ✅ Passed PASS: The pull request changes only Resources/Localizable.xcstrings. It adds or changes no Swift-owned auxiliary window, NSWindow, NSPanel, WindowController, Window, or WindowGroup code. The custom ch…
Cmux Source Artifacts ✅ Passed The only changed path is Resources/Localizable.xcstrings, an intentional localization catalog. The diff removes 590 lines and adds no files or artifact content. The removed ten Claude stop-failure e…
Cmux No Test Or Debug Seam In Production Source ✅ Passed PASS: The review-scoped diff changes only Resources/Localizable.xcstrings and deletes localization entries. It contains no Swift file under a production Sources/ path, so it cannot introduce a tes…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Independent and structured review are clean at bcd2525186ca5dce9853956eba2b0a5776633e95. The removed copies are byte-identical to the retained entries; all nine locales and the %@ placeholder are preserved. Catalog structure and lint tests pass.

— Mochi

@teamleaderleo
teamleaderleo enabled auto-merge (squash) September 28, 2026 16:37
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Closing as a duplicate of #15414, which has the same diff and lands when its checks finish.

auto-merge was automatically disabled September 28, 2026 16:43

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant