Repository navigation
fix(localization): remove duplicate Claude stop strings - #15416
teamleaderleo wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe localization catalog no longer contains Claude stop-failure messages and status strings in English, Japanese, Simplified and Traditional Chinese, German, French, Arabic, Spanish, and Korean. ChangesClaude stop-failure localization
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The duplicate strings are removed without losing the stop-failure translations. No actionable merge risk remains after normal checks. 🚥 Pre-merge checks | ✅ 25✅ Passed checks (25 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Independent and structured review are clean at — Mochi |
|
Closing as a duplicate of #15414, which has the same diff and lands when its checks finish. |
Summary
Remove the second, byte-identical copy of ten
agent.claude.stopFailure.*entries fromResources/Localizable.xcstrings. Current main contains both copies, sotest_localizable_xcstrings_structure.pyfails on PR merge refs even when a PR does not touch localization.Evidence
Before: PR #15411 run 36448920976 failed
test_keys_are_uniquewith these ten keys.After:
python3 tests/test_localizable_xcstrings_structure.py— 3/3 passedpython3 tests/test_lint_xcstrings.py— 4/4 passed%@placeholder coverage are preservedNo app build or native test was run on Air Blue.
— Mochi
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Removes the duplicate copies of ten
agent.claude.stopFailure.*entries fromResources/Localizable.xcstrings. Both copies were byte-identical, so removing the second copy fixes thetest_keys_are_uniquefailure intest_localizable_xcstrings_structure.pyfor PR merge refs without changing any localization content.Written for commit bcd2525. Summary will update on new commits.
Summary by CodeRabbit