PR media: classify app changes by CI's build inputs; a reuse error is no refusal - #15386
Conversation
… no refusal reaches_app uses product_input_identity.reaches_product, the classifier CI keys its build on, minus the CLI lane, instead of a separate path list (a relay-policy xcconfig was missed). test-e2e.yml fails a reuse error under its own step, so only a confirmed reuse miss makes a tour compile; an errored one is noted and retried. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
…ur change The reuse step records API and transfer failures as miss reasons, so the error step now reads them too; only a clean miss reaches the refusal that makes a tour compile. cmuxTests/ joins the product inputs no tour shows. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Merge receipt for |
1028a08 test: isolate background workspace git probe fixture (manaflow-ai#15388) 41ad40d fix: keep the terminal area when the window is too narrow for the side panels (manaflow-ai#15369) 2890f0b Roll the Base create back when the owner network resolve fails (manaflow-ai#15358) 7b0a15f Keep agent- and script-opened workspaces and panes in the background (manaflow-ai#15281) 4f14fa3 ci: move CLI regressions to CLI product tests and rebalance the seven app-host shards (manaflow-ai#15177) 906926a ci: dogfood builds are opt-in with the dev-build label (manaflow-ai#15380) 2f6716c PR media: classify app changes by CI's build inputs; a reuse error is no refusal (manaflow-ai#15386) bc28bc4 Release the Base generation when a create is refused for credits (manaflow-ai#15343) 6760c93 iOS: Add Computer never disturbs the active Mac (manaflow-ai#15102) 0f2d3d3 Show Claude sessions that stop on an API error instead of leaving them Running (manaflow-ai#15232) 20ef7c9 Keep the main window floor on the animating setFrame path (manaflow-ai#15368) b4f5dc5 ci: move UI runs pinned to Blacksmith macOS 26 onto owned Macs (manaflow-ai#15383) e02c385 PR media: compile once when CI's build cannot load, and say why a tour skipped (manaflow-ai#15378) ebd1f4f fix(iroh-v2): commit delivery accounting only after the frame is sent (manaflow-ai#15344) # Conflicts: # .github/workflows/ci-guards.yml # .github/workflows/ci-macos.yml # .github/workflows/ci.yml # .github/workflows/pr-media.yml # .github/workflows/test-e2e.yml
|
Subagent review at 48183a3: changes requested. Findings: (MEDIUM) a lookup error that test-e2e recorded as a miss reason still counted as a refusal to compile, so a transient API error could read as an unloadable build. Addressed in 82a43bc (the reuse-error step now inspects the miss reasons). Subagent review at 82a43bc: approved, no further findings. |
1 participant
Summary
Follow-up to #15378, addressing its two CodeRabbit threads.
APP_PATH_PREFIXES) that could drift from what CI builds; it missedconfig/IrohRelayPolicyProduction.xcconfig, for example. It now comes fromproduct_input_identity.reaches_product, the classifier CI keys its app-host build on, minus the CLI lane (CLI/,cmuxCLITests/,cmuxCLITestSupport/).test-e2e.ymlnow fails a reuse error (the reuse step failed, or reported something other than a miss) under its own step. Only a confirmed miss reaches the refuse step that makes a tour compile. A tour whose reuse errored is noted in the comment and retried on the next CI attempt.Testing
python3 tests/test_ci_pr_media.py: 61 tests, including:test-e2e.ymltests/test_ci_e2e_compilation_cache.py,tests/test_ci_canonical_build_root.py,tests/test_e2e_sibling_build.pyand actionlint pass.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Classifies which PRs may compile for a tour from CI's own build-input classifier (
product_input_identity.reaches_product) instead of a handwritten path list, so app changes likeconfig/IrohRelayPolicyProduction.xcconfigare no longer missed. Treats a reuse error as no evidence rather than a refusal:test-e2e.ymlfails it under its own step, the tour is noted as skipped and retried on the next attempt, and only a confirmed reuse miss compiles a tour.cmuxTests/joins the CLI lane as a product input no tour shows.Written for commit 82a43bc. Summary will update on new commits.